Having trouble with right click player listener

Hello all! I'm developing a plugin that first detects when a user right clicks on a fence gate. However, I can not get this simple task to work. Any help would be appreciated

TrainStation:

Code:java

package com.kmccmk9.TrainStation;
 
import org.bukkit.Server;
import org.bukkit.block.Block;
import org.bukkit.block.BlockFace;
import org.bukkit.block.Sign;
import org.bukkit.event.Event;
import org.bukkit.event.Event.Priority;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
import com.kmccmk9.TrainStation.TrainStationPlayerListener;
 
/**
 * TrainStation for Bukkit
 * 
 * @author kmccmk9
 */
 
public class TrainStation extends JavaPlugin {
    //Variables
    Server server;
    private TrainStationPlayerListener playerListener;
    BlockFace SignBlockFace;
    //OnDisable
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        System.out.println( pdfFile.getName() + " is disabled!" );
    }
    //OnEnable
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        System.out.println( pdfFile.getName() + " version " + pdfFile.getVersion() + " is enabled!" );
        server = this.getServer();
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvent(Event.Type.PLAYER_INTERACT, playerListener, Priority.Normal, this);
    }
    //IsBlockGate
    public boolean blockIsValidGateBlock(Block block) {
        // TODO: Make this exception more specific
        try {
            int GateBlock = block.getTypeId();
            if (GateBlock == 107)
            {
                server.broadcastMessage("You clicked a gateblock");
                return true;
            }
        } catch (Exception e) {
 
        }
        server.broadcastMessage("You did not click a gateblock");
        return false;
    }
    //IsSignTrain
    public String getTrainStationSignName(Block block) {
        // TODO: Make this exception more specific
        try {
            Sign sign = (Sign)block.getRelative(block.getX(), block.getY(), block.getZ()+2);
            server.broadcastMessage(sign.getLine(1));
            return sign.getLine(1);
        } catch (Exception e) {
 
        }
        server.broadcastMessage("No Name");
        return "No Name";
    }
    //TrainCost
    public String getTrainStationCost(Block block) {
        // TODO: Make this exception more specific
        try {
            Sign sign = (Sign)block.getRelative(block.getX(), block.getY(), block.getZ()+2);
            server.broadcastMessage(sign.getLine(2));
            return sign.getLine(2);
        } catch (Exception e) {
 
        }
        server.broadcastMessage("No Cost");
        return "No Cost";
    }
}

TrainStationPlayerListener:

Code:java

package com.kmccmk9.TrainStation;
 
import org.bukkit.block.Block;
import org.bukkit.block.Sign;
import org.bukkit.entity.Player;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerListener;
 
public class TrainStationPlayerListener extends PlayerListener {
    private TrainStation plugin;
    public TrainStationPlayerListener(final TrainStation plugin) {
        this.plugin = plugin;
    }
    public void onPlayerInteract(PlayerInteractEvent event) {
        Player p = event.getPlayer();
        String TrainStationName;
        int Cost;
        if (event.hasBlock() && event.getClickedBlock().getState() instanceof Block && event.getAction() == Action.RIGHT_CLICK_BLOCK)
        {
            if ((plugin).blockIsValidGateBlock(event.getClickedBlock()))
            {
                TrainStationName = (plugin).getTrainStationSignName(event.getClickedBlock());
                if (TrainStationName == "[TrainStation]")
                {
                    Cost = Integer.parseInt((plugin).getTrainStationCost(event.getClickedBlock()));
                }
            }
            else
            {
                plugin.server.broadcastMessage("Not a Gate Block");
            }
        }
    }
}

 

You never create the TrainStationPlayerListener instance. Change line 24 in the main class to private TrainStationPlayerListener playerListener = new TrainStationPlayerInstance(this);

It might also need to be public instead of private, I can't remember.

 

Here's a fix for line 19 of your Listener:

PHP:

if (event.getAction() == Action.RIGHT_CLICK_BLOCK) {

That's all you need to check for a right click of a block.

 

Thanks for the replies. It now notices I clicked the gate. However, it does not recognize the sign two blocks above it

Would this be because I am using the relative block function with the variable of a blockface that is set to nothing?