Solved Handling Reloads?

Hey I'm having some trouble getting this plugin to work after the server is reloaded. Once you do /reload, it continues to run. Then if you do the command to start the plugin, it will run 2 sets of the same plugin (I hope that makes sense). Any Help?

Code:java

package me.Ian.AutoMessager;
 
import java.util.Timer;
import java.util.TimerTask;
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class AutoMessager extends JavaPlugin implements Listener {
    public final Logger logger = Logger.getLogger("Minecraft");
    public static AutoMessager plugin;
    public static int nums = 0;
    public static int counter = 0;
 
 
    protected String Chatcolor;
        final String message = ("Visit our website at [url="http://www.economicallycrafted.enjin.com"]www.economicallycrafted.enjin.com[/url]");
        final String message2 = ("Don't forget to vote at [url="http://www.economicallycrafted.enjin.com"]www.economicallycrafted.enjin.com[/url]");
        final String message3 = ("Don't forget to check both our RPG, and Survival part of the server!");
 
 
    @Override
    public void onEnable(){
        logger.info("Automessage Enabled!");   
        PluginManager pm = this.getServer().getPluginManager();
        pm.registerEvents(this, this);
 
 
 
    }
    @Override
    public void onDisable(){
        logger.info("Ian's Automessager has been Disabled");   
    }
 
 
@Override
    public boolean onCommand(final CommandSender sender, Command cmd, final String commandLabel, String[] args){
 
        Player player = (Player) sender;
        if (Global.counter == 0){
        if(commandLabel.equalsIgnoreCase("AmStart")){
 
 
 
 
            player.sendMessage(ChatColor.BLUE + "Now running the auto message " + ChatColor.DARK_GRAY +  message);
            Global.counter++;
        if (Global.counter > 0 && Global.nums < 3){
 
 
        final Timer timer = new Timer ();
        TimerTask hourlyTask = new TimerTask () {
 
 
            @Override
            public void run () {
 
                if (Global.nums == 0){
                Bukkit.broadcastMessage(ChatColor.BLUE + "[AutoMessager] " + ChatColor.GRAY + message);
                }else if (Global.nums == 1){
                    Bukkit.broadcastMessage(ChatColor.BLUE + "[AutoMessager] " + ChatColor.GRAY + message2);
                }else if (Global.nums == 2){
                    Bukkit.broadcastMessage(ChatColor.BLUE + "[AutoMessager] " + ChatColor.GRAY + message3);
                }
                Global.nums++;
                if (Global.nums == 3){
                    Global.nums = 0;
                }
                }
 
 
 
 
 
 
        };
 
            timer.schedule (hourlyTask, 10000, 10000);
        }else if (Global.counter > 1){
            player.sendMessage(ChatColor.RED + "You are already running AutoMessager!" );
            player.sendMessage(ChatColor.RED + "If AutoMessager is not running, conatact Ian!");
        }else{
            player.sendMessage(ChatColor.RED + "Error with plugin code 2, contact Ian!");
        }
 
 
 
        }
 
 
        };   
 
        return true;
 
 
 
 
 
 
 
 
 
 
 
 
    }
 
 
}

I just started coding plugins, so any other help would be great. Thanks!

 

The reload command should automatically handle for disabling the plugin..

 

The reload command works fine, it says disabled plugin, enabled plugin. But the plugin continues to run.

Before the reload, If I do /amstart multiple times it doesn't break.

But If I reload the plugin and do /amstart, it starts another loop of messages.

 

/reload will not automaticly remove everything of your plugin from memory.
You have to clean up yourself.
Set all instances your plugin creates to "null" in the onDisable(),
cancel all scheduled tasks of your plugin,
and I'm sure some other things have to be done to properly reset your plugin.

Generally: A /reload is a "worst case" scenario for a bukkit plugin.
If I were you, I would never ever use it. Just do a proper restart to avoid memory leaks and other crazy problems.
Each of your plugins (and especially plugins of other authors you use) can act up upon reload,
because only a minority of them is really designed to hande reloads 100% correct.
Just as a heads-up.

 

use the Bucket Scheduler instead of the timer class in java, the bukkit scheduler handles reload automatically (and is thread safe)

 

Okay thank's both of you and I'll try to put in the Bukkit Scheduler.