GUI Permissions

Ok.
Is this possible,
Say I had a GUI inventory with several items, let's just say their is, Kill, Burn, and Heal
I want it so they can see the kill icon BUT it won't let them use it if they don't have a permission

 

KoolzSkillz do a permission check when they attempt to use it. Player#hasPermission(String permission)

 

fireblast709
i have this so far, it ALMOST works, it doesnt let me do it if they dont have permission BUT it also runs the LAVA_BUCKET case

Code:

        switch(event.getCurrentItem().getType()) {
        case PAPER:
            player.closeInventory();
            player.sendMessage(ChatColor.GREEN
                    + "[News] : "
                    + getConfig().getString("news"));
            break;
        case WATER_BUCKET:
            if (!player.hasPermission("ICommands.Enderchest")) {
                player.sendMessage(ChatColor.RED + "No Permission To Use This");
            } else {
            player.closeInventory();
            player.setHealth(20);
            player.setFireTicks(0);
            player.sendMessage(ChatColor.GREEN + "Healed");
            break;
        case LAVA_BUCKET:
            player.closeInventory();
            player.setHealth(0);
            player.sendMessage(ChatColor.GREEN + "Killed");
            break;
            default:
                player.closeInventory();
                break;
        }
    }

 

KoolzSkillz where did the closing brace for the else clause go? (in the WATER_BUCKET case). The break; should be after that closing brace.

 

fireblast709
It Works Now Thank you, the only problem is that it says the no permission msg twice

 

KoolzSkillz Updated code? (Perhaps also a bit more of the code, like the whole event handler)

 

fireblast709 here

Full Code

Show Spoiler Hide Spoiler

Code:

    @EventHandler
    public void onInventoryClick(InventoryClickEvent event) {
        if (!ChatColor.stripColor(event.getInventory().getName())
                .equalsIgnoreCase("ICommands Commands"))
            return;
        Player player = (Player) event.getWhoClicked();
        event.setCancelled(true);
 
        if (event.getCurrentItem() == null
                || event.getCurrentItem().getType() == Material.AIR
                || !event.getCurrentItem().hasItemMeta()) {
            player.closeInventory();
            return;
        }
     
        switch(event.getCurrentItem().getType()) {
        case PAPER:
            player.closeInventory();
            player.sendMessage(ChatColor.GREEN
                    + "[News] : "
                    + getConfig().getString("news"));
            break;
        case WATER_BUCKET:
            if (!player.hasPermission("ICommands.Heal")) {
                player.sendMessage(ChatColor.RED + "No Permission To Use This");
            } else {
            player.closeInventory();
            player.setHealth(20);
            player.setFireTicks(0);
            player.sendMessage(ChatColor.GREEN + "Healed");
            }
            break;
        case LAVA_BUCKET:
            if (!player.hasPermission("ICommands.Kill")) {
                player.sendMessage(ChatColor.RED + "No Permission To Use This");
            } else {
            player.closeInventory();
            player.setHealth(0);
            player.sendMessage(ChatColor.GREEN + "Killed");
            }
            break;
           
           
           
           
            default:
                player.closeInventory();
                break;
    }

 

KoolzSkillz Did you perhaps registered the Listener twice by accident?

 

fireblast709
I had it registered twice, I was gonna make another class with another GUI but haven't got around to it XD
Thx a lot for your help

fireblast709
I have one more question, with the GUI if I click kill, can I get it to open another inventory with all the online players and I click the one I want to kill?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

KoolzSkillz schedule a task with runTask(Plugin), close the inventory within that task. After you've done that, schedule another task (yay task-ception) that opens the new inventory. For some clarification:

Code:

new BukkitRunnable()
{
    @Override
    public void run()
    {
        // Close old inventory
        new BukkitRunnable()
        {
            @Override
            public void run()
            {
                // Open new inventory
            }
        }.runTask(plugin instance);
    } 
}.runTask(plugin instance);

 

fireblast709
Ok thx

 

You don't need to do that. Close the inventory above the task, then within it (meaning only one task needed) open the new inventory. (Only 1 tick is needed)

 

thomasb454 read the documentation before you correct people

Source: http://jd.bukkit.org/dev/apidocs/org/bukkit/event/inventory/InventoryClickEvent.html

 

Fair enough, but you don't have to. I do it all the the time, works fine.

 

thomasb454 "isn't safe" generally implies that it will work sometimes and will go horrifically other times. Otherwise, they would have said that it doesn't work. Take async method calls for example, they could work perfectly fine 99 times out of 100 and then corrupt the world the other time

 

thomasb454

But you should. If you don't, you could crash the client (at least, I think that's the side effect of that).

 

How I've ALWAYS done it, and so have many others. Works fine, I understand that I'm not going to get anywhere, so /thread, for me, at least.

 

thomasb454

And it's against the specification and could break things. There's a reason they don't recommend doing it and you should follow the recommendation.