Getting players in a circle radius

Hey.. I've come across a thing where I have to get players in circle and give them and effect. Also, in that circle I have to create the smoke effect.

I have these methods that help, but I was told the getPlayers(...) wouldn't work.

Code:java

    public static List<Block> getBlocks(Location center, int radius, boolean hollow, boolean sphere){
        List<Location> locs = circle(center, radius, radius, hollow, sphere, 0);
        List<Block> blocks = new ArrayList<Block>();
 
        for(Location loc : locs){
            blocks.add(loc.getBlock());
        }
 
        return blocks;
    }
 
    public static List<Player> getPlayers(Location center, int radius, boolean hollow, boolean sphere){
        List<Location> locs = circle(center, radius, radius, hollow, sphere, 0);
        List<Player> players = new ArrayList<Player>();
 
        for(Location loc : locs){
            for(Player p : Bukkit.getOnlinePlayers()){
                if(p.getLocation().equals(loc)){
                    players.add(p);
                }
            }
        }
 
        return players;
    }
 
    private static List<Location> circle(Location loc, int radius, int height, boolean hollow, boolean sphere, int plusY){
        List<Location> circleblocks = new ArrayList<Location>();
        int cx = loc.getBlockX();
        int cy = loc.getBlockY();
        int cz = loc.getBlockZ();
 
        for(int x = cx - radius; x <= cx + radius; x++){
            for (int z = cz - radius; z <= cz + radius; z++){
                for(int y = (sphere ? cy - radius : cy); y < (sphere ? cy + radius : cy + height); y++){
                    double dist = (cx - x) * (cx - x) + (cz - z) * (cz - z) + (sphere ? (cy - y) * (cy - y) : 0);
 
                    if(dist < radius * radius && !(hollow && dist < (radius - 1) * (radius - 1))){
                        Location l = new Location(loc.getWorld(), x, y + plusY, z);
                        circleblocks.add(l);
                    }
                }
            }
        }
 
        return circleblocks;
    }

Hopefully someone understands what I'm trying to do. Thanks in advanced!

 

Code:java

public List<String> getPlayersInRange(double radius, Location loc) {
    List<String> players = new LinkedList();
    for(Player p : Bukkit.getOnlinePlayers()){
        if(p.getLocation().distance(loc) <= radius){
            players.add(p.getName());
        }
    }
    return players;
}

Then do whatever to the corresponding players.

 

1Rogue What's "loc" meant to be..?

 

Sorry about that, I meant to pass it in the method. But you should be able to just pass the center of the circle using this.