Solved Get just the worlname [HELP]

Hello, the goal here is to get the worlname but just the world name. Getting it right now says: craftworld: world. But I just want the world part. I tried doing a substring but that didn't work at all.

This is the code I'm using just to try and get it to make a substring at all. Thanks for your help.

Code:

String worldname = player.getLocation().getWorld().getName().toString();
while (i < total)
{
if (players[i].isOp() || players[i].hasPermission("helpmeadvanced.admin")) {
players[i].sendMessage(ChatColor.DARK_RED + player.getDisplayName() + ChatColor.DARK_GREEN + " needs some help!" + " (" + worldname.substring(17,20) + player.getLocation().getBlockX() + ',' + player.getLocation().getBlockY() + ',' + player.getLocation().getBlockZ() + ") Description: " + description);  
}
i++;
} 

 

No clue im new at plugins

 

That's okay thanks. Ya its weird I can get the world but that function returns: craftworld=world. So I thought to use a substring but that doesn't seem to work at all.

 

Ya sorry, I only commented to bump the post and show that someone is actually reading your post.

 

Thanks. I appreciate it...

 

Err....whyever do you call .toString() on the name string that you've already gotten?

It's like opening an envelope and then seal it again to try and retrieve the message

 

Ya that was my other attempt. My though was that doing .toString() would possibly remove the extra data that was coming through without it. But even so, shouldn't the substring have worked either way?

 

Not the way you are doing it. You are trying to reach an index in the string that doesn't exist (17). I think if you did substring(12), it would have worked. But either way, getName() returns the name of the world, plainly, no more, no less.

 

Really? Cause when I did that origianlly it returned {CraftWorld = World} on my screen

 

You sure you didn't do getWorld().toString();?

try again please? getWorld().getName();

 

Sure no problem, compiling now.

EDIT:
Still did not work. Would you like pictures?

Okay now this is really odd. I added this line of code and the server didn't broadcast anything

Code:java

String worldname = player.getLocation().getWorld().getName();
server.broadcastMessage(worldname);

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

That's weird. What is your whole code?

By the way, Entity has a getWorld() method, so you can change it to

Code:

player.getWorld().getName();

 

This is my code posted on pastebin

 

And do you get an error?

 

None

 

To divide "craftworld: world" into just "world" you could try this.(untested)

Code:

public String[] results = new String[2];
 
results = player.getWorld().getName().split(":");
 
results[1] = results[1].trim();

Then results[1] would be "world"

 

Oh interesting way to do it. I can give that a shot.

EDIT:
Still not fixed. Why isn't this working, it doesn't make any sense.

 

What isn't working about it?

 

It is still displaying the {CraftWorld=world}

 

Oh well then try this.

Code:

       
String[] results = new String[2];
       
results = player.getWorld().getName().split("=");
           
results[1].replace("}", " ");
       
results[1].trim();

Results[1] should now be "world"

 

Nope note even that. The exact line is
{Craftworld{name=world}}

 

Okay. Someone already told you this but don't use toString on something that is already a string. But if player.getWorld().getName() returns {Craftworld{name=world}} then you need to just use some string methods like I showed before hand to get it to give you the world. Like this.

Code:

        worldname.replaceAll("{Craftworld{name=", "");
        worldname.replaceAll("}}", "");

If this doesn't work there is definelty something I'm not understanding.
P.S.If it gives you an error for having "" and nothing inside just put a space in there and then do worldname.trim();
P.P.S. you could also try player.getWorld().getWorldFolder().getName(); which would return the name of the world's folder which should be its ingame name. Actually that would probley be better than the other methods....

 

Okay, ya there is no error and there is no toString anymore. I will try and use your code now.

EDIT:

Still not working. This is exactly what I'm getting.

 

Please try using player.getWorld().getWorldFolder().getName()

If that doesn't work stilllllllllllll then could you post your code(If it's not too much) into here so I can see it all because I can't load your original paste bin post and my computer in general doesn't like loading paste bin stuff for some reason.

 

Sure here it is:

Code:java

package com.kmccmk9.HelpMeAdvanced;
 
// All the imports
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Hashtable;
import java.util.Scanner;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
import org.bukkit.Server;
 
/**
* HelpMeAdvanced for Bukkit
*
* @author kmccmk9
*/
 
//Starts the class
public class HelpMeAdvanced extends JavaPlugin{
    Server server;
    String variable;
    Scanner msgs;
    String description;
    ArrayList<String> messagestoprint = new ArrayList<String>();
    Hashtable<String, String> playerdescriptions = new Hashtable<String, String>();
    Hashtable<String, World> playerlocations = new Hashtable<String, World>();
    ArrayList<String> playernames = new ArrayList<String>();
    Location gotolocation;
    Player gotoplayer;
    int counter = 1;
    int number;
    String numberstring;
    int arraylength;
 
    //Define File Variables
    static String mainDirectory = "plugins/HelpMeAdvanced"; //sets the main directory for easy reference
    static File messages = new File(mainDirectory + File.separator + "messages.txt"); //the file separator is the / sign, this will create a new Zones.dat files in the mainDirectory variable listed above, if no Zones directory exists then it will automatically be made along with the file.
    // onDisable
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        System.out.println( pdfFile.getName() + " is disabled!" );
    }
    // onEnable
    public void onEnable() {
        server = this.getServer();
        PluginDescriptionFile pdfFile = this.getDescription();
        System.out.println( pdfFile.getName() + " version " + pdfFile.getVersion() + " is enabled!" );
        //Setup Files
        new File(mainDirectory).mkdir(); //makes the Zones directory/folder in the plugins directory
        if(!messages.exists()){ //Checks to see if the zones file exists, defined above, if it doesn't exist then it will do the following. the&nbsp;! turns the whole statement around, checking that the file doesn't exist instead of if it exists.
            try { //try catch clause explained below in tutorial
                messages.createNewFile(); //creates the file zones.dat
                FileWriter writer = new FileWriter(messages,true);
                BufferedWriter out = new BufferedWriter(writer);
                out.write("An Admin or SuperAdmin will come and help you soon as possible.");
                out.newLine();
                out.write("If no one come and helps you within 5 minutes, perform the command again.");
                out.newLine();
                out.write("Message sent to Admins");
                out.close();
            } catch (IOException ex) {
                ex.printStackTrace(); //explained below.
            }
 
        } else {
 
            openFile();
            readFile();
            closeFile();
 
        }
    }
 
    private void openFile() {
        try{
            msgs = new Scanner(messages);
        }catch (Exception ex){
            System.out.println("[HelpMeAdvanced] Could not find messages.txt, did you delete it?");
        }
    }
 
    private void readFile() {
        if (!msgs.hasNextLine()){ //Check if there are no lines at all
            server.broadcastMessage("[HelpMeAdvanced] Messages.txt is empty.");
        }else{
            messagestoprint.clear(); //Clear the ArrayList (For using the reload command)
            while (msgs.hasNextLine()){
                String messagetofile = msgs.nextLine(); //Set the next line to a string
                messagetofile = messagetofile.replaceAll("(&([a-f0-9]))", "\u00A7$2"); //Replace colour codes
                messagestoprint.add(messagetofile); //Add to the ArrayList
            }
        }
    }
 
    private void closeFile() {
        msgs.close();
    }
 
    public String arrayToString(String[] array) {
        StringBuilder sb = new StringBuilder();
        for (int a = 1; a < array.length; a++) {
        sb.append(array[a]);
        sb.append(" ");
        }
        String newString = sb.toString();
        return newString;
        }
 
    // Command system
    public boolean onCommand(CommandSender sender, Command command, String commandLabel, String[] args) {
        Player[] players;
        int total;
        if (sender instanceof Player) {
            Player player = (Player) sender;
            if(commandLabel.equalsIgnoreCase("helpme")) {
                if (args.length == 1)
                {
                    variable = args[0];
                    if (variable.equalsIgnoreCase("help"))
                    {
                        player.sendMessage("Typing in \"/helpme will alert Admins that you need help!\"");
                        player.sendMessage("Typing in \"/helpme description \"Description here\" (Without quotes) will alert Admins that you need help and add a description");
                        player.sendMessage("Typing in \"/helpme reload will reload the messages file\"");
                        player.sendMessage("Typing in \"/helpme list will list the players that need help if you are the admin\"");
                        player.sendMessage("Typing in \"/helpme goto \"Number from list here\" (Without quotes) will teleport you to the person in need and remove them from the list\"");
                        player.sendMessage("Typing in \"/helpme remove \"Number from list here\" (Without quotes) will remove that player from the list\"");
                    }
                    if (variable.equalsIgnoreCase("description"))
                    {
                        player.sendMessage(ChatColor.DARK_RED + "Missing description. Please add a one word description.");
                    }
                    if (variable.equalsIgnoreCase("reload"))
                    {
                        readFile();
                    }
                    if (variable.equalsIgnoreCase("list"))
                    {
                        for (int i=0;i<playernames.size();i++)
                        {
                            player.sendMessage(ChatColor.GREEN + String.valueOf(counter) + '.' + " " + playernames.get(i).toString() + '-' + " " + playerlocations.get(playernames.get(i).toString()) + " " + '-' + " " + playerdescriptions.get(playernames.get(i).toString()));
                            counter++;
                        }
                        counter = 1;
                    }
                    if (!variable.equalsIgnoreCase("help") && !variable.equalsIgnoreCase("description") && !variable.equalsIgnoreCase("reload") && !variable.equalsIgnoreCase("list"))
                    {
                        player.sendMessage(ChatColor.DARK_RED + "Unrecognized argument. Typing in /helpme will alert Admins that you need help!");
                    }
                }
                else if (args.length > 1)
                {
                    if (variable.equalsIgnoreCase("description"))
                    {
                        description = arrayToString(args);
                        this.getServer().broadcastMessage(description);
                    }
                    //Add Players to List
                    playerlocations.put(player.toString(), player.getLocation().getWorld());
                    playerdescriptions.put(player.toString(), description);
                    playernames.add(player.toString());
                    //Degbug
                    //Dispatch Message
                    for (int j = 0;j < arraylength;j++)
                    {
                    player.sendMessage(messagestoprint.get(j));
                    }
                    players = server.getOnlinePlayers();
                    total = players.length;
                    int i = 0;
                    String worldname = player.getWorld().getWorldFolder().getName();
 
                    worldname.replaceAll("{Craftworld{name=", "");
                    worldname.replaceAll("}}", "");
 
                    server.broadcastMessage(worldname);
                    while (i < total)
                    {
                        if (players[i].isOp() || players[i].hasPermission("helpmeadvanced.admin")) {
                            players[i].sendMessage(ChatColor.DARK_RED + player.getDisplayName() + ChatColor.DARK_GREEN + " needs some help!" + " (" + worldname + player.getLocation().getBlockX() + ',' + player.getLocation().getBlockY() + ',' + player.getLocation().getBlockZ() + ") Description: " + description); 
                        }
                        i++;
                    }
                    if (variable.equalsIgnoreCase("goto"))
                    {
                        numberstring = arrayToString(args);
                        number = Integer.parseInt(numberstring);
                        gotoplayer = server.getPlayer(playernames.get(number));
                        gotolocation = gotoplayer.getLocation();
                        playerlocations.remove(playernames.get(number));
                        playerdescriptions.remove(playernames.get(number));
                        player.teleport(gotolocation);
                    }
                    if (variable.equalsIgnoreCase("remove"))
                    {
                        numberstring = arrayToString(args);
                        number = Integer.parseInt(numberstring);
                        playerlocations.remove(playernames.get(number));
                    }
                }
                else if (args.length == 0)
                {
                    //Debug
                    arraylength = messagestoprint.size();
                    //Add Player to list
                    playerlocations.put(player.toString(), player.getLocation().getWorld());
                    playerdescriptions.put(player.toString(), " ");
                    playernames.add(player.toString());
                    for (int j = 0;j < arraylength;j++)
                    {
                    player.sendMessage(messagestoprint.get(j));
                    }
                    players = server.getOnlinePlayers();
                    total = players.length;
                    int i = 0;
                    while (i < total)
                    {
                        if (/*HelpMeAdvanced.permissionHandler.has(players[i], "helpmeadvanced.admin") ||*/ players[i].isOp() || players[i].hasPermission("helpmeadvanced.admin")) {
                            players[i].sendMessage(ChatColor.DARK_RED + player.getDisplayName() + ChatColor.DARK_GREEN + " needs some help!" + " (" + player.getLocation().getWorld() + player.getLocation().getBlockX() + ',' + player.getLocation().getBlockY() + ',' + player.getLocation().getBlockZ() + ")"); 
                        }
                        i++;
                    }
                }
            }
        }
        return true;
    }
}[/i][/i][/i][/i][/i][/i][/i]

 

kmccmk9

This line (161 )could be false...

Code:java

else if (args.length > 1)
//maybe you're looking for "args.length >= 1" ??
 

and passing the check onto line (211)...

Code:java

else if (args.length == 0)

And then that runs... (lines 226 - 232)

Code:java

while (i < total)
{
if (/*HelpMeAdvanced.permissionHandler.has(players[I], "helpmeadvanced.admin") ||*/ players[I].isOp() || players[I].hasPermission("helpmeadvanced.admin")) {[/I][/I][/I]
[I]players[I].sendMessage(ChatColor.DARK_RED + player.getDisplayName() + ChatColor.DARK_GREEN + " needs some help!" + " (" + player.getLocation().getWorld() + player.getLocation().getBlockX() + ',' + player.getLocation().getBlockY() + ',' + player.getLocation().getBlockZ() + ")");[/I][/I]
[I]}[/I]
[I]}[/I]

Which has the bad code on line 229:

Code:java

player.getLocation().getWorld()
 
//This will output "{CraftWorld=world}"

Change that to

Code:java

player.getWorld().getName()

And see what happens.

 

Use player.getWorld().getName() not player.getLocation().getWorld().getName().

 

Oops... Changing that...

 

should be easy

Code:

p.sendMessage(Bukkit.getWorld("worldname"));

 

This returns that actual World object itself, which is not a string by any means and implies he already has the world name itself, while the goal is to obtain the worldname.