Get all online players and put in map/list

Having trouble getting all the online players and putting them in a map.
This is what I tried

Code:

Player[] onlinePlayerList = Bukkit.getServer().getOnlinePlayers();
int i = 0;
for(Player player : onlinePlayerList){
i++;
  playerMap.put("target" + i , player);

Any easier ways to do this?

EDIT: Here is my full, messy code

Code:

package me.woobie.mcd;
 
import java.util.HashMap;
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.AsyncPlayerChatEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener{
    HashMap<String , Player > playerMap = new HashMap<String , Player >();
    public Logger log = Logger.getLogger("Minecraft");
 
    public void onEnable(){
        log.info("[MCD] Plugin Enabled");
        this.getServer().getPluginManager().registerEvents(this, this);
     
    }
 
    public void onDisable(){
        log.info("[MCD] Plugin Disabled");
     
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLable, String[] arg) {
        Player p = (Player) sender;
                if(cmd.getName().equalsIgnoreCase("mchatenable")){
                    Player[] onlinePlayerList = Bukkit.getServer().getOnlinePlayers();
                    if(!(p.hasPermission("mchat.bypass"))){
                    int i = 0;
                    for(Player player : onlinePlayerList){
                        i++;
                        playerMap.put("target" + i , player);
                        Bukkit.getServer().broadcastMessage(ChatColor.RED+ "The chat has been disabled!");
                    }
                     
                    } else {
                        if(playerMap.containsKey(p)){
                            playerMap.remove(p);
                        }
                    }
                        if(cmd.getName().equalsIgnoreCase("mchatdisable")){
                            if(playerMap.containsKey(Bukkit.getOnlinePlayers())){
                                playerMap.remove(Bukkit.getOnlinePlayers());
                                Bukkit.getServer().broadcastMessage(ChatColor.GREEN+ "The chat has been enabled!");
                            }
                        }
                    }
             
                return false;
             
                }
                 
                    @EventHandler
                    public void onChat(AsyncPlayerChatEvent e){
                        Player p = e.getPlayer();
                        if(playerMap.containsKey(p)){
                            e.setCancelled(true);
                            p.sendMessage(ChatColor.RED+ "The chat is disabled!");
                        }
                    }
                }
                

Only thing that works is this

Code:

Bukkit.getServer().broadcastMessage(ChatColor.RED+ "The chat has been disabled!");

No errors, this

Code:

 if(cmd.getName().equalsIgnoreCase("mchatenable")){

just logs a message "Woobie issued command /mchatenable" or something, I did register the event, as you can probably see.
I can still talk, even if I dont have permission for it, and the chat is disabled.

 

Do you really need the Player Objects, or would it be enough to save the playernames?
Saving Player Objects could end in serious memory leaks...

Arrays.asList(Bukkit.getServer().getOnlinePlayers());

 

I know, I used that just for now, since I was only testing the plugin if it works.

 

I hava rewritten your code, i hope this fixes your problem

Code:java

 
package me.woobie.mcd;
 
import java.util.HashMap;
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.AsyncPlayerChatEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
    private boolean chatDisabled = false;
    public Logger log = Logger.getLogger("Minecraft");
 
    public void onEnable() {
    log.info("[MCD] Plugin Enabled");
    this.getServer().getPluginManager().registerEvents(this, this);
 
    }
 
    public void onDisable() {
    log.info("[MCD] Plugin Disabled");
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLable, String[] arg) {
    Player p = (Player) sender;
    if (cmd.getName().equalsIgnoreCase("mchatenable")) {
        chatDisabled = true;
        Bukkit.getServer().broadcastMessage(ChatColor.RED + "The chat has been disabled!");
    } else if (cmd.getName().equalsIgnoreCase("mchatdisable")) {
        chatDisabled = false;
        Bukkit.getServer().broadcastMessage(ChatColor.GREEN + "The chat has been enabled!");
    }
    return false;
    }
 
    @EventHandler
    public void onChat(AsyncPlayerChatEvent e) {
    Player p = e.getPlayer();
    if (chatDisabled) {
        if (!p.hasPermission("mchat.bypass")) {
        e.setCancelled(true);
        p.sendMessage(ChatColor.RED + "The chat is disabled!");
        }
    }
    }
}
 

 

Could this be the plugin I compiled for you?
btw, it worked

 

Awesome, and yeah this is. I always do everything in the hard way, I dont know why I didnt use booleans earlier -_-

 

Code:

for(Player all:getServer().getOnlinePlayers()){
list.add(all.getName();
}

 

gomeow
I tried to use the coding and it has a few errors.. What is wrong? The error is where it says " public void onChat(AsyncPlayerChatEvent e) {" The error is with the "()"

Code:

if (cmd.getName().equalsIgnoreCase("chatenable")) {
                chatDisabled = true;
                Bukkit.getServer().broadcastMessage(ChatColor.RED + "The chat has been disabled! Only staff can chat now!");
            } else if (cmd.getName().equalsIgnoreCase("chatdisable")) {
                chatDisabled = false;
                Bukkit.getServer().broadcastMessage(ChatColor.GREEN + "The chat has been enabled for everyone!");
            }
            return false;
            }
       
            @EventHandler
            public void onChat(AsyncPlayerChatEvent e) {
            Player p = e.getPlayer();
            if (chatDisabled) {
                if (!p.hasPermission("skits.mod") || !p.hasPermission("skits.tmod")) {
                e.setCancelled(true);
                p.sendMessage(ChatColor.RED + "The chat is disabled!");
                    }
                }
            }

 

ajs333
I find it funny how you bumped an old thread created by me on my old account, and now I'm kind of answering my own question. What is the error?

 

Assist
I never bumped your old thread but I fixed it!

 

ajs333
Yes you did, check the last post date (Oct 23, 2012), over a year ago. Also, Woobie is my old account, so yes, you did bump my thread.