Solved Fires over 50 times, only called once?

I really don't know...
Here's what's happening:


https://github.com/skipperguy12/MoneyBukkit2

So, I really don't know how that's happening...It does eventually stop sending messages, but it's not even supposed to send more than one.

I believe the problem is around here:
https://github.com/skipperguy12/Mon...ukkit2/listeners/ExampleSignListener.java#L51

But I still don't see how it's happening

No errors in console

 

Not relevant to the problem, but please only use exceptions in exceptional situations. Someone rightclicking something besides a sign is definitely not an exceptional circumstance. Just do an instanceof check. A catch statement is rather slow.

 

If you commented your code, we would be able to help you so much more.

 

where are you sending that message?

 

Vynlar The last link brings you directly to the line of the problem. I don't need to comment where I am simply calling a method ._.

nitrousspark
https://github.com/skipperguy12/Mon...ukkit2/listeners/ExampleSignListener.java#L51

Tjstretchalot
I do do an instanceof check, for the sign. Just in case it still doesn't work, I know what's going on :l

 

skipperguy12

If you do an instanceof check, then it is impossible for the cast to fail. So remove the try-catch to avoid redundant code

 

Tjstretchalot
Okay, i'll take it out later. But as of right now, the actual problem is the messages

49 views...anyone see a problem?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

The right click interact fires every tick while holding your mouse down, which often causes it to fire 3-4 times. But it definitely shouldn't be called 50 times.

 

Just a guess here but it looks like in your https://github.com/skipperguy12/Mon...oneyBukkitPlayerMoneyChangeEventListener.java listener, you are checking if the person has enough money for the transaction (somewhat). If they don't, you then set their money to 0 (which doesn't work because your call just tries to subtract 0 from their current amount). This call then triggers another check to see if they have enough money which makes everything repeat.

 

Jeyge
Haha, didn't see that. Thanks!