Solved error when calling method from another class

Hello, lets have a look on this code:

Code:java

 
public void item() {
 
Location loc;
 
loc = new Location(
 
  Bukkit.getServer().getWorld(plugin.getConfig().getString("Loc.world")),
 
plugin.getConfig().getDouble("Loc.x"),
 
plugin.getConfig().getDouble("Loc.y"),
 
plugin.getConfig().getDouble("Loc.z"));
 
  Block b = World.getBlockAt(loc); // The method getBlockAt(Location) is undefined for the type World
Sign s = (Sign) b;
s.setLine(1, "Your e");
}
 

it should get cordinates from config, and change text on sign, but unfortunatelly getBlockAt refuses to work... if anybody know why, i would be gratefull.

Thanks in advance

 

Because you are calling it as if it's a static method, when it is not.

Perhaps you meant to do

loc.getWorld().getBlockAt(loc)

 

World is not static (at least with what you are trying to do). Do what tehbeard said.

Code:java

Block block = loc.getWorld().getBlockAt(loc);

 

i would never get to this point alone.. Thanks!

anyway, i would like to run this piece of code as thread, so my sign is updated every few seconds, but it gives me error:
00:38:25 [SEVERE] Exception in thread "pool-1-thread-189"
00:38:26 [SEVERE] org.apache.commons.lang.UnhandledException: Plugin sgwall vr01
generated an exception while executing task 427
at org.bukkit.craftbukkit.v1_4_R1.scheduler.CraftAsyncTask.run(CraftAsyn
cTask.java:56)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NullPointerException
at pl.chinchill.SgWall.SignUpdater.item(SignUpdater.java:27)
at pl.chinchill.SgWall.SgWall$1.run(SgWall.java:29)
at org.bukkit.craftbukkit.v1_4_R1.scheduler.CraftTask.run(CraftTask.java
:53)
at org.bukkit.craftbukkit.v1_4_R1.scheduler.CraftAsyncTask.run(CraftAsyn
cTask.java:53)
... 3 more

 

What is line 29 of the SgWall class? What code are you using to update the sign ever few seconds?

 

Code:java

 
BukkitTask task = getServer().getScheduler().runTaskTimerAsynchronously(this , new Runnable() {
@Override
public void run() {
SignUpdater updater = new SignUpdater(null);
updater.item();
}
}, 60L, 200L);
 
}
 
 

its updater.item();

dont get me wrong - this is my first plugin, and im very new in java, so i have no idea if im doing things right.

idea of what i want to do is:

run task every 10s {

loop // for every key of config do code {

get location of sign x and sign y, and then copy contents from x to y

}

}

idk if this is best way to achieve my plan, but i dont know how to acces another plugin's classes, and directly "steal" data used to create signs...

 

You are probably getting an NPE because you passed null into it...

To do something for every key in the Group key:

Code:

Group:
  key1: 34
  key2: 56
  Key3: 37

Code:java

for(String key:getConfig().getConfigurationSection("Group").getKeys(false)) {
    int value = getConfig().getInt("Group."+key);
    //Do stuff here
}

 

Code:java

 
 
public void item() {
 
Bukkit.broadcastMessage(ChatColor.GOLD+" test message");
 
 
// Location loc;
// loc = new Location(Bukkit.getServer().getWorld(plugin.getConfig().getString("signs.id1.location.world")),
// plugin.getConfig().getInt("signs.id1.location.x"),
// plugin.getConfig().getInt("signs.id1.location.y"),
// plugin.getConfig().getInt("signs.id1.location.z"));
// Block b = loc.getWorld().getBlockAt(loc);
// Sign s = (Sign) b;
// s.setLine(1, "test");
}
 

not sure about NPE but this code works and is executed every 10 seconds, so i think, that there is something terrible wrong in public void item() method.. just no idea what :/

 

item() is a method, not a class...

 

yeah, i just realized my mistake right before You posted

i experimented some more, and i got to this point

Code:java

 
public void item() {
 
Bukkit.broadcastMessage(ChatColor.GOLD+" test message");
 
String x = plugin.getConfig().getString("signs.id1.location.world"); // line 28
 
plugin.getServer().broadcastMessage("world name from sign id1 is: "+x);
 
}
 

when calling item() from main, test message is sent, but next line throws error, Help needed

running this code directly from onEnable - still same error, on line 28

Code:java

 
SignUpdater updater = new SignUpdater(null);
updater.item();
 

edit: i got it! it was as simple as putting SignUpdater updater = new SignUpdater(null); in on load with final type, and then calling updater.item() from thread - hope it wont cause me more problems

thanks for Your assistance!