[ECON] CommandShops v4.2.0 - The premier local shop plugin. [1.5.2]

Discussion in 'Archived: Plugin Releases' started by zolcos, Sep 30, 2011.

  1. Offline

    Saxburger

    I got a link a few hours ago of zolcos in IRC for a dev version. I don't know if he wants the link listed here, so I wont. He said that a release version will most likely be coming within the next day or two.

    Thankyou Zolcos!

    Installs and works nicely. Gives many lines of warnings when server starts however. Occasionally get kicked with "internal server error" within 10-15 seconds of setting a price. Will test more. (talking about R2)

    Updated spout to latest dev version. No longer gives warnings on startup, but keeps kicking people for "internal server errors" with annoying frequency.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 20, 2016
  2. Offline

    axebyte

    Spout far as i know isnt on 1.2.3. and the older version itself will cause , move too quickly errors and kick people at random. Didnt know Spout was a requirement for this..
    Can i get a link to this dev build to try on a non spout server..
     
  3. Offline

    zolcos

    This plugin does not use Spout.
    If you experience errors take a look in your log and make sure the errors are actually coming from CS and not something else, and preferably give it a try without any plugins that aren't needed for CS to work
     
  4. Offline

    axebyte

    any chance i can get a dev build or something for this?
    I didnt think it was spout required, why i was sorta thrown off by the last guy complaining about spout even though it wasnt even updated yet.

    Got ahold of the build, and so far it runs perfectly.
    Only issue i had was having to redo the 30+ shops due to the auto adding of sell at .1 from shops that where only for buying.

    But no errors, the DB works fine, and have had no issues on it at all yet.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 20, 2016
  5. Offline

    zolcos

    The 0.01 issue was like that in the previous couple versions as well. That'll only happen when loading from old shop files. Once you're running off the database, your 0 and null prices will be kept correctly :)

    Btw my testing is done and if there are no issues reported by the folks in IRC today then I'll promote R3 to stable.

    OK, I've updated the first post for the release of 4.0.0.

    Thanks to everyone who has either donated or promised to donate upon this release.

    I must stress a few points here:
    As far as just getting it to work, this is a drop-in upgrade (aside from the dependency change from Register to Vault). By default, it will create a SQLite file that will contain all your shops from now on. You can tell it to use MySQL instead. Either way, your old shopfiles will be read in when the plugin loads and dumped into the database. They will not be written to again; any changes to the shops will only be saved to the database. I suggest you backup your old shopfiles and get them out of the plugin data folder. The plugin will try not to load shopfiles for shops that are already in the database, but it checks by name, so if a shop name changes or if shops are destroyed later you will start getting duplicates if the old shop files are still there.

    There is now a difference between a price of 0, and no price. 0 = Free. To stop buying or selling an item, use the price setting command with no number after it. The price should then show up as "--".

    Yes, shop enter/exit messages are gone, this is not a bug, and they will stay gone until I find a way to inject these messages into a plugin better suited to handle these sorts of things such as worldguard or towny.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 20, 2016
  6. Offline

    axebyte

    shame bundles had to be removed. Are they planned to return later?
     
  7. Offline

    zolcos

    No.
    Worst case scenario: if you were using bundles to price things at 1/64 of a cent then you may need to inflate your currency a little to rebalance prices but there should be no other big issues migrating from a system using bundles.
    I definitely ask for feedback here before removing or changing features like that, though, so stay active and you may be able to influence development to meet your needs :)
     
  8. Offline

    OstlerDev

    Just donated all the money in my PayPal ;) hope it helps
     
  9. Offline

    zolcos

    What do you guys think about removing the default dimensions for shops, thereby forcing the user to make a selection?
    The default size generally just leads to people making shops that don't line up with the physical building they built for it.
    Also, worldguard integration could include using the worldedit selection commands, any reason why it would be worse than the current custom selection mechanism?
     
  10. Offline

    OstlerDev

    Yes!!! Plus if you did this you could also have it auto create a worldGuard region for the enter/leave message
     
  11. Offline

    axebyte

    Both sound good to me personally, We always use the /shop select command mostly for the reason you said. and clipping into WG with working greetings would be awesome.
     
  12. Offline

    thelanoyo

    Ok im getting a weird error in the console, here what it says:

    Could not pass event PlayerInteractionEvent with ChestShop

    And chest shop will not work and I really need it!
     
  13. Offline

    axebyte

    Think you got the wrong forum section, this is Commandshop not Chestshop. But sounds like its not updated. (prior updates alot of plugins have the palyerinteraction event, cause Bukkit removed it and used another one,
     
  14. Offline

    Mozartripper

    the mysql storage makes everything so much easier man thx!
    one question would it be possible to have only one item/price list for all the shops (we have 4worlds on my server and all of them have at least one shop in it would make prices changes so much easier if all shops could share the same price list).
     
  15. Offline

    mrto

    DO YOU HAVE TO BUY WITH MONEY???
     
  16. Offline

    zolcos

    It sounds like you're asking for the ability to give one shop multiple locations. It also sounds like you're trying to make a global shop across the whole server. Am I right?
    what
     
  17. Offline

    griffenx

    I installed the plugin and it worked fine for about a day, but then I got back on the server the next day and now basically nothing works. Whenever I try to access a store, I get this error in-game: Browse cancelled due to DB error. and this error message in the console: [WARNING] [CommandShops] Couldn't get shop info list: java.lang.IndexOutOfBoundsException: Index: 1, Size: 0
    Any idea what I did wrong?
     
  18. Offline

    zolcos

    Assuming you're using sqlite, please send me your database file. Are you getting errors on any other commands?
     
  19. Offline

    griffenx

    the it allows me to list the shops, select and create a shop, add and remove items from a shop, but when I try to set the sell or buy price it says "An internal error occurred while attempting to perform this command."
    I could probably just delete my database file and redo the shops (there were only a small handful), but I'm not sure what went wrong and it might just happen again and I'd be back at square one.
    Also, how would you like me to send the database file?
     
  20. Offline

    zolcos

    You must get some other errors in the log when you see the "internal error" message ingame. Something about exceptions?
    Post your full server.log with code tags (or use pastebin if it's really large) and you can send the database via any file locker site
     
  21. Offline

    griffenx

    when it shows the internal error, this is what comes up in the log:
    <font color="#000000">[SEVERE] null</font>
    <font color="#000000">org.bukkit.command.CommandException: Unhandled exception executing command 'shop' in plugin CommandShops v4.0.0</font>
    <font color="#000000">at org.bukkit.command.PluginCommand.execute(PluginCommand.java:42)</font>
    <font color="#000000">at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:166)</font>
    <font color="#000000">at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:469)</font>
    <font color="#000000">at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.java:906)</font>
    <font color="#000000">at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:866)</font>
    <font color="#000000">at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:849)</font>
    <font color="#000000">at net.minecraft.server.Packet3Chat.handle(Packet3Chat.java:33)</font>
    <font color="#000000">at net.minecraft.server.NetworkManager.b(NetworkManager.java:229)</font>
    <font color="#000000">at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:116)</font>
    <font color="#000000">at net.minecraft.server.NetworkListenThread.a(NetworkListenThread.java:78)</font>
    <font color="#000000">at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:554)</font>
    <font color="#000000">at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:452)</font>
    <font color="#000000">at net.minecraft.server.ThreadServerApplication.run(SourceFile:490)</font>
    <font color="#000000">Caused by: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0</font>
    <font color="#000000">at java.util.ArrayList.RangeCheck(ArrayList.java:547)</font>
    <font color="#000000">at java.util.ArrayList.get(ArrayList.java:322)</font>
    <font color="#000000">at com.iCo6.util.Common.formatted(Common.java:125)</font>
    <font color="#000000">at com.iCo6.iConomy.format(iConomy.java:504)</font>
    <font color="#000000">at net.milkbowl.vault.economy.plugins.Economy_iConomy6.format(Economy_iConomy6.java:108)</font>
    <font color="#000000">at com.aehdev.commandshops.commands.CommandShopSet.shopSetSell(CommandShopSet.java:474)</font>
    <font color="#000000">at com.aehdev.commandshops.commands.CommandShopSet.shopSetSell(CommandShopSet.java:370)</font>
    <font color="#000000">at com.aehdev.commandshops.commands.CommandShopSet.process(CommandShopSet.java:83)</font>
    <font color="#000000">at com.aehdev.commandshops.commands.ShopCommandExecutor.onCommand(ShopCommandExecutor.java:119)</font>
    <font color="#000000">at org.bukkit.command.PluginCommand.execute(PluginCommand.java:40)</font>

    <font color="#000000">I'm pretty sure there's more, but the hosting service I use truncates really long error messages, and for some reason it also doesn't allow access to the log file.</font>
    <font color="#000000">and the database file is here: <Edit by Moderator: Redacted mediafire url>
    <font color="#ffffff"></font>
     
    Last edited by a moderator: Nov 12, 2016
  22. Offline

    zolcos

    [quote uid=90656198 name="griffenx" post=1032269]when it shows the internal error, this is what comes up in the log:
    <font color="#000000">[SEVERE] null</font>
    <font color="#000000">org.bukkit.command.CommandException: Unhandled exception executing command 'shop' in plugin CommandShops v4.0.0</font>
    <font color="#000000">at org.bukkit.command.PluginCommand.execute(PluginCommand.java:42)</font>
    <font color="#000000">at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:166)</font>
    <font color="#000000">at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:469)</font>
    <font color="#000000">at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.java:906)</font>
    <font color="#000000">at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:866)</font>
    <font color="#000000">at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:849)</font>
    <font color="#000000">at net.minecraft.server.Packet3Chat.handle(Packet3Chat.java:33)</font>
    <font color="#000000">at net.minecraft.server.NetworkManager.b(NetworkManager.java:229)</font>
    <font color="#000000">at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:116)</font>
    <font color="#000000">at net.minecraft.server.NetworkListenThread.a(NetworkListenThread.java:78)</font>
    <font color="#000000">at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:554)</font>
    <font color="#000000">at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:452)</font>
    <font color="#000000">at net.minecraft.server.ThreadServerApplication.run(SourceFile:490)</font>
    <font color="#000000">Caused by: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0</font>
    <font color="#000000">at java.util.ArrayList.RangeCheck(ArrayList.java:547)</font>
    <font color="#000000">at java.util.ArrayList.get(ArrayList.java:322)</font>
    <font color="#000000">at com.iCo6.util.Common.formatted(Common.java:125)</font>
    <font color="#000000">at com.iCo6.iConomy.format(iConomy.java:504)</font>
    <font color="#000000">at net.milkbowl.vault.economy.plugins.Economy_iConomy6.format(Economy_iConomy6.java:108)</font>
    <font color="#000000">at com.aehdev.commandshops.commands.CommandShopSet.shopSetSell(CommandShopSet.java:474)</font>
    <font color="#000000">at com.aehdev.commandshops.commands.CommandShopSet.shopSetSell(CommandShopSet.java:370)</font>
    <font color="#000000">at com.aehdev.commandshops.commands.CommandShopSet.process(CommandShopSet.java:83)</font>
    <font color="#000000">at com.aehdev.commandshops.commands.ShopCommandExecutor.onCommand(ShopCommandExecutor.java:119)</font>
    <font color="#000000">at org.bukkit.command.PluginCommand.execute(PluginCommand.java:40)</font>

    <font color="#000000">I'm pretty sure there's more, but the hosting service I use truncates really long error messages, and for some reason it also doesn't allow access to the log file.</font>
    <font color="#000000">and the database file is here: <Edit by Moderator: Redacted mediafire url>
    [/quote]
    That makes it look like iconomy's fault. Try updating iCo or using a different econ plugin with the same shop database and see if you still get that error.
     
    Last edited by a moderator: Nov 12, 2016
  23. Offline

    Mozartripper

    yes and no/ I don't want a global shop I want to make multiple shops but that they can all share the same price/item list so when I change a price for one shop it reflect on all of them. would make things more simple than changing the price in 5-6 separate shops.

    database layout could look like this.
    id name owner creator x y z x2 y2 z2 world minbalance unlimitedMoney unlimitedStocknotify service_repair service_disenchant Items ID
    itemsid would be the items list this shop should use in the shop_items table.
     
  24. Offline

    KollegahDerBoss

    Screenshots...please? :D
     
  25. Offline

    Bluehog

    I got a bug for ya. Latest build, downloaded it yesterday

    When using /shop set sell <item> to stop selling an item it messes up with ID with damage values.

    /shop set sell 35 & /shop set sell 35:0 Both stop White Wool from being sold.
    However
    /shop set sell 35:1 does not stop Orange Wool, it instead stops White Wool again.

    Same thing for all IDs with damage values (Pistons, wool dyes, slabs, etc)

    For reference though, /shop buy 35:2 still works properly. And I haven't tested /shop set buy <item>

    EDIT: After a little more testing

    /shop set sell <item> <price> with a damage value on the id acts like you set no price (remove the item and sets damage value to 0)

    Also adding stuff like /shop set sell Jungle Sapling 20 will set normal (oak) saplings to 20, not adding Jungle Sapling. (Jungle Saplings being ID 6:3)
     
  26. Offline

    zolcos

    That makes little sense but I understand what you're asking for now and given that it does sound like a useful feature I will add it if there gets to be more demand. As it stands, though, it would be somewhat difficult and not much payoff for most users

    This plugin is just a bunch of commands and doesn't really make for exciting screenshots. Unless, that is, you want to see some epic shops people have built to go along with the plugin... I think I can find some of those

    Good catch, the regex parsing was falling into the wrong case there. The bug seems to have only affected set buy/sell.
    The issue with Jungle Leaves was a special screwup in the item search for that one item :O
    Will push a fix soon. Tested release will come with the update for the latest batch of new items.
     
  27. Offline

    Bluehog

    Welcome. And just found another one. It doesn't recognize the new Stone Brick (98:3)
     
  28. Offline

    Tathar

    Does this plugin work with client mods' new blocks and items? I'd like to recommend this plugin for a Tekkit server, but I need to know it's compatible with everything in the mod pack first.
     
  29. Offline

    zolcos

    I haven't added any items that new yet. Patience...

    Not a chance. Although, I am open to the idea of an extensions/override system so that mod authors could make their own item lists to dump into CommandShops. Might take a while, though, since I've never dealt with custom blocks before
     
  30. Offline

    danielcwr

    OK, I have bpermissions and vault. I have given default rank commandshops.user.* but when I set my rank to default AND deop me I type /shop but it still gives me all the commands like create shop etc... How do i fix this?
    please email me at [email protected] if you have a solution! (BTW, i'm running craftbukkit 1.2.4-R0.1)
     

Share This Page