Easy kill reward code (Need help)!

I do know a little about this like

Code:java

@EventHandler
player.deathEvent get.killer

And that you have to check if it is a player and stuff like that (the code is invalid, i know that) i want it to give a player £50 for killing + Sending the killer a message + playing a tone/sound to the killer.

Remember, i dont ask if someone can code the plugin for me, i just want to know how, because it will be merged into an another plugin i am making.

So i just need a little code to start with or something like that, so if you know how to do this, please post an answer!

Thanks.

Tags: sgavster L33m4n123 SkillSam

 

Code:java

@EventHandler
public void onDeath(PlayerDeathEvent e) {
Player p = e.getEntity();
if(p.getKiller() instanceof Player) {
Player d = p.getKiller();
//do stuff with d
}
}

 

sgavster

Thanks man, i will have a go at it

 

You'll want to check if the killer is null otherwise you'll get an NPE every time someone commits suicide. Also check if it's a player

 

sgavster

Ok i have it working, but sometimes the console prints out some nasty errors
It does not affect the plugin, and it sill works but i would like to fix the errors before moving on with the plugin.

Source code:

Code:java

package me.FirecatHD.TBS_PvP;
 
import org.bukkit.ChatColor;
import org.bukkit.Sound;
import org.bukkit.entity.LivingEntity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDeathEvent;
 
public class DeathListener implements Listener {
 
@EventHandler
public void onDeath(EntityDeathEvent e) {
LivingEntity p = e.getEntity();
//if(p.getKiller() instanceof Player) {
Player d = p.getKiller();
{
d.playSound(p.getKiller().getLocation(), Sound.EXPLODE, 5, 1);
d.sendMessage(ChatColor.BLACK + "[" + ChatColor.DARK_RED + "TBS PvP" + ChatColor.BLACK + "]: " + ChatColor.GREEN + "You " + ChatColor.RED + "killed " + ChatColor.GREEN + "a Player!");
}
}
}
 

And yes, i have registrered the event in the main class.
So could the problem be what drtshock said, or something else?

If someone can help me, please do it!

Thanks.

 

you have to check if p.getKiller is instanceof Player as you commented out. Because if a Skelleton kills someone it gets an error there

 

L33m4n123

Yes i have modified the code a little for debugging so therefor i commented it out, but i think i know the error so i am gonna try what i can imagine it is.

Il report as soon as i find something out

Ok it works thanks everyone!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Why did you comment out if the player is a killer, thats why you got errors..

 

sgavster

It was because iwas testing the code on entitys instead of players, but it works now.

-----------------------------------------------------------------------------------------------------------------------

But here is my next question: I want to play a exploding RED firework on the deathEvent (You know at Quake you kill a player an the player explodes) thats how i want it.

Here is my code:

Code:java

package me.FirecatHD.TBS_PvP;
 
import org.bukkit.ChatColor;
import org.bukkit.Sound;
import org.bukkit.entity.LivingEntity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDeathEvent;
 
public class DeathListener implements Listener {
 
@EventHandler
public void onDeath(PlayerDeathEvent e) {
LivingEntity p = e.getEntity();
if(p.getKiller() instanceof Player) {
Player d = p.getKiller();
{
d.playSound(p.getKiller().getLocation(), Sound.EXPLODE, 5, 1);
d.sendMessage(ChatColor.BLACK + "[" + ChatColor.DARK_RED + "TBS PvP" + ChatColor.BLACK + "]: " + ChatColor.GREEN + "You " + ChatColor.RED + "killed " + ChatColor.GREEN + "a Player!");
}
 
}
}
}

So i hope someone can help me and thanks in advance!

Tags: L33m4n123 SkillSam

 

FirecatHD do this

Code:java

package me.FirecatHD.TBS_PvP;
 
import org.bukkit.ChatColor;
import org.bukkit.Sound;
import org.bukkit.entity.LivingEntity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDeathEvent;
 
public class DeathListener implements Listener {
 
@EventHandler
public void onDeath(PlayerDeathEvent e) {
LivingEntity p = e.getEntity();
if(p.getKiller() instanceof Player) {
Player d = p.getKiller();
{
d.playSound(p.getKiller().getLocation(), Sound.EXPLODE, 5, 1);
d.sendMessage(ChatColor.BLACK + "[" + ChatColor.DARK_RED + "TBS PvP" + ChatColor.BLACK + "]: " + ChatColor.GREEN + "You " + ChatColor.RED + "killed " + ChatColor.GREEN + "a Player!");
            Firework fw = (Firework) p.getWorld().spawn(p.getLocation(), Firework.class);
            FireworkEffect effect = FireworkEffect.builder().trail(true).flicker(true).withColor(Color.RED).with(Type.BURST).build();
            FireworkMeta fwm = fw.getFireworkMeta();
            fwm.clearEffects();
            fwm.addEffect(effect);
            Field f;
            try {
                    f = fwm.getClass().getDeclaredField("power");
                    f.setAccessible(true);
                    f.set(fwm, -2);
            } catch (NoSuchFieldException e) {
                    // TODO Auto-generated catch block
                    e.printStackTrace();
            } catch (SecurityException e) {
                    // TODO Auto-generated catch block
                    e.printStackTrace();
            } catch (IllegalArgumentException e) {
                    // TODO Auto-generated catch block
                    e.printStackTrace();
            } catch (IllegalAccessException e) {
                    // TODO Auto-generated catch block
                    e.printStackTrace();
            }
}
 
}
}
}

it should work

 

superjesse07

Hmm it fires of a firework, but it does not explode
Also i want it to explode right away, dont shoot up in the air first.

Anyways thanks for the help, and if you know how to solve this i would be very grateful

 

Did you really just spoonfeed a new coder reflection? facepalm

Also, why the reflection? Does setting the power to 0 not work?

 

garrison no it doesn't work it shoots it up in the air but FirecatHD for me its working fine whats the error or do you not get a error

 

superjesse07 and@Garris0n

Nope i dont get any errors, but i think this is a bit advanced for me right now (I have only been coding for 4 days...)
So i found out i could use a lightning strike instead, so i will use that until i learn this

Anyways, thanks to you both for helping!

 

no problem