Do not teleport players into a block.

Hello developers,

I've created a plugin: Scroll Teleportation.
It allows you to teleport to a set destination with a 'scroll'. (Piece of paper)

I have implemented methods that check if you will be teleported into a wall, and if you will, it will get a new location that is safe.

See this snippet:

Code:java

private Location secureLocation(Location oldLocation, Player player) {
        World world = oldLocation.getWorld();
        int x = oldLocation.getBlockX(),y = oldLocation.getBlockY(), z = oldLocation.getBlockZ();
 
        // Block for feet
        Block blockOnY = world.getBlockAt(x, y, z);
        // Block for head
        Block blockOnY2 = world.getBlockAt(x, (y + 1), z);
        // Block below feet
        Block blockOnY3 = world.getBlockAt(x, (y - 1), z);
 
 
        Location safeLocation = null;
        // Player would suffocate or fall down
        if (!blockOnY.getType().equals(Material.AIR) || !blockOnY2.getType().equals(Material.AIR) || blockOnY3.getType().equals(Material.AIR)) {
           // Determine a new safer place to teleport to.
            int safeY = oldLocation.getWorld().getHighestBlockYAt(x, z);
            safeLocation = new Location(world, x, safeY, z);
        } else {
            safeLocation = oldLocation;
        }
        return safeLocation;
    }

However, some users report that it's still not working. They've said that players still get teleported into blocks.

Does anybody know why?

 

I will make an API for this right now.

 

Staartvin
I usually don't use getBlockAt(), I construct a new location and getBlock() on it

 

Why exactly?

Thanks.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Staartvin
Personal preference

 

http://forums.bukkit.org/threads/random-teleportation-not-in-block-api.169118/#post-1814236

 

Well, this is basically what I have made already. That snippet I showed is a method that checks whether a location is a block or not.

 

Oh. I didn't even read your code. You posted in the wrong section. I thought you needed help with something.

 

Oh, sorry. What section should I post it in then?

 

I just posted in the resources section, since an API to help people would be a nice resource. http://forums.bukkit.org/forums/resources.60/