Detect when a player's health changes [SOLVED]

How would I go about detecting when a player's health changes? I know about EntityRegainHealth Event and EntityDamage Event, but I need to know about ALL changes in health, mainly from other plugins that use "player.setHealth();"

 

Simply put, you can't.

 

Not at all? Can't you do something like, every frame, it gets the health of the player, and if the health changes from one frame to the next, something happens? I'm not quite sure how do that though, which is why I posted this thread.

 

Well, I suppose you could do that. You'd just schedule a repeating task that scans through all the players.

http://wiki.bukkit.org/Scheduler_Programming

 

I tried making a repeatable task to do it, using this code in OnEnable()

Code:

            public void run() {
                Player[] playersInWorld = getServer().getOnlinePlayers();
                for (int i = 0; i == playersInWorld.length; i++) {
                    try {
                    Player player = playersInWorld[i];
                    int health = player.getHealth();
                    message("The health of "+player.getDisplayName()+"is "+Integer.toString(health));
                    message("If there is no above statement of a players health, something is broken.");
                    }
                    catch(ArrayIndexOutOfBoundsException e){
                        message("Nobody's online D:");
                    }
                }
 
            }
        }, 0L, 20L);

When there are no players online, "Nobody's online D:" get's spammed repeatedly, as it should. However, when someone's online, nothing happens at all.

 

You could do that without the massive overhead of a try-catch, by the way.

Code:java

 
Player[] playersInWorld = getServer().getOnlinePlayers();
for(Player player : playersInWorld)
{
     int health = player.getHealth();
     message("Player " + player.getName() + " has health " + health);
}
 

Also, while writing that, I noticed that your For loop was setup incorrectly, namely the loop condition.

Code:java

 
for (int i = 0; i == playersInWorld.length; i++) {
 

Should be:

Code:java

 
for(int i = 0; i < playersInWorld.length; i++) {
 

I feel that if you try EITHER of the above, it should start working.

 

Ah ok, it works now. Thanks!
However, now I have a new problem. I'm trying to use hash-maps to store the data of each persons health, but every time I run the below code, I get a nullpointerexception. It's in the for loop.

Code:

                    Map<String, Integer> Health = new HashMap<String, Integer>();
                    int health = player.getHealth();
                    try {
                    int preHealth = Health.get(name).intValue();
                    }
                    catch(NullPointerException e) {
                        message("The fuck is going on?");
                    }

The same happens if I use the Player class, in place of a String, as the key.

 

That's because HashMaps like to return null when it lacks a value for an inputted key.

Also, is that entire thing inside the For loop? If so, move the HashMap into plugin context (define it outside any members), else it will ALWAYS be empty, since it's being created each iteration.

Try this one instead (inside the for loop):

Code:java

 
int curHealth = player.getHealth();
int oldHealth = curHealth; //Default value
if(Health.get(player) != null)
{
     oldHealth = Health.get(player);
}
 

EDIT: Dangit Bukkit forum, stop trimming spaces/tabs inside code blocks!

 

Thanks again, that worked perfectly.

Everything's working fine now, thanks for the help.