Solved Custom Sword not working.

Im having some trouble with this sword, Ive got no errors, I can create it in the game, but when I hit another player it does absolutely nothing. If anyone could help me figure out whats wrong with it I would be grateful. Ive tried even just setting the sword to light people on fire but still does nothing when I hit someone.

Code:java

import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class Thunderbolt implements Listener {
 
    public void ThunderBolt(EntityDamageByEntityEvent event)
      {
          if(!(event.getDamager().getType() == EntityType.PLAYER))
          {
              return;
          }
        Player damager = (Player)event.getDamager();
        Player target = (Player)event.getEntity();
        if(event.getDamager() instanceof Player) {
            if(target instanceof Player) {
                damager.getItemInHand().getItemMeta().getDisplayName();
                damager.getItemInHand().getType();
                if(damager.getItemInHand().getType() == Material.GOLD_SWORD) {
                    if(damager.getItemInHand().getItemMeta().getDisplayName() == ChatColor.GOLD +"Thunderbolt"){
                        double Strike = Math.round(Math.random()*4);
                        if(Strike == 3){
                            target.getWorld().strikeLightningEffect(target.getLocation());
                            target.addPotionEffect(new PotionEffect(PotionEffectType.HARM, 1, 1/3));                           
                        }
                    }
                }
            }
        }
      }
}

 

First of all you can't get Strike to be 3 and it should be in lowercase(the first letter at least).
Why you can't get it to be 3 you may ask? Well, cause of the *4. If it become 1, its 4. If it becomes 0, its 0. If it becomes 100 its 400..So good luck

 

stoneminer02
Please research before you say something. Math.random returns a value between 0 and 1, so Strike can be 4 at most.

Worthless_Hobo
You are comparing strings using ==. Use equals instead.

Code:

getDisplayName().equals(ChatColor.GOLD+"Thunderbolt")

 

Worthless_Hobo

• Missing EventHandler annotation
• Not sure if you registered the event
• Unchecked event.getEntity() -> Player cast
• Possible NullPointerException when player.getItemInHand() is null
• Possible NullPointerException when player.getItemInHand() is an AIR stack (getItemMeta() returns null for AIR stacks)
• Possible NullPointerException when the held item has no displayname
• String comparison issue mentioned above
• Use Random#nextInt(int n) for random ints, just for your convenience.

 

molenzwiebel and fireblast709
Ok thanks for the help guys Ive also got one other problem that I havent been able to figure out, I have a bow that fires arrows about about 4 per second, however if their are arrows in the inventory it does the drawback event on the bow, but I dont want it to have a drawback, just to fire the arrows like a machine gun. Is there some way to cancel the drawback or stop it from happening?

 

Worthless_Hobo Listen to the PlayerInteractEvent. Loop over the inventory contents, get the first arrow, take one of that arrow out of the inventory and shoot a projectile.

 

Ok thanks for your help!