Custom Inventory Won't Open

I've tried really hard to find a solution to my problem, but I couldn't find one anywhere. I'm trying to make it so that when you click a merchant, they open up a custom inventory with 54 slots instead of the default inventory. I registered all my events properly, since the other events are working. It's also my first time posting on the Bukkit Forums, so I'm sorry if I posted it on the wrong thread. Here's part of my code:

Declaring variables:

Code:

public class EventListener implements Listener {
    private Inventory pricesInventory;
    private Inventory productsInventory;
    private String testMerchantName = ChatColor.LIGHT_PURPLE + "Test Merchant";

PlayerInteractEntityEvent:

Code:

@EventHandler(priority = EventPriority.NORMAL)
    public void onInteract(PlayerInteractEntityEvent event) {
        if (event.getRightClicked() instanceof Villager) {
            event.setCancelled(true);
            if (Merchant.isMerchant((Villager) event.getRightClicked())) {
                Merchant merchant = Merchant.merchants.get((Villager) event
                        .getRightClicked());
                Player player = event.getPlayer();
                if (Merchant.getIdentifier(merchant).equals(
                        "spawnCity_testMerchant")) {
                    pricesInventory = Bukkit.createInventory(null, 54);
                    productsInventory = Bukkit.createInventory(null, 54, testMerchantName);
                    pricesInventory.setItem(0, new ItemStack(Material.EMERALD,
                            3));
                    productsInventory.setItem(0, new ItemStack(
                            Material.DIAMOND_AXE, 1));
                    player.openInventory(productsInventory);
                    event.setCancelled(true);
                }
            }
        }
    }

Oh and BTW, I know the code is being reached since I can send the player a message right before or after I try to open the inventory.

 

Why create the inventory? Just make a custom one outside of the event and use it? could make your code look a lot neater and help you find the problem.

 

@Simon76800, did you register the listener in the main class?

 

@Simon76800

Try printing out the Merchant's identifier and seeing if it's set correctly and you should add a way to check if the Merchant is null so you don't get a NullPointerException.

 

Yeah... since the other events are working

I've added a way to check if a merchant is null, and the identifier of the merchant is set correctly... but it still doesn't work

I moved my inventories outside the event, and the inventory still won't open. I also tried making the inventories static... but it didn't do anything.

Code:

public class EventListener implements Listener {
    private Inventory pricesInventory;
    private Inventory productsInventory;
    private String testMerchantName = ChatColor.LIGHT_PURPLE + "Test Merchant";

    {
        pricesInventory = Bukkit.createInventory(null, 54);
        productsInventory = Bukkit.createInventory(null, 54, testMerchantName);
        pricesInventory.setItem(0, new ItemStack(Material.EMERALD, 3));
        productsInventory.setItem(0, new ItemStack(Material.DIAMOND_AXE, 1));
    }

 

inventory.setItem() should be inventory.addItem()
Use my class as a reference (this is my plugin CommandsForSale)
https://github.com/Ethan160503/CommandsForSale/blob/master/src/me/Tecno_Wizard/CommandsForSale/GUI/GUIConstructor.java

I haven't pushed to this recently so there are some problems, i know.

 

@Tecno_Wizard Set item will work but he has too make sure he does different slots, not all the same like he did.

 

I didn't put two items in the same inventory... I put them in the same slot of different inventories

 

@VG.Developments @Simon76800, I know, but I don't see anything else that could cause it.

EDIT: wait, is pos 0 nonexistant? Try 1, things aren't always 0 oriented.
EDIT2: Yes, pos 0 does not exist. I'm surprised that it doesn't throw an illegal argument exception.

 

?

 

@Simon76800
there is no position 0
pricesInventory.setItem(0, new ItemStack(Material.EMERALD, 3));

 

I thought there was a 0 for setItem, but I changed it to addItem... and it still doesn't work

Should I just rewrite the plugin but copy paste a few things?

 

@Simon76800, no, that won't get you anywhere.
add a sysout to that code with gibberish in it and see if the code is even running first.

 

I tried doing player.sendMessage() and I saw it on the screen so the code is running

 

@Simon76800, now sysout the inventory itself and make sure it isn't null. if it isn't, you'll see a class summary. if it is, you'll see null.

 

Uh... how do I exactly do that?

 

@Simon76800, System.out.println(inventory);
if that's true, loop through every inv slot with this again.

 

It returned org.bukkit.craftbukkit.v1_7_R4.inventory.CraftInventoryCustom@245f0656

 

@Simon76800, so the inventory exists correctly. Get each slot of the inventory and sysout it. you should see a different result this time I believe.

 

I tried it, and the first slot (which is the only one I set) is one diamond axe, and the rest is null

 

@Simon76800, so then what should you look at as the culprit? (I'm trying to teach you how to debug btw, and I have known what has been causing it for almost 5 posts now (Well, I think) )

 

lol... honestly i think it has something to do with openInventory()

 

@Simon76800, so canceling the event doesn't have an effect?
If removing that doesn't fix it, tell me and I'll continue assisting tomorrow. I have some sleeping to do.

 

I tried not cancelling it, but then the default villager inventory shows up

 

@Simon76800 Almost forgot about that. Create a schedueler to open it a tick later.
http://wiki.bukkit.org/Scheduler_Programming

 

@Tecno_Wizard 0 does exist, it's the first slot in the inventory. Remember the numbers start with 0, 1, 2, not 1, 2 etc....

 

@VG.Developments, idk, regardless it wasn't the problem.

 

Uh... how do I do that?

nvm I got it

 

Code:

new BukkitRunnable(){

   public void run(){
      //do stuff
   }
}.runTaskLater(plugin, 1);

 

thx