Solved Custom Entity Despawns Immediately After Spawning

So I have this abstract Entity class that extends EntityCreature (in order to achieve in the simplest form, controlled navigation), as below...

Show Spoiler Hide Spoiler

Code:java

 
 
package me.dsh105.echopet.entity.pet;
//relevant imports
import net.minecraft.server.v1_5_R3.EntityCreature;
import net.minecraft.server.v1_5_R3.EntityHuman;
import net.minecraft.server.v1_5_R3.EntityLiving;
import net.minecraft.server.v1_5_R3.IMonster;
import net.minecraft.server.v1_5_R3.Navigation;
import net.minecraft.server.v1_5_R3.Packet63WorldParticles;
import net.minecraft.server.v1_5_R3.World;
 
public abstract class EntityPet extends EntityCreature implements IMonster {
 
public EntityLiving goalTarget = null;
protected Pet pet;
 
public PetGoalSelector petGoalSelector;
public Navigation nav;
 
public EntityPet(World world, Pet pet) {
super(world);
try {
pet.setCraftPet(pet.getPetType().getNewCraftInstance(this));
 
setPet(pet);
 
this.petGoalSelector = new PetGoalSelector();
 
nav = this.getNavigation();
 
if (EchoPet.getPluginInstance().DO.flyTeleport()) {
petGoalSelector.addGoal("Fly", new PetGoalFly(this));
}
petGoalSelector.addGoal("Ride", new PetGoalPassenger(this, 0.25F));
petGoalSelector.addGoal("Float", new PetGoalFloat(this));
petGoalSelector.addGoal("FollowOwner", new PetGoalFollowOwner(this, EchoPet.getPluginInstance().DO.getStartWalkDistance(), EchoPet.getPluginInstance().DO.getStopWalkDistance(), EchoPet.getPluginInstance().DO.getTeleportDistance()));
petGoalSelector.addGoal("LookAtPlayer", new PetGoalLookAtPlayer(this, EntityHuman.class, 8.0F));
petGoalSelector.addGoal("RandomLookAround", new PetGoalRandomLookaround(this));
petGoalSelector.addGoal("RandomStroll", new PetGoalRandomStroll(this));
 
} catch (Exception e) {
EchoPet.getPluginInstance().severe(e, "Error creating new pet entity.");
}
}
 
public void setPet(Pet pet) {
if (pet != null) {
this.pet = pet;
}
}
 
public Pet getPet() {
return this.pet;
}
 
public Player getOwner() {
return pet.getOwner();
}
 
public Location getLocation() {
return new Location(this.pet.getOwner().getWorld(), this.locX, this.locY, this.locZ);
}
 
@Override
public int getMaxHealth() {
return this.maxHealth;
}
 
@Override
public CraftEntity getBukkitEntity() {
if (this.bukkitEntity == null) {
this.bukkitEntity = new CraftPet(this.world.getServer(), this);
}
return this.bukkitEntity;
}
 
public boolean bh() {return true;}
 
protected abstract String bb();
 
// Overriden from EntityLiving - Most importantly overrides pathfinding selectors
@Override
protected void bo() {
++this.bC;
//this.world.methodProfiler.a("checkDespawn");
//this.bn();
//this.world.methodProfiler.b();
 
//this.world.methodProfiler.a("sensing");
this.getEntitySenses().a(); // Gets the field 'bP', as in EntityLiving class
//this.world.methodProfiler.b();
 
//this.world.methodProfiler.a("targetSelector");
//this.targetSelector.a();
//this.world.methodProfiler.b();
 
//this.world.methodProfiler.a("goalSelector");
//this.goalSelector.a();
this.petGoalSelector.run(); // This is where I tick my own pathfinder selector
//this.world.methodProfiler.b();
 
//this.world.methodProfiler.a("navigation");
//this.navigation.e();
this.nav.e();
//this.world.methodProfiler.b();
 
//this.world.methodProfiler.a("mob tick");
this.bp();
//this.world.methodProfiler.b();
 
//this.world.methodProfiler.a("controls");
 
//this.world.methodProfiler.a("move");
this.getControllerMove().c();
 
//this.world.methodProfiler.c("look");
this.getControllerLook().a();
 
//this.world.methodProfiler.c("jump");
this.getControllerJump().b();
//this.world.methodProfiler.b();
//this.world.methodProfiler.b();
}
 
public boolean a_(EntityHuman human) {
if (super.a_(human)) {
return false;
}
 
if (human.getBukkitEntity() == this.getOwner().getPlayer()) {
ArrayList<MenuOption> options = MenuUtil.createOptionList(getPet().getPetType());
PetMenu menu = new PetMenu(getPet(), options);
menu.open();
return true;
}
return false;
}
 
public void setLocation(Location l) {
this.setLocation(l.getX(), l.getY(), l.getZ(), l.getPitch(), l.getYaw());
}
 
public void teleport(Location l) {
this.getPet().getCraftPet().teleport(l);
}
 
public void remove() {
this.getPet().getCraftPet().remove();
}
}
 

If needed, this is an example of the EntityBat class.

Code:java

 
package me.dsh105.echopet.entity.pet.bat;
import org.bukkit.ChatColor;
import net.minecraft.server.v1_5_R3.MathHelper;
import net.minecraft.server.v1_5_R3.World;
import me.dsh105.echopet.EchoPet;
import me.dsh105.echopet.entity.pet.EntityPet;
import me.dsh105.echopet.entity.pet.Pet;
public class EntityBatPet extends EntityPet {
 
public EntityBatPet(World world, Pet pet) {
super(world, pet);
this.texture = "/mob/bat.png";
this.a(0.5F, 0.9F);
this.fireProof = true;
}
 
public void setPet(Pet pet) {
if (pet != null) {
super.setPet(pet);
setHanging(((BatPet) pet.getCraftPet()).hanging);
}
}
 
public void setHanging(boolean flag) {
byte b0 = this.datawatcher.getByte(16);
if (flag) {
this.datawatcher.watch(16, Byte.valueOf((byte) (b0 | 1)));
}
else {
this.datawatcher.watch(16, Byte.valueOf((byte) (b0 & -2)));
}
((BatPet) pet.getCraftPet()).hanging = flag;
}
 
protected void a() {
super.a();
this.datawatcher.a(16, new Byte((byte) 0));
}
 
protected float aY() {
return super.aY() * 0.95F;
}
 
@Override
protected String bb() {
return this.h() && this.random.nextInt(4) != 0 ? null : "mob.bat.idle";
}
 
public void l_() {
super.l_();
if (this.h()) {
this.motX = this.motY = this.motZ = 0.0D;
this.locY = (double) MathHelper.floor(this.locY) + 1.0D - (double) this.length;
} else {
this.motY *= 0.6000000238418579D;
}
}
}
 

All code has been researched thoroughly from the Entity classes in the GitHub NMS Source.

The Goal Selector, setCraftPet and other plugin-related references are not the cause of the problem. Referenced CraftPets are similar to the CraftBukkit entities and are used for setting specific values of the pets without using the entity form.

I also have a whole series of entity classes that extend the class above (for most of the Vanilla Minecraft creatures). That's not the problem though. The problem is that whenever I attempt at spawning in an instance of this entity, it appears for about a second, then disappears. There's no errors and the entity was created completely. It's location is still stored in the EntityPet instance as well, as I am able to reference that without issues.

I have each entity instance registered, as below.

Show Spoiler Hide Spoiler

Code:java

 
try {
Method a = EntityTypes.class.getDeclaredMethod("a", Class.class, String.class, Integer.TYPE);
a.setAccessible(true);
 
a.invoke(a, EntityBatPet.class, "Bat", 65);
//...
// etc, etc etc.
 

Show Spoiler Hide Spoiler

Spawning the entity is as follows:

Show Spoiler Hide Spoiler

Code:java

 
net.minecraft.server.v1_5_R3.World mcWorld = ((CraftWorld) petLocation.getWorld()).getHandle();
EntityPet entityPet = pt.getNewEntityInstance(mcWorld, this);
 
entityPet.setLocation(petLocation.getX(), petLocation.getY(), petLocation.getZ(), petLocation.getPitch(), petLocation.getYaw());
if (!petLocation.getChunk().isLoaded()) {
petLocation.getChunk().load();
}
if (!mcWorld.addEntity(entityPet)) {
owner.sendMessage(ec.prefix + ChatColor.YELLOW + "Failed to spawn pet entity.");
ec.PH.removePet(this);
}
 
Event spawnEvent = new EchoPetSpawnEvent(this, petLocation);
EchoPet.getPluginInstance().getServer().getPluginManager().callEvent(spawnEvent);
 

I can show more code if needed.
Thanks for your time,
DSH105

Bump.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump. Any help would do.

 

this.bn();

i would have thought you would need that code (its commented out)

Also you didn't set a texture like in the other one

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

declanmc96
Adding this.bn() doesn't change the outcome (but I admit I should have had it in there, so thanks ). And what part are you referring to for the texture? This?
this.texture = "/mob/bat.png";

 

yes

 

So I should be setting a texture in the EntityPet class constructor?

Bump :\

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Yes

 

But EntityPet doesn't have a texture...it's super class for all of my entities.
I'm sorry, but I'm not sure what your suggestion is achieving.

 

No-one else has a solution?

 

Do you remember how you fixed this issue for v1_5_R3 ?

I'm working on backwards compatibility for one of my plugins and it's working for 1.6.1 to 1.7.9

But I'm getting the exact same issue as you for v1_5_R3,R2 : mobs visually spawn for a few milliseconds then immediately disappear. If you're curious about my code, here is my 1.7.2 code https://github.com/Europia79/Extraction - (haven't uploaded the others yet).

 

Make sure you set the health of the entity when it is spawned .

 

My plugin doesn't spawn anything. I merely register and replace EntityVillager with my CustomEntityVillager, and for 1.6.1 to 1.7.9, anytime a Villager would have spawned, my custom one spawns instead.

For testing, I just use spawn eggs and a spawner.

Despite this, inside CreatureSpawnEvent, i did villager.setHealth(20); but it didn't work. I even checked if the event was cancelled so that I could un-cancel it.

I guess I should just be happy that I have SOME backwards compatibility... But eventually, I would like to figure out the problem... It sounds exactly like yours... same version, same observations.

 

Spawn eggs and a spawner is still spawning the entity though. I'm pretty sure that was the solution to my problem at the time, in particular these two lines.

 

https://github.com/Europia79/Extrac...o/extraction/nms/v1_5_R3/Hostage.java#L28-L29

I added those lines, but it didn't work, so I added debugging lines BEFORE i set the Health and MaxHealth, and they were both already at 20. So, since their health is already at 20, I don't think this is the problem.

Are you sure those lines fixed disappearing mobs in 1.5.x ? It just looks like you're setting them to custom amounts.

 

That's the only thing I remember fixing it for me in that situation. It was a long time ago