Solved Creating new instances of class for no reason

Hey all. So, I'm making an SQL balance storage system. On startup, the plugin loads the info from the database & creating a new class instance so that there is a cached version of the data to prevent needless DB calls. Now, when a player joins a new "account" (basically a new instance of the Balance class) will be created if they don't have one already.

The problem that I'm getting is that a new instance of the Balance class is always created whether or not the player already has an "account". This is causing problems getting info, like the balance due to the fact that there are multiple instances of the player's account. Thanks in advance for the help

Here's all of the relevant code:

Balance:

Code:java

public class Balance {
 
    private double balance;
    private UUID uuid;
 
    /**
    * Create a new Balance instance for a player
    *
    * @param uuid : The UUID of a player
    */
    public Balance(UUID uuid){
        this.uuid = uuid;
    }
 
    /**
    * Get the balance of the player
    *
    * @return The player's balance
    */
    public double getBalance(){
        return balance;
    }
 
    /**
    * Get the UUID of the player
    *
    * @return The UUID of the player
    */
    public UUID getId(){
        return uuid;
    }
 
    /**
    * Set the balance of the player
    *
    * @param amount : The amount to add on to the balance
    */
    public void setBalance(double amount){
        this.balance = amount;
    }
 
    /**
    * Get the player from the UUID
    *
    * @return The player associated with the UUID
    */
    public Player getPlayer(){
        return Bukkit.getPlayer(uuid);
    }
}

BalanceManager:

Code:java

public class BalanceManager extends Thread {
 
    private ArrayList<Balance> instances = new ArrayList<Balance>();
    private static BalanceManager bm = new BalanceManager();
 
    public static BalanceManager getManager(){
        return bm;
    }
 
    /**
    * Get the Balance class instance of a given player to allow access to various methods
    *
    * @param player : The player
    * @return The Balance class instance of the player
    */
    public Balance getAccount(Player player){
        for (Balance b : instances){
            if (b.getId() == player.getUniqueId()){
                return b;
            }
        }
        return null;
    }
 
    public void createBalance(Player player){
        Balance b = new Balance(player.getUniqueId());
        b.setBalance(0);
        instances.add(b);
 
        try {
            DatabaseUtils.queryOut("INSERT INTO balance(player, balance)"
                    + "VALUES ('" + player.getUniqueId().toString() + "'," + b.getBalance() + ");");
        } catch(SQLException e) {
            e.printStackTrace();
        }   
    }
 
    /**
    * Load all the balances from the database. Call this method in onEnable()
    */
    public void loadBalancesFromDB(){
        new Thread() {
            @Override
            public void run() {
                ResultSet result = null;
                try {
                    result = DatabaseUtils.queryIn("SELECT * FROM balance;");
                    while (result.next()){
                        Balance b = new Balance(UUID.fromString(result.getString("player")));
                        b.setBalance(result.getDouble("balance"));
                        instances.add(b);
                        System.out.println("Loaded: " + b);
                        for (Balance bal : instances){
                            System.out.println("UUID: " + bal.getId());
                        }
                    }
                    System.out.println("Instances: " + instances);
                    for (Balance bal : instances){
                        System.out.println("UUID: " + bal.getId() + " Bal: " + bal.getBalance());
                    }
                } catch(SQLException e) {e.printStackTrace();}
            }
        }.start();
    }

PlayerJoin:

Code:java

public class PlayerJoin implements Listener {
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e){
        if (BalanceManager.getManager().getAccount(e.getPlayer()) == null){
            BalanceManager.getManager().createBalance(e.getPlayer());
        }else{
            System.out.println("not null");
        }
    }
}

I don't want to edit the previous post as to not mess to the code format, but I'm sorry if something doesn't make any sense. I'm kinda going on only a few hours of sleep (which might explain why I can't figure this out ).

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

The Gaming Grunts If I understood your question correctly, you need to just create a new value for the players who don't already have one. Take a look at the example below..

I have the following code on the OnEnable

Code:

for(Player player: Bukkit.getOnlinePlayers()){
            if(!(hasAccount(player.getName()))){
                createAccount(player.getName());
                System.out.println("[Towns] Generated a new account for " + player.getName());
            }
        }

The hasAccount method..

Code:

public boolean hasAccount(String player){
          for(String name: accountsConfig.getKeys(false)){
              if(name.equals(player)){
                  return true;
              }
          }
          return false;
      }

Create Account method

Code:

public void createAccount(String player){
          Account account = new Account(player, accountsConfig, newF);
      }

Then I have the following event to keep track of the players leaving and joining, checking to make sure they have a account

Code:

@EventHandler
      public void onPlayerJoin(PlayerJoinEvent event){
          if(!(hasAccount(event.getPlayer().getName()))){
              createAccount(event.getPlayer().getName());
              System.out.println("[Towns] Generated a new Account for " + event.getPlayer().getName());
          }
      }

With all of these methods it only creates an account for the players who don't already have one. Of course this isn't SQL, but you get the idea

Best of luck

 

jthort
I already have that Adding a null check with my getAccount() method is the same thing as your hasAccount() method

 

The Gaming Grunts Well then I assume something is wrong with one of your methods that checks if that player has an account. I'm going to be honest and say I didn't look at any of your code .

 

jthort
Looking at the code would probably help

 

Server running in online mode? If not player#getUniqueID Will return random uuids every time

 

L33m4n123
Yes it's in online mode

Well, I figured it out... had to change the == to .equals() in getAccount(). Gotta love these little oversights...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.