Creating a gun cooldown?

This might be a double post, I'm not sure. I already checked.

So, I wanted to create a gun that has a delay with X ticks. If you don't know what I mean, I mean like a fire rate, eg Bolt action snipers, BANG *click-click(2.5 second delay)* BANG, and repeat. I had something like this, but it wasn't calling the delays, so I just removed it. Thanks!

 

On the click run a scheduler that puts them in a "no shoot" arraylist for said gun(other ways could be used, maybe a hashmap with the gun name etc.) then after it ends remove them. On the click don't let them shoot.

 

Garris0n I've done that, and it didn't work. I added to a Hashmap, then called a scheduler when they try shoot again, and that didn't work.

 

write something like this:

Code:java

 
 
    public static List<String> noshoot = new ArrayList<String>();
 
@EventHandler
public void onShoot(PlayerInterachtEvent evt){
if (evt.getAction == Action.RIGHT_CLICK_AIR){
 
        if (! noshoot.contains(evt.getPlayer().getName()))  {        // watch out! comparing two strings is kinda tricky
        // shoot
        noshoot.add(evt.getPlayer().getName())
       // start sheduler here 
}
}
}
 
 

now just like Garrison said , just make a scheduler which removes the name from the list done

code has not been writen in eclipse

 

kaskoepoes112 I am pretty sure I already did that, I can try get those old glasses back and show you.
http://hastebin.com/fihurudoda.avrasm

 

kreashenz Are you sure everything is firing properly? Like add debug messages after everything and see what does and doesn't work.

 

I didn't look at all your code, but I took a very quick look and I didn't see any checks to cancel the event if the player already exists in the list...
Here's a snippet of your code

Code:java

 
if(dp.equalsIgnoreCase(b.getString("Wooden_Hoe.Name").replace('&', '§')) && a == Material.WOOD_HOE){
if(hasAmmo(p)){
launch(p, p.getLocation().add(0,1.62,0));
gun.shotWH.add(p.getName());
gun.shotWHDelay(p);
} else Functions.tell(p, "§cYou need more ammo!");
}
 

Unless I missed something, it should read:

Code:java

 
if(dp.equalsIgnoreCase(b.getString("Wooden_Hoe.Name").replace('&', '§')) && a == Material.WOOD_HOE){
if(!gun.shotWH.contains(p.getName()){
if(hasAmmo(p)){
launch(p, p.getLocation().add(0,1.62,0));
gun.shotWH.add(p.getName());
gun.shotWHDelay(p);
} else Functions.tell(p, "§cYou need more ammo!");
}
}
 

 

Jatoc :O Ohhhhhhhh mah gawd, you are most likely right. Good think I kept these classes. Gimme a few minutes, I will tell you if that's the reason.

 

aiight haha

 

Jatoc Ok, it's calling an NPE now, but it worked, I think. Here's the stacktrace.

PHP:

[SEVERE] Could not pass event PlayerInteractEvent to CoD v1.0
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
at org.bukkit.craftbukkit.v1_5_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:186)
at org.bukkit.craftbukkit.v1_5_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:156)
at net.minecraft.server.v1_5_R3.PlayerConnection.a(PlayerConnection.java:611)
at net.minecraft.server.v1_5_R3.Packet15Place.handle(SourceFile:58)
at net.minecraft.server.v1_5_R3.NetworkManager.b(NetworkManager.java:292)
at net.minecraft.server.v1_5_R3.PlayerConnection.d(PlayerConnection.java:109)
at net.minecraft.server.v1_5_R3.ServerConnection.b(SourceFile:35)
at net.minecraft.server.v1_5_R3.DedicatedServerConnection.b(SourceFile:30)
at net.minecraft.server.v1_5_R3.MinecraftServer.r(MinecraftServer.java:581)
at net.minecraft.server.v1_5_R3.DedicatedServer.r(DedicatedServer.java:226)
at net.minecraft.server.v1_5_R3.MinecraftServer.q(MinecraftServer.java:477)
at net.minecraft.server.v1_5_R3.MinecraftServer.run(MinecraftServer.java:410)
at net.minecraft.server.v1_5_R3.ThreadServerApplication.run(SourceFile:573)
Caused by: java.lang.NullPointerException
at me.kreashenz.cod.listeners.Guns.shotWADelay(Guns.java:202)
at me.kreashenz.cod.listeners.ShootListener.onPlayerShoot(ShootListener.java:70)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
... 16 more

And here's the codes for that part.

Code:java

 
// shotWADelay method.
    public void shotWADelay(final Player p){
        plugin.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new BukkitRunnable(){ // Line 202
            @Override
            public void run() {
                if(shotWA.contains(p.getName())){
                    shotWA.remove(p.getName());
                }
            }
        }, a.getInt("Wooden_Axe.Delay"));
    }
// Line 70 of onPlayerShoot
                    if(dp.equalsIgnoreCase(b.getString("Wooden_Axe.Name").replace('&', '§')) && a == Material.WOOD_AXE){
                        if(!gun.shotWA.contains(p.getName())){
                            if(hasAmmo(p)){
                                launch(p, p.getLocation().add(0,1.62,0));
                                gun.shotWA.add(p.getName());
                                gun.shotWADelay(p); // This is line 70
                            } else Functions.tell(p, "§cYou need more ammo!");
                        }
                    }

Thanks for the above message too

 

kreashenz

could you try replacing shotWA within the shotWADelay function so that it reads:

Code:java

 
 public void shotWADelay(final Player p){
        plugin.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new BukkitRunnable(){ // Line 202
            @Override
            public void run() {
                if(Guns.shotWA.contains(p.getName())){
                    Guns.shotWA.remove(p.getName());
                }
            }
        }, a.getInt("Wooden_Axe.Delay"));
    }
 

 

Jatoc That's exactly what it is now, just not with the Guns.shotWA, because it is in the guns class.. Do you mean to make it static?

 

Yes. Make it static, and specify the Guns class within the function. I don't know the specifics, but I think it has something to do with the function run() and the Bukkit scheduler running it not being in the same class or whatnot. I'm pretty new to this myself, but I'm sure someone else can provide more input. I've had issues like that fixed by specifying the class explicitly, and was wondering if that would fix your problem.

 

Jatoc That made it worse.. Any other ideas you got?

Can anyone please explain to me why this has an NPE..? I don't think it'd be plugin, because I have the constructor here

Code:java

private CoD plugin;
public Guns(CoD plugin){
this.plugin = plugin;
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump. I am still getting the NPE.

 

Last bump..