Solved Creating a File in the Plugin's Datafolder

I'm not getting why this isn't working:

Code:java

File testFile == null;
if (testFile == null) {
    File testFile = new File(plugin.getDataFolder(), "test.txt"); // <-- this one
    try {
        testFile.createNewFile();
    } catch (IOException e) {
        e.printStackTrace();
    }
}

I'm getting an NPE on the commented line, but honestly, what there should I put a null check for?

Just realized, the first line should only have one equals sign

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

plugin is null maybe

 

Plugin is working in all of my other classes that all happen to have the same constructor =/ Is there another way to generate a file that would work? I just need to make the file visible and editable in my plugin's folder.

 

Post the stacktrace

 

http://pastebin.com/sg5DD3Fp

 

the datafolder is null.
make this check
File f = getDataFolder();
if(!f.exists()){
f.mkdir();
}

 

No, it's there...

 

whats plugin?

 

post thisClass please :3

 

yeah that would help :3

 

f.mkdir() would not solve a NPE

 

i thought the datafolder was null not the plugin.
if it was the datafolder it would solve the npe but it's probs the pluin variable.

 

fireblast709
tommycake50
http://pastebin.com/6xhn3rLF

Also, the line that's in my main class that is in it is the one calling the method in the class posted above ^^

EDIT: Wow I've never used so many two letter words in a row ^

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

what are you passing into the constructor from the other class?

 

No if getDataFolder() would return null, calling .mkdir() would just give you another NPE

 

I just need it to be able to use "plugin" for plugin.getDataFolder()

 

oh yeah LOL.

yeah but can we see your other class where you instantiate thisclass.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Besides that, please refrain from using static. You probably call the method without instantiating an instance of the class

 

Do you need the entire thing? Here's the onEnable()

Code:java

public void onEnable() {
    getLogger().info("thisPlugin v1.0 has been enabled!");
    myCommandsClass.getCommands();
    anotherMethodGettingCalled();
    thisClass.createFile(); // <==
 
    try {
        BukkitMetrics metrics = new BukkitMetrics(this);
        metrics.start();
    } catch (IOException e) {
        // Failed to submit the stats :-(
    }
}

 

do you even instantiate the class with the plugin variable in?

 

fireblast709
Called it without the static void, and it worked. Thanks

For anyone venturing down this trail like I did, change the top line to the bottom two:

Code:java

thisClass.createFile();
 
thisClass class = new thisClass(this);
class.createFile();

Hehehe... awkward... fireblast709 why isn't this working?

Code:java

if (getDataFolder() == null) {
    File file = new File("kEssentials");
    file.mkdirs();
}

It's directly in my onEnable() method.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

KeybordPiano459 you know that you are creating <server dir>/kEssentials?

 

Isn't getDataFolder() for the plugin's folder in the plugins directory? Either way, there isn't a folder called kEssentials in the server directory.

 

Here's an example from my unsuccessful plugin back then.

Code:

    public void onEnable(){
        createFiles();
        getServer().getPluginManager().registerEvents(new LiveBanListener(), this);
        log.info(this + " is now enabled! Banning system is online!");
    }
   
    public void createFiles(){
        File folder = new File("plugins/Liveban");
        File file = new File("plugins/Liveban/banned.lcfe");
        File file2 = new File("plugins/Liveban/tempbanned.lcfe");
        if(!folder.exists()){
            folder.mkdir();
        }
        if(!file.exists()){
            try {
                file.createNewFile();
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
        if(!file2.exists()){
            try {
                file2.createNewFile();
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
    }

 

Th3Controller
That's pretty much exactly... what... I... did?

EDIT: Thanks Th3Controller
I changed it to this and it worked

Code:java

File file = new File("plugins/kEssentials");
file.mkdir();

 

From what it looks like it's not, do you mind sending the onEnable and the file creator?

Never mind lol, see it helped

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:java

if(!getDataFolder().exists() || !getDataFolder().isDirectory())
{
    getDataFolder().mkdirs();
}
File file = new File(getDataFolder(), "some.file");
if(!file.exists())
{
    try
    {
        if(!file.createNewFile())
        {
            throw new IOException("Failed to create file somehow...");
        }
    }
    catch(IOException ex)
    {
        ex.printStackTrace();
    }
}

(and no, this is not the same code as Th3Controller )

 

omg... fireblast709 I keep finding errors with this, why am I getting an NPE on the line commented below?

Code:java

public static FileConfiguration fileConfiguration = null;
public static File theFile = null;
public static void reloadFile() {
    if (!theFile.exists()) { // <-- this one
        theFile = new File(plugin.getDataFolder(), "file.yml");
    }
    fileConfiguration = YamlConfiguration.loadConfiguration(theFile);
 
    InputStream defConfigStream = plugin.getResource("file.yml");
    if (defConfigStream != null) {
        YamlConfiguration defConfig = YamlConfiguration.loadConfiguration(defConfigStream);
        fileConfiguration.setDefaults(defConfig);
    }
}

 

Because theFile is null... Where do you define it?

 

fireblast709
Well the thing is, if I changed the line that defines the file (public static File theFile = null) to this:

Code:java

public static File theFile = new File(plugin.getDataFolder(), "file.yml");

I get an NPE on that line (^)

Even then, the lines that calls the method in my onEnable are these-

EDIT by Moderator: merged posts, please use the edit button instead of double posting.