Cooldowns In Events, can't do, tried loads ¬_¬

So i want to make it so there is a cooldown on the interact event but nothing works? I've tried using bukkit scheduler and also adding them to hashmaps and getting millis, but i just can't figure it out... so i have turned to you lovely and patronizing people to help here is my code:

Code:java

@EventHandler
public void ThunderShock(PlayerInteractEvent event) {
Player player = event.getPlayer();
Action action = event.getAction();
if(player.getItemInHand().equals(ThunderShock) && action.equals(Action.RIGHT_CLICK_AIR)) {
 
 
 
} return;
}

Code:java

public ItemStack setMeta(ItemStack material, String name , List<String> lore, String string) {
        if(((material == null) || material.getType() == Material.AIR) || (name == null && lore == null))
 
            return null;
 
        ItemMeta im = material.getItemMeta();
        if (name != null)
            im.setDisplayName(name);
        if(lore != null) {
            im.setLore(lore);
 
        material.setItemMeta(im);
        return material;
 
        }
        return material;   
    }

Code:java

public ItemStack ThunderShock = setMeta(new ItemStack(Material.BLAZE_ROD), ChatColor.BOLD + "THUNDERSHOCK",
            Arrays.asList(ChatColor.GOLD + "Right Click To Use Thundershock!"), (ChatColor.ITALIC + "Can Be Used Every 3 Seconds"));

ok so that is the method, now can someone tell me how to implement a cooldown into that? thanks.

 

You never defined the thundershock thing to start off..

 

that isn't all the code.... i have edited it now....

 

1) Create a hashmap called cooldown or something like this

Code:

private HashMap<String,Boolean> cooldown = new HashMap<String,Boolean>();

2) Add the to the hashmap after the event fires

Code:

cooldown.put(player.getName(),false);

3) Create a schedular that removes them after some time (note that 20 ticks = 1 second)

Code:java

Bukkit.getServer().getSchedular().scheduleSyncDelayedTask(this,new Runnable(){
 
public void run(){
cooldown.put(player.getName(),true);
}
}
,200);

4) Make sure to check, if they're boolean value = false, to cancel the event.

If this doesn't work, just tag me and I'll respond

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code0

so just get a scheduled task from bukkit or what?

Code0

It doesn't work

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

What exactly makes it not work?

Is it an error in the console or what...


Post full code please

 

yewtree8

For cooldowns, I would personally compare against a Long time as it won't need a task to remove the player from the collection, it will be comparing against the current system time in milliseconds.

First declare your variables:
private Map<UUID, Long> cooldownMap = new HashMap<UUID, Long>();
private int cooldownDuration = 180 //(3 minutes - 180 second cooldown)


Setting a player on the cooldown:

Code:

public void setCooldown(Player player) {
 
      cooldownMap.put(player.getUniqueId(), System.currentTimeMillis());
 
}

When you want to get the remaining cooldown time:

Code:

public double getCooldownRemaining(Player player) {
   
     long timeLeft= cooldownMap.get(player.getUniqueId());
     double cooldownTime = cooldownDuration + 0.0;
     double secondsLeft = ((timeLeft / 1000.0) + cooldownTime) - (System.currentTimeMillis() / 1000.0);
   
}

To check if the player is on the cooldown:

Code:

public boolean hasCooldown(Player player) {
 
     return getCooldownRemaining(player) > 0;
 
}

 

Code0

ok so this is my code, it just doesn't work, there will be no cooldown of 3 seconds (60 ticks)

for the casting of thundershock, asks for a player to do the thundershock, maybe that is interfearing?

Code:java

@EventHandler
    public void onThunderShock(EntityDamageByEntityEvent event) {
        Player player = (Player) event.getEntity();
 
        if (event.getDamager() instanceof Snowball) {
            Snowball s = (Snowball) event.getDamager();
            if (s.getShooter() instanceof Player) {
            Player shooter = (Player) s.getShooter();
            if (shooter.getItemInHand().equals(ThunderShock)) {
            if(player instanceof Player) {
 
            event.getEntity().getLocation().getWorld().strikeLightning(event.getEntity().getLocation());
            event.setDamage(3.0);
            shooter.sendMessage(ChatColor.GOLD + "PikaChu Used ThunderShock ");
 
            } else {
 
                player.sendMessage(ChatColor.GOLD + "ThunderShock " + ChatColor.RED + "Missed!" );
 
            }
 
            }
            }
            }
 
    }

Now for the event with the cooldown

Code:java

@EventHandler
    public void ThunderShock(PlayerInteractEvent event) {
        final Player player = event.getPlayer();
        Action action = event.getAction();
        if(player.getItemInHand().equals(ThunderShock) && action.equals(Action.LEFT_CLICK_AIR)) {
                if(ThunderCD.containsValue(player)) {
 
                    player.sendMessage(ChatColor.RED + "You Cant Use That Yet!");
                    return;
 
                }
 
 
 
            Projectile snowball = player.launchProjectile(Snowball.class);
            snowball.setVelocity(player.getEyeLocation().getDirection().multiply(4));
 
            ThunderCD.put(player.getName(),false);
 
            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this,new Runnable(){
 
                public void run(){
                ThunderCD.put(player.getName(),true);
                }
                }
                ,60);
 
 
            } return;
 
 
 
    }