Checking when a player levels up

So I am trying to figure a way to tell when a player levels up a certain skill?
Code for getting the players skill level

Code:java

    public static int getLevel(Player p, String level){
        int z = 0;
        int x = Processor.getXP(p, level);
 
        if(  x>=0 && x<83 ){
            z= +1;
        }
        if( x>=83 && x<174){
            z= +2;
        }
        if( x>=174 && x<276){
            z= +3;
        }
        if( x>=276 && x<388){
            z= +4;
        }
        if( x>=388 && x<512){
            z= +5;
        }
        if( x>=512 && x<650){
            z= +6;
        }
        if( x>=650 && x<801){
            z= +7;
        }
        if( x>=650 && x<801){
            z= +8;
        }
        if( x>=801 && x<969){
            z= +9;
        }
        if( x>=969 && x<1154){
            z= +10;
        }
        if( x>=1154 && x<1358){
            z= +11;
        }
        if( x>=1358 && x<1584){
            z= +12;
        }
        if( x>=1584 && x<1833){
            z= +13;
        }
        if( x>=1833 && x<2107){
            z= +14;
        }
        if( x>=2107 && x<2411){
            z= +15;
        }
        if( x>=2411 && x<2746){
            z= +16;
        }
        if( x>=2746 && x<3115){
            z= +17;
        }
        if( x>=3115 && x<3523){
            z= +18;
        }
        if( x>=3523 && x<3973){
            z= +19;
        }
        if( x>=3973 && x<4470){
            z= +20;
        }
        if( x>=4470 && x<5018){
            z= +21;
        }
        if( x>=5018 && x<5624){
            z= +22;
        }
        if( x>=5624 && x<6291){
            z= +23;
        }
        if( x>=6291 && x<7028){
            z= +24;
        }
        if( x>=7020 && x<7842){
            z= +25;
        }
        if( x>=7842 && x<8740){
            z= +26;
        }
        if( x>=8740&& x<9730){
            z= +27;
        }
        if( x>=9730 && x<10824){
            z= +28;
        }
        if( x>=10824 && x<12031){
            z= +29;
        }
        if( x>=12031 && x<13363){
            z= +30;
        }
        if( x>=13363 && x<14833){
            z= +31;
        }
        if( x>=14833 && x<16456){
            z= +32;
        }
        if( x>=16456 && x<18247){
            z= +33;
        }
        if( x>=8740 && x<9730){
            z= +34;
        }
        if( x>=9730 && x<22406){
            z= +35;
        }
        if( x>=22406 && x<24815){
            z= +36;
        }
        if( x>=24815 && x<27473){
            z= +37;
        }
        if( x>=27473 && x<30408){
            z= +38;
        }
        if( x>=30408 && x<33648){
            z= +39;
        }
        if( x>=33648 && x<37224){
            z= +40;
        }
        if( x>=37224 && x<41171){
            z= +41;
        }
        if( x>=41171 && x<45529){
            z= +42;
        }
        if( x>=45529 && x<50339){
            z= +43;
        }
        if( x>=50339 && x<55649){
            z= +44;
        }
        if( x>=55649 && x<61512){
            z= +45;
        }
        if( x>=61512 && x<67983){
            z= +46;
        }
        if( x>=67983 && x<75127){
            z= +47;
        }
        if( x>=75127 && x<83014){
            z= +48;
        }
        if( x>=83014 && x<91721){
            z= +49;
        }
        if( x>=91721 && x<101333){
            z= +50;
        }
        if( x>=101333 && x<111945){
            z= +51;
        }
        if( x>=111945 && x<123660){
            z= +52;
        }
        if( x>=123660 && x<136594){
            z= +53;
        }
        if( x>=136594 && x<150872){
            z= +54;
        }
        if( x>=150872 && x<166636){
            z= +55;
        }
        if( x>=166636 && x<184040){
            z= +56;
        }
        if( x>=184040 && x<203254){
            z= +57;
        }
        if( x>=83014 && x<224466){
            z= +58;
        }
        if( x>=224466 && x<247886){
            z= +59;
        }
        if( x>=247886 && x<273742){
            z= +60;
        }
        if( x>=273742 && x<302288){
            z= +61;
        }
        if( x>=302288 && x<333804){
            z= +62;
        }
        if( x>=333804 && x<368599){
            z= +63;
        }
        if( x>=368599 && x<407015){
            z= +64;
        }
        if( x>=407015 && x<449428){
            z= +65;
        }
        if( x>=449428 && x<496254){
            z= +66;
        }
        if( x>=496254 && x<547953){
            z= +67;
        }
        if( x>=547953 && x<605032){
            z= +68;
        }
        if( x>=605032 && x<668051){
            z= +69;
        }
        if( x>=668051 && x<737627){
            z= +70;
        }
        if( x>=737627 && x<814445){
            z= +71;
        }
        if( x>=814445 && x<899257){
            z= +72;
        }
        if( x>=899257 && x<992895){
            z= +73;
        }
        if( x>=992895 && x<1096278){
            z= +74;
        }
        if( x>=1096278 && x<1210421){
            z= +75;
        }
        if( x>=1210421 && x<1336443){
            z= +76;
        }
        if( x>=1336443 && x<1475581){
            z= +77;
        }
        if( x>=1475581 && x<1629200){
            z= +78;
        }
        if( x>=1629200 && x<1798808){
            z= +79;
        }
        if( x>=1798808 && x<1986068){
            z= +80;
        }
        if( x>=1986068 && x<2192818){
            z= +81;
        }
        if( x>=2192818 && x<2421087){
            z= +82;
        }
        if( x>=2421087 && x<2673114){
            z= +83;
        }
        if( x>=2673114 && x<2951373){
            z= +84;
        }
        if( x>=2951373 && x<3258594){
            z= +85;
        }
        if( x>=3258594 && x<3597792){
            z= +86;
        }
        if( x>=3597792 && x<3972294){
            z= +87;
        }
        if( x>=3972294 && x<4385776){
            z= +88;
        }
        if( x>=4385776 && x<4842295){
            z= +89;
        }
        if( x>=4842295 && x<5346332){
            z= +90;
        }
        if( x>=5346332 && x<5902831){
            z= +91;
        }
        if( x>=5902831 && x<6517253){
            z= +92;
        }
        if( x>=6517253 && x<7195629){
            z= +93;
        }
        if( x>=7195629 && x<7944614){
            z= +94;
        }
        if( x>=7944614 && x<8771558){
            z= +95;
        }
        if( x>=8771558 && x<9684577){
            z= +96;
        }
        if( x>=9684577 && x<10692629){
            z= +97;
        }
        if( x>=10692629 && x<11805606){
            z= +98;
        }
        if( x>=11805606 && x<13034431){
            z= +99;
        }
        if( x>13034431){
            z= +100;
        }
 
        return z;
    }

but basically what i am trying to do is when a player gains a new level, it will send them a custom message, how would I go about doing this?

 

Zounds! You should maybe consider using a Collection of xp level thresholds of some kind instead of that crazy-huge list of ifs ...

That aside, I think we need to see more of this code to help. Are you the one giving the player XP? I assume you don't mean vanilla XP here?

If so, simply record the player's level before giving them XP, then check their level after- if it's gone up, send them a message.

 

NathanWolf

How can I go about using a collection of xp?
and yeah just a single player, what the "motherload of if's" does it get what level a player is at based of their XP in their playerfile.

 

I was thinking something like

Code:

Integer[] thresholds = {83, 174, .... 1304431};
int level = 0;
while (xp > 0) {
  if (level >= thresholds.length) break;
  if (xp < thresholds[level]) break;
  xp -= thresholds[level];
}

Not trying to spoonfeed, but hopefully that gives you the right idea.

I'm not totally sure what the second part of your question is!

 

NathanWolf

So here is what I have, but it always returns it as level 0.

Code:java

    public static int getLevel(Player p, String level){
 
        Integer[] thresholds = {83, 174, 1304431};
        int lvl = 0;
        int xp = plugin.getConfig().getInt(level);
 
        while (xp > 0) {
          if (lvl >= thresholds.length) break;
          if (xp < thresholds[lvl]) break;
          xp -= thresholds[lvl];
 
        }
        return lvl;
    }

 

Are you storing the player's XP in config somewhere? I'm guessing you'd want to do something more like

Code:

ConfigurationSection playerData = plugin.getConfig().getConfigurationSection(player.getUUID().toString());
int xp = playerData.getInt("xp");
...

 

NathanWolf

I am still attempting to work out how to do this xD, no matter what it returns the level as 1.

getLevel() method + class

Code:java

package com.kassestral.plugins.ilevel;
 
import java.io.File;
import java.io.IOException;
 
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
 
public class Processor {
 
    private static Main plugin;
    public Processor(Main plugin){
        Processor.plugin = plugin;
    }
 
    static FileConfiguration playerconfig;
    static File playerfile;
    Player player;
 
    public static void Createplayerfile(Player p){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        if(!playerfile.exists()){
            try {
                playerfile.createNewFile();
 
                playerconfig.set("Archery", 0);
                playerconfig.set("Cooking", 0);
                playerconfig.set("Farming", 0);
                playerconfig.set("Hunting", 0);
                playerconfig.set("Mining", 0);
                playerconfig.set("Smithing", 0);
                playerconfig.set("Swords", 0);
                playerconfig.set("Unarmed", 0);
                playerconfig.set("Woodcutting", 0);
                playerconfig.save(playerfile);
            }
            catch (IOException e){
                e.printStackTrace();
                }
            }
        }
 
    public static int getXP(Player p, String level){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        return playerconfig.getInt(level);
    }
 
    public static void setXP(Player p, String level, int i){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        playerconfig.set(level, i);
        try{
            playerconfig.save(playerfile);
            } catch (IOException e){
                e.printStackTrace();
                }
        }
 
    public static void addXP(Player p, String level, int i){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        int before = playerconfig.getInt(level);
        playerconfig.set(level, before + i);
        try{
            playerconfig.save(playerfile);
            } catch (IOException e){
                e.printStackTrace();
                }
 
    }
 
    public static int getLevel(Player p, String level){
 
        int lvl = 1;
        Integer[] values = {83, 174, 276, 388, 512, 650, 801, 969, 1154, 1358, 1584, 1833, 2107, 2411, 2746, 3115, 3523, 3973, 4470, 5018, 5624, 6291, 7028, 7842, 8740, 9730, 10824, 12031, 13363, 14833, 16456, 18247, 20224, 22406, 24815, 27473, 30408, 33648, 37224, 41171, 45529, 50339, 55649, 61512, 67983, 75127, 83014, 91721, 101333, 111945, 123660, 136594, 150872, 166636, 184040, 203254, 224466, 247886, 273742, 302288, 333804, 368599, 407015, 449428, 496254, 547953, 605032, 668051, 737627, 814445, 899257, 992895, 1096278, 1210421, 1336443, 1475581, 1629200, 1798808, 1986068, 2192818, 2421087, 2673114, 2951373, 3258594, 3597792, 3972294, 4385776, 4842295, 5346332, 5902831, 6517253, 7195629, 7944614, 8771558, 9684577, 10692629, 11805606, 13034431};
 
        int xp = plugin.getConfig().getInt(level);
        while(xp > 0){
              if (lvl >= values.length) break;
              if (xp < values[lvl]) break;
              xp -= values[lvl];
        }
 
        return lvl;
    }
 
    }

testing the getLevel() method

Code:java

    @EventHandler
    public void onMining(BlockBreakEvent e){
 
        Material block = e.getBlock().getType();
        Player p = e.getPlayer();
        String level = "Mining";
 
        if(block.equals(Material.STONE)){
            Processor.addXP(p, level, plugin.getConfig().getInt("Mining.stone"));
            p.sendMessage("You are level " + Processor.getLevel(p, level));
        }

is their anyway to increase int lvl by 1 everytime it goes up a values.length?

NathanWolf

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Totally off topic but you should probably check if the evvent is cancelled before awarding a player XP, and if you're using any protection plugins check if it's protected for them too. If not people can just spam protected blocks and gain XP.

Talking experience btw.

 

CXdur

Thanks for the contribution I never thought of this, I will have to implement that at some point, but at the moment I am just trying to make a BASIC levelling system, I fixed it so people gain XP for everything they do I just cant get it so that if they change from say level 1 to 2 then they would receive a message saying "You have reached level 2 + {skillname}" or something like that if you get what I am implying?

 

Kassestral when you check for if the player has enough xp to lvl up him, you execute the lvl up code, at this part send a message...

Just saw the code, I'm wrong, u already did it :/ but I still don't understand what you want to do...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

mine-care

It ALWAYS return the level as 1 for some reason

 

Kassestral I *think* I see the problem (this is all looking very much like it should work) - in your getLevel method you aren't loading the player data file, but using the default plugin config:

Code:

int xp = plugin.getConfig().getInt(level);

Where everywhere else you're doing it correctly, I think:

Code:

playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
playerconfig = YamlConfiguration.loadConfiguration(playerfile);

I think the best thing to do there is just call "getXP" from within getLevel, and not deal with the configs in that method at all.

Otherwise this all makes sense to me. One note though is that eventually you probably want to store the player data in a HashMap and only save it to config on disable and/or maybe a repeating task. Reading and writing a config file any time the player gains XP will probably lag the server.

 

Better yet, track the level, and start at 0.

Code:java

//Pre-req, level is == 2, xp is some number
int[] levels = {50, 114, 210, 300, ...};
 
//...
if (level[/*get current level*/] <= /*get current xp*/) {
    //level up!
}

 

Agreed!

In my defense, at the time I hadn't seen the OP's full code and didn't really know where this "xp" value was coming from or if they even had control over it.

The only thing I would provide as a "devils' advocate", though- storing the XP and not the level gives you the flexibility to modify the level tiers later. This might be weird for players, though- like they were level 5 one day and they're level 3 the next.

BTW, OT- 1Rogue, how long have you been staff? I feel like that's semi-recent, but not sure... I've been seeing you around the forums for quite some time and never noticed the pretty orange name Well, congrats, at any rate.

 

Since January ;p

 

1Rogue NathanWolf

how would I get the players current level? save their level in their player file?

 

Or wherever you want to persist it, yes!

 

1Rogue
is this more or less right?

Code:java

package com.kassestral.plugins.ilevel;
 
import java.io.File;
import java.io.IOException;
 
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
 
public class Processor {
 
    private static Main plugin;
    public Processor(Main plugin){
        Processor.plugin = plugin;
    }
 
    static FileConfiguration playerconfig;
    static File playerfile;
    Player player;
 
    public static void Createplayerfile(Player p){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        if(!playerfile.exists()){
            try {
                playerfile.createNewFile();
 
                playerconfig.set("Archery", 0);
                playerconfig.set("Archery.Level", 1);
                playerconfig.set("Cooking", 0);
                playerconfig.set("Cooking.Level", 1);
                playerconfig.set("Farming", 0);
                playerconfig.set("Farming.Level", 1);
                playerconfig.set("Hunting", 0);
                playerconfig.set("Hunting.Level", 1);
                playerconfig.set("Mining", 0);
                playerconfig.set("Mining.Level", 1);
                playerconfig.set("Smithing", 0);
                playerconfig.set("Smithing.Level", 1);
                playerconfig.set("Swords", 0);
                playerconfig.set("Swords.Level", 1);
                playerconfig.set("Unarmed", 0);
                playerconfig.set("Unarmed.Level", 1);
                playerconfig.set("Woodcutting", 0);
                playerconfig.set("Woodcutting.Level", 1);
                playerconfig.save(playerfile);
            }
            catch (IOException e){
                e.printStackTrace();
                }
            }
        }
 
    public static int getXP(Player p, String level){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        return playerconfig.getInt(level);
    }
    public static int getLevel(Player p, String level){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        return playerconfig.getInt(level + ".Level");
    }
 
    public static void setXP(Player p, String level, int i){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        playerconfig.set(level, i);
        try{
            playerconfig.save(playerfile);
            } catch (IOException e){
                e.printStackTrace();
                }
        }
    public static void addLevel(Player p, String level, int i){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        int before = Processor.getLevel(p, level + ".Level");
 
        playerconfig.set(level + ".Level", before + i);
        try{
            playerconfig.save(playerfile);
            } catch (IOException e){
                e.printStackTrace();
                }
        }
 
    public static void addXP(Player p, String level, int i){
        playerfile = new File(plugin.getDataFolder() + File.separator + "players" + File.separator + p.getUniqueId().toString() + ".yml");
        playerconfig = YamlConfiguration.loadConfiguration(playerfile);
 
        int before = playerconfig.getInt(level);
        playerconfig.set(level, before + i);
        try{
            playerconfig.save(playerfile);
            } catch (IOException e){
                e.printStackTrace();
                }
 
    }
 
        public static int levelUP(Player p, String level){
 
            Integer[] levels = {83, 174, 276, 388, 512, 650, 801, 969, 1154, 1358, 1584, 1833, 2107, 2411, 2746, 3115, 3523, 3973, 4470, 5018, 5624, 6291, 7028, 7842, 8740, 9730, 10824, 12031, 13363, 14833, 16456, 18247, 20224, 22406, 24815, 27473, 30408, 33648, 37224, 41171, 45529, 50339, 55649, 61512, 67983, 75127, 83014, 91721, 101333, 111945, 123660, 136594, 150872, 166636, 184040, 203254, 224466, 247886, 273742, 302288, 333804, 368599, 407015, 449428, 496254, 547953, 605032, 668051, 737627, 814445, 899257, 992895, 1096278, 1210421, 1336443, 1475581, 1629200, 1798808, 1986068, 2192818, 2421087, 2673114, 2951373, 3258594, 3597792, 3972294, 4385776, 4842295, 5346332, 5902831, 6517253, 7195629, 7944614, 8771558, 9684577, 10692629, 11805606, 13034431};
            if (levels[Processor.getLevel(p, level)] <= Processor.getXP(p, level)) {
            int i = 1;
            Processor.addLevel(p, level, + i);
            }
            return Processor.getLevel(p, level + ".Level");
 
        }
 
    }

 

Just skipping through all the messages sent before, no one has even dared to mention PlayerLevelChangeEvent or Player#getLevel()

 

<-
<-
<-
<-
<-

 

Yes, that is very true. READ THE JAVADOCS :3

 

fireblast709

isnt PlayerLevelChangeEvent only when the player levels up in their general level? whereas this is a self made skill level

 

Kassestral yep. In your case maybe PlayerExpChangeEvent might come in handy though if you do not have it yet to catch when the player gets / looses exp so you can adjust it for your needs

PS: If you already have it in your code. My bad. did not looked at it^^

 

How would I specfiy this event to my needs?

 

Kassestral Also it might be slightly better for performance (or perhaps a lot, most likely the latter since you perform some nice juicy file IO tasks every single time you do something) to be less static and have an actual storage.

Aside one of my standard arguments that it is not OOP.

 

All you guys suggesting that the OP use Bukkit XP events should really look more closely at what the OP is trying to do. It's not related to vanilla XP at all.

 

Kassestral Well. Note first off all that all mentioned underneath now comes only from reading the titel of the thread and your statement that you using a custom level system. I will read the post later and give more usefull feedback. currently doing other stuff

Show Spoiler Hide Spoiler

As I said I did not read through your code. However with the PlayerExpChangeEvent you can intercept how much exp he gets and modify that to your needs. Also there you can put it in your own map or w/e you use like <Player, EXP> and call a new method from within there if his exp reaches a certain ammount to customly level him up then. And with a MultiValueMap from org.apache.commons.collections.map you can easily store it for example as Player, Exp, Level and then work from there within the PlayerExpChangeEvent

 

L33m4n123

I will wait till later xD.

 

Ok

So ok [Sorry for the double post but I want to make sure the OP sees it]

I now think to understand your issue. I thought you just want to make the basic levels different. So What you basicly need to do is, that when you give the player exp for a certain ability to check the array wether it equals the levels exp or not to level up. so in code form it would be something like

Code:java

//We assume that the level = the index+1 of the exp. so that the first entry in the array is for level1
public void getExp(int ammount, String target) {
  //get the players current exp and level
  int exp = ;
  int level = ;
  //now give him the new exp
  int newExp = exp + ammount;
 
  //now to check if the exp was enough to level up
  //I set i to level to get the index of the array to get the exp needed for the next level
  // because everything before does not matter
  for (int k = level; k < array; k++) {
    if (newExp == array[k]) {
    //Player has enough exp to level up
    playersNewLevel = k;
    break;
    } else {
      if (newExp > array[k]) {
        //check if the player has more exp to level up
        continue;
      } else if (newExp < array[k]) {
        //Player leveld up. Hooray!
        playersNewLevel = k-1;
        break;
      }
    }
  }
}

So be aware that I threw this code real quick together. I might have had a brainfart in my logic but overall it should give you the direction that you need to look at

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

That sort of goes completely against the idea I specified, if you have the experience and current level you don't need to iterate through the array.