Chat Format error?

Hello everyone!

I recently coded a chat formatter plugin for someone in the Plugin Requests section and it was working when I published it. Sometime yesterday, they asked for a feature to be added and now for some reason it is erroring on setting the format.

The error:

Code:

[07:24:23 ERROR]: Could not pass event AsyncPlayerChatEvent to ChatFormatter v1.0
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:484) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at net.minecraft.server.v1_8_R3.PlayerConnection.chat(PlayerConnection.java:1084) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:1022) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at net.minecraft.server.v1_8_R3.PacketPlayInChat$1.run(PacketPlayInChat.java:39) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_77]
        at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_77]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:1.8.0_77]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:1.8.0_77]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_77]
Caused by: java.util.UnknownFormatConversionException: Conversion = 'm'
        at org.bukkit.event.player.AsyncPlayerChatEvent.setFormat(AsyncPlayerChatEvent.java:100) ~[spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at me.astrophylite.chatformatter.ChatFormatter.onPlayerChat(ChatFormatter.java:72) ~[?:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_77]
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_77]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_77]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_77]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot_server.jar:git-Spigot-db6de12-18fbb24]
        ... 11 more

Any help will be appreciated,
Astrophylite.

 

Have you used replaceAll or anx methods, wich uses regEx?

 

@mcdorli I have used #replace() but I don't think that uses regEx...

Astrophylite.

 

@Astrophylite Maybe show

Maybe show us some code, replace can take in regEx

 

@mcdorli Here is my code:

Show Spoiler Hide Spoiler

Code:java

 
package me.astrophylite.chatformatter;
 
import java.io.File;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.AsyncPlayerChatEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
import ru.tehkode.permissions.bukkit.PermissionsEx;
 
public class ChatFormatter extends JavaPlugin implements Listener {
 
    FileConfiguration config;
    File cfile;
 
    public void onEnable() {   
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
 
        getConfig().options().copyDefaults(true);
        config = getConfig();
        saveConfig();
        cfile = new File(this.getDataFolder(), "config.yml");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        if(cmd.getName().equalsIgnoreCase("chatformatter")) {
            if(!sender.hasPermission("chatformatter.main")) {
                sender.sendMessage(getPrefix() + ChatColor.RED + " You are lacking the permission node: chatformatter.main!");
                return true;
            }
 
            if(args.length == 0 || args.length > 1) {
                sender.sendMessage(getPrefix() + ChatColor.RED + " Usage: /" + label + " <reload>");
                return true;
            }
            if(args[0].equalsIgnoreCase("reload")) {
                config = YamlConfiguration.loadConfiguration(cfile);
                sender.sendMessage(getPrefix() + ChatColor.GREEN + " You successfully reloaded ChatFormatter's configuration file!");
                return true;
            } else {
 
            }
        }
        return true;
    }
 
    @EventHandler(priority = EventPriority.HIGHEST)
    public void onPlayerChat(AsyncPlayerChatEvent e) {
        Player p = e.getPlayer();
        String prefix = null, suffix = null;
        if(PermissionsEx.getUser(p).getPrefix() != null || !PermissionsEx.getUser(p).getPrefix().isEmpty()) {
            prefix = PermissionsEx.getUser(p).getPrefix();
        }
        if(PermissionsEx.getUser(p).getSuffix() != null || !PermissionsEx.getUser(p).getSuffix().isEmpty()) {
            suffix = PermissionsEx.getUser(p).getSuffix();
        }
 
        String format = ChatColor.translateAlternateColorCodes('&', config.getString("chat-format"));
        String customFormat = format.replace("%prefix", prefix
                .replace("%name", p.getName())
                .replace("%suffix", suffix)
                .replace("%message", e.getMessage()));
        e.setFormat(customFormat);
    }
 
    public String getPrefix() {
        String prefix = config.getString("prefix") + " ";
        return ChatColor.translateAlternateColorCodes('&', prefix);
    }
}

 

Try changing the % to something else, like {} in the strings, and use that to replace.

 

@mcdorli The error changed ever so slightly. Still on line 72...

Code:

[09:59:06 ERROR]: Could not pass event AsyncPlayerChatEvent to ChatFormatter v1.0
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:484) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at net.minecraft.server.v1_8_R3.PlayerConnection.chat(PlayerConnection.java:1084) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:1022) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at net.minecraft.server.v1_8_R3.PacketPlayInChat$1.run(PacketPlayInChat.java:39) [spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_77]
        at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_77]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:1.8.0_77]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:1.8.0_77]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_77]
Caused by: java.util.UnknownFormatConversionException: Conversion = ' '
        at org.bukkit.event.player.AsyncPlayerChatEvent.setFormat(AsyncPlayerChatEvent.java:100) ~[spigot_server.jar:git-Spigot-db6de12-18fbb24]
        at me.astrophylite.chatformatter.ChatFormatter.onPlayerChat(ChatFormatter.java:72) ~[?:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_77]
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_77]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_77]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_77]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot_server.jar:git-Spigot-db6de12-18fbb24]
        ... 11 more

Code is the same just without the %'s in the replace.

Astrophylite.

 

@Astrophylite
"UnknownFormatConversionException: Conversion = ' '"
You probably know that there are a few placeholders for the format method. "%s" for Strings for example. Somewhere in the message you have "% ". This will be treated as a placeholder due to the leading "%" sign. Print out the format and find this rogue "%" sign and fix it

 

@Astrophylite NEVER put the message in the format, (also don't put the player name)

The problem is that you're using the chat format wrong, put the proper string tokens for the formatter so it works as intended (either "%s" or %1$s and %2$s)

 

@Astrophylite
By looking at your code it seems like you misplaced the brackets.

String customFormat = format.replace("%prefix", prefix
.replace("%name", name)
.replace("%suffix", suffix)
.replace("%message", message));

The bold ones are the wrong brackets. All the italic code replaces the underlined String, not the format one. Move one of the two bold brakets behind "prefix" and it should work.

 

Thank you guys for your help, I will try fixing this later on. c;

Astrophylite.