Solved Can't save custom config

I am trying to make a config for each player, and save stuff in each config. But for some reason, when I save something in the config, nothing happens. My code:

Code:java

Main.getPlayerConfig(p.getName()).set(/*my path*/, /*my object*/);
Main.saveConfig(p.getName());

The methods are:

Code:java

public static File getPlayerFile(String str){
        File file = new File(Main.getInstance().getDataFolder(), "users");
        for(File yml : file.listFiles()){
            if(yml.getName().equals(str.toLowerCase()+".yml")){
                return yml;
            }
        }
        File playerFile = new File(file.getPath(), str+".yml");
        if(!playerFile.exists()){
            try {
                playerFile.createNewFile();
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
        return playerFile;
    }
    public static final void saveConfig(String config){
        File file = getPlayerFile(config);
        YamlConfiguration cfg = getPlayerConfig(config);
        try{
            cfg.load(file);
            cfg.save(file);
        }catch(Exception e){
            e.printStackTrace();
        }
    }
    public static YamlConfiguration getConfig(File file){
        if(!file.exists()){
            try {
                file.createNewFile();
            } catch (IOException e) {
                Main.getInstance().getLogger().warning("Failed to create file "+file.getName()+"!");
            }
        }
        return YamlConfiguration.loadConfiguration(file);
 
    }
    public static final YamlConfiguration getPlayerConfig(String str){
        return getConfig(getPlayerFile(str));
    }

I also have a PlayerJoinEvent where I create the configs for each players:

Code:java

Player p = e.getPlayer();
        YamlConfiguration config = Main.getPlayerConfig(p.getName());
        config.addDefault("loadout", "");
        config.addDefault("level", 1);
        Main.saveConfig(p.getName());

I have no idea what's wrong, please help! Thanks in advance!

 

My sugestion at first is use less static... Static is not only about easy access.
Secondly, you get any errors? Have you tried debugging?

 

NonameSL you create a different instance in your save method. Instead, get the YamlConfiguration object, set the data, and call save(File) on that same YamlConfiguration object

 

mine-care I use the method in other classes so it's static.
fireblast709 I will try that, ill reply if it worked

 

NonameSL but static can be proven bad in some cases
you could use the instance of a class to use its public methods and variables.

 

fireblast709 , But I am not. I am using a string for the method, and then calling the other method with the string. I don't understand what you're trying to say, should I have a map of all configs?

 

NonameSL ok let's walk through your code, perhaps that will clear things up.

1. You call getPlayerConfig(p.getName())
2. getPlayerConfig(name) will find the player's File, create if it doesn't exist, and create a new YamlConfiguration object with the file
3. In this very YamlConfiguration instance, you set the value of 'path' to 'object'
4. Then, you call saveConfig(p.getName())
5. saveConfig does the same as steps 2 and 3, but without the 'path' set to 'object' since you are working with a completely different YamlConfiguration reference
6. Then it will load the file from disk (again, and wiping any data you could have set when reusing the previous config object)
7. Lastly you save the file, which is just the clean file you loaded (without any new content)

Now, how can we solve this.

• Firstly, you should not load the file in the save method (referring to line 22 of the second snippet)
• Secondly, you should store the YamlConfiguration you got from the first call to getPlayerConfig(p.getName()) in a local variable (line 1 of the first snippet). Like so
  Code:java

  YamlConfiguration config = getPlayerConfig(p.getName());
  config.set('path', object)

• Last, but definitely not least, you should use that 'config' variable (as shown in the snippet above) to save the config to file. I would recommend:
  • Change the saveConfig(String config) to saveConfig(YamlConfiguration config, String playerName)
  • (minor change: getPlayerFile(playerName) instead of getPlayerFile(config))
  • Scrap the getPlayerConfig() from line 20, second snippet
  • Call .save(File) on the config object from the parameters

 

fireblast709 Thank you, so so much! I created a set and addDefault with the save method IN them, and now everything works perfect.

fireblast709 Now I can't get objects from the config. T_T why?
Main.getInstance().getPlayerConfig(player).getString("loadout."+nautName); returns null

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

NonameSL Don't forget to save the YamlConfiguration after you have edited the YamlConfiguration.

 

fireblast709 I am, the writing part works fine, and the config shows what I write into it. The problem is in getting the text.

 

NonameSL Well in the YamlConfiguration object that getPlayerConfig() returns, "loadout."+nautName does not exist. Does it exist in the file you saved?

 

fireblast709 Well, actually I already fixed the problem, apparently I was saving with nornal-case and getting with lowercase. Thanks tho!