Solved Can't reopen inventory |Listener already litening

Hi guys, I'm trying really hard to figure out a solution for this:
Basically, I'm trying to reopen an inventory, after an anvil inventory was shown (to get text input).
The stacktrace is really short but I can't figure out what's the problem. I allready schedule the openInventory because it is called in the InventoryCloseEvent

Code:

[19:14:32 WARN]: [GameDesigner] Task #4 for GameDesigner v0.0.1 generated an exc
eption
java.lang.IllegalArgumentException: Listener already listening
        at net.minecraft.server.v1_8_R3.Container.addSlotListener(Container.java
:55) ~[craftbukkit1.8.8.jar:git-Bukkit-880a532]
        at net.minecraft.server.v1_8_R3.ContainerAnvil.addSlotListener(Container
Anvil.java:308) ~[craftbukkit1.8.8.jar:git-Bukkit-880a532]
        at org.bukkit.craftbukkit.v1_8_R3.entity.CraftHumanEntity.openInventory(
CraftHumanEntity.java:340) ~[craftbukkit1.8.8.jar:git-Bukkit-880a532]
        at tk.mctechniclp.gamedesigner.gui.popupguis.PopupGUI$1.run(PopupGUI.jav
a:32) ~[?:?]
        at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftTask.run(CraftTask.java
:53) ~[craftbukkit1.8.8.jar:git-Bukkit-880a532]
        at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftScheduler.mainThreadHea
rtbeat(CraftScheduler.java:349) [craftbukkit1.8.8.jar:git-Bukkit-880a532]
        at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:6
79) [craftbukkit1.8.8.jar:git-Bukkit-880a532]
        at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:3
35) [craftbukkit1.8.8.jar:git-Bukkit-880a532]
        at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:6
28) [craftbukkit1.8.8.jar:git-Bukkit-880a532]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java
:536) [craftbukkit1.8.8.jar:git-Bukkit-880a532]
        at java.lang.Thread.run(Unknown Source) [?:1.7.0_65]

Code in dark syntax highlighting (open) Code in dark syntax highlighting (close)

Code:java

private InventoryView previous;
 
    public PopupGUI(Player p, String title) {
        super(p, title);
        previous = p.getOpenInventory();
    }
 
    @Override
    protected void show(Player p, String title) {
        if(previous != null) previous.close();
        view = p.openInventory(initInventory(title));
    }
 
    @Override
    public void handleClose() {
        super.handleClose();
        if(previous == null) return;
 
        Main.instance.getServer().getScheduler().scheduleSyncDelayedTask(Main.instance, new Runnable() {
 
            @Override
            public void run() {
                previous.getPlayer().openInventory(previous); //<--- Error appears here
            }
        }, 20L);
    }

Here are my listeners

Code:java

    @EventHandler
    public void onClick(InventoryClickEvent ev) {
        for(GUI gui : new ArrayList<GUI>(guis)) {
            if(!ev.getInventory().equals(gui.getInventory())) continue;
            gui.onClick(ev);
            ev.setCancelled(true);
        }
    }
 
    @EventHandler
    public void onClose(InventoryCloseEvent ev) {
        System.out.println("fired");
        for(GUI gui : new ArrayList<GUI>(guis)) {
            if(ev.getInventory().equals(gui.getInventory())) {
                gui.handleClose();
            }
        }
    }

That's how the previous inventory is created

Code:java

    @Override
    public Inventory initInventory(String title) {
        Inventory inv = Bukkit.createInventory(null, 27, title);
        return inv;
    }

And here the one which is open

Code:java

        @Override
    protected void show(Player pl, String title) {
        EntityPlayer p = ((CraftPlayer) pl).getHandle();
 
        AnvilContainer container = new AnvilContainer(p);
 
        view = container.getBukkitView();
        ItemStack is = new ItemStack(Material.STAINED_GLASS_PANE, 1, (short) 5);
        ItemMeta im = is.getItemMeta();
        im.setDisplayName(value);
        is.setItemMeta(im);
 
        view.getTopInventory().setItem(0, is);
 
 
        int c = p.nextContainerCounter();
        p.playerConnection.sendPacket(new PacketPlayOutOpenWindow(c, "minecraft:anvil", new ChatMessage("Repairing"), 0));
 
        p.activeContainer = container;
        p.activeContainer.windowId = c;
 
        p.activeContainer.addSlotListener(p);
    }
 
private class AnvilContainer extends ContainerAnvil {
        public AnvilContainer(EntityHuman entity) {
            super(entity.inventory, entity.world, new BlockPosition(0, 0, 0), entity);
        }
 
        @Override
        public boolean a(EntityHuman entityhuman) {
            return true;
        }
    }

Code in light syntax highlighting (open) Code in light syntax highlighting (close)

Code:

private InventoryView previous;

    public PopupGUI(Player p, String title) {
        super(p, title);
        previous = p.getOpenInventory();
    }

    @Override
    protected void show(Player p, String title) {
        if(previous != null) previous.close();
        view = p.openInventory(initInventory(title));
    }

    @Override
    public void handleClose() {
        super.handleClose();
        if(previous == null) return;
   
        Main.instance.getServer().getScheduler().scheduleSyncDelayedTask(Main.instance, new Runnable() {
       
            @Override
            public void run() {
                previous.getPlayer().openInventory(previous); //<--- Error appears here
            }
        }, 20L);
    }

Here are my listeners

Code:

    @EventHandler
    public void onClick(InventoryClickEvent ev) {
        for(GUI gui : new ArrayList<GUI>(guis)) {
            if(!ev.getInventory().equals(gui.getInventory())) continue;
            gui.onClick(ev);
            ev.setCancelled(true);
        }
    }

    @EventHandler
    public void onClose(InventoryCloseEvent ev) {
        System.out.println("fired");
        for(GUI gui : new ArrayList<GUI>(guis)) {
            if(ev.getInventory().equals(gui.getInventory())) {
                gui.handleClose();
            }
        }
    }

That's how the previous inventory is created

Code:

    @Override
    public Inventory initInventory(String title) {
        Inventory inv = Bukkit.createInventory(null, 27, title);
        return inv;
    }

And here the one which is open

Code:

        @Override
    protected void show(Player pl, String title) {
        EntityPlayer p = ((CraftPlayer) pl).getHandle();

        AnvilContainer container = new AnvilContainer(p);
       
        view = container.getBukkitView();
        ItemStack is = new ItemStack(Material.STAINED_GLASS_PANE, 1, (short) 5);
        ItemMeta im = is.getItemMeta();
        im.setDisplayName(value);
        is.setItemMeta(im);
       
        view.getTopInventory().setItem(0, is);
       
       
        int c = p.nextContainerCounter();
        p.playerConnection.sendPacket(new PacketPlayOutOpenWindow(c, "minecraft:anvil", new ChatMessage("Repairing"), 0));
       
        p.activeContainer = container;
        p.activeContainer.windowId = c;
       
        p.activeContainer.addSlotListener(p);
    }

private class AnvilContainer extends ContainerAnvil {
        public AnvilContainer(EntityHuman entity) {
            super(entity.inventory, entity.world, new BlockPosition(0, 0, 0), entity);
        }

        @Override
        public boolean a(EntityHuman entityhuman) {
            return true;
        }
    }

Thanks in advance for any help

 

You most likely registered the same class twice.

 

That's not possible, im registering the listeners in the onEnable() part. I think it's an internal listener

Code:java

    public static Main instance;
 
    @Override
    public void onEnable() {
        instance = this;
        registerListeners();
    }
 
    private void registerListeners() {
        Bukkit.getPluginManager().registerEvents(new VillagerListener(), this);
        Bukkit.getPluginManager().registerEvents(new GUIManager(), this);
    }

 

This looks like you have a sub class inside the PopupGUI class. Post line 32 of PopupGUI/ post the subclass inside PopupGUI.

 

PopupGUI has no subclass and line 32 is where I made the comment

Code:java

//<--- Error appears here

in the first code I posted

 

@harry_potter4567
I highly doubt the server made a mistake.

The $1 at the end of PopupGUI means that you have a subclass inside PopupGUI, and line 32 means the 32 line of that subclass. Please post the run method that is inside PopupGUI's subclass.

 

@Zombie_Striker
The subclass is the runnable. At least I would think so.

Code:

new Runnable() {
  @Override
  public void run() {
     previous.getPlayer().openInventory(previous); //<--- Error appears here
  }
}

Doesn't that create an anonymous inner class?

@harry_potter4567 Sad you won't get the alert, but whatever. Have you tried saving the Inventory and not the InventoryView? And then opening the Inventory and not the InventoryView? Seems like the InventoryView already contains the player. You can find the error here, also I don't know what to do with it. It seems like opening the Inventory adds a Listener to the InventoryView, which won't get cleared. Later you try to open it again, creating the second similar Listener which throws the error. Just speculating at this point though. Not sure ==> Smaller font

 

What is previous?

 

Nice idea, Im gonna give this a try

previous is an InventoryView that I saved to reopen the Inventory later

EDIT: I expected like thousands more errors when this one is fixed but... IT JUST WORKS NOW
I <3 u @I Al Istannen . Also thanks to @Zombie_Striker and @DoggyCode™ for trying to help <3



EDIT by Moderator: merged posts, please use the edit button instead of double posting.