Solved Cancelling ASync Task

So I've been trying to get this to work for quite a while. I've searched the Bukkit Forums multiple times on how to cancel these tasks but I can't get it to work.

Here's my code:

Code:java

 
    private static int goldBoots;
 
    @EventHandler(priority = EventPriority.MONITOR)
    public void goldBoots(InventoryCloseEvent event){
        final Player player = (Player) event.getPlayer();
        final ItemStack boots = player.getInventory().getBoots();
        PotionEffectType jumpEffectType = PotionEffectType.JUMP;
        final PotionEffect jumpEffect = new PotionEffect(jumpEffectType, 100, 1);
        goldBoots = getServer().getScheduler().scheduleAsyncRepeatingTask(this, new Runnable(){
            public void run(){
                if(boots != null){
                    if(boots.getType() == Material.GOLD_BOOTS){
                        getServer().broadcastMessage("Start");
                        player.addPotionEffect(jumpEffect, true);
                    }else{
                        getServer().broadcastMessage("Stop");
                        Bukkit.getScheduler().cancelTask(goldBoots);
                    }
                }else{
                    getServer().broadcastMessage("Stop");
                    Bukkit.getServer().getScheduler().cancelTask(goldBoots);
                }
            }
        }, 0L, 60L);
    }
 

I've put in debug messages so I know what's going on. Once I put on gold boots the loop runs and continuously sends the "Start" message. When I take off the gold boots it successfully triggers the "Stop" message but at the same time the "Start" message just keeps running. If anyone can help me solve this I'd greatly appreciate it.

Thanks.

 

Use a BukkitRunnable. Also, you shouldn't be using "Async."

 

So I changed Runnable to BukkitRunnable and Async to Sync, same thing still happens.

I only used an Async task because that's what was in the example on the wiki. I'm a visual learner, so I often don't take in everything I read, so from the example pieces of code on the wiki I thought that you use Sync for a scheduled task and Async for a repeating task. Now that I read the wiki properly I see my mistake, and I feel a bit stupid for making it. But did the Async task really have to be deprecated? I feel like I caused it, and that others will hate me for it.

 

What are you talking about? He means dont use Async because you're trying to use methods which are not thread safe.

 

https://github.com/Bukkit/Bukkit/commit/d9dc8fce62f54871c1e62dedccf721b0cccbad10

 

What the hell wiki page did you look at, so I can remove it. (also, it was deprecated because it's not needed and causes confusion)

 

http://wiki.bukkit.org/Scheduler_Programming
The wiki is fine, I just didn't read properly.

 

Interesting.

 

Anyway can we go back on topic? Why isn't my SyncRepeatingTask stopping once I take off the gold boots?

Code:java

 
    private static int goldBoots;
 
    @EventHandler(priority = EventPriority.MONITOR)
    public void goldBoots(InventoryCloseEvent event){
        final Player player = (Player) event.getPlayer();
        final ItemStack boots = player.getInventory().getBoots();
        PotionEffectType jumpEffectType = PotionEffectType.JUMP;
        final PotionEffect jumpEffect = new PotionEffect(jumpEffectType, 100, 1);
        goldBoots = getServer().getScheduler().scheduleSyncRepeatingTask(this, new BukkitRunnable(){
            public void run(){
                if(boots != null){
                    if(boots.getType() == Material.GOLD_BOOTS){
                        getServer().broadcastMessage("Start");
                        player.addPotionEffect(jumpEffect, true);
                    }else{
                        getServer().broadcastMessage("Stop");
                        Bukkit.getScheduler().cancelTask(goldBoots);
                    }
                }else{
                    getServer().broadcastMessage("Stop");
                    Bukkit.getServer().getScheduler().cancelTask(goldBoots);
                }
            }
        }, 0L, 60L);
    }
 

 

Because boots will never be null. You're not updating the reference to the player's boots.

 

Oh I see, it works now. Thank you.

 

On another note, the practice should be simply making a BukkitRunnable, and calling one of its methods to schedule it. If you use the designated methods, it lets you call this.cancel() from inside of itself.

 

Since when is BukkitRunnable implemented?