Solved Cancel playerdropitemevent?

So this code doesn't work right now, I have all my events registered and I have a listener.

No errors too.

Code:java

    @EventHandler
    public void onItemDrop(PlayerDropItemEvent e){
        Player p = e.getPlayer();
        ItemStack item = e.getItemDrop().getItemStack().clone();
        if(p.getItemInHand().hasItemMeta()) {
            if(p.getItemInHand().getItemMeta().hasDisplayName()) {
                String name = e.getItemDrop().getItemStack().getItemMeta().getDisplayName(); 
 
            if(name.equalsIgnoreCase(ChatColor.GRAY + "MainMenuWindnow")) {
        p.getInventory().addItem(item);
        e.setCancelled(true);
            }
        }
        }
 
        }

 

Where is the error, specify line #('s)

 

There are no errors.

Just isn't working.

Glitchy while cancelling I guess?

 

From Adamqpzm:

 

I'v seen some servers when they actually cancel out the drop...

And how would PlayerMoveEvent affect the inventory?

 

Tell me how you end up solving it; I need to cancel this event soon.

PlayerMoveEvent was just the context, it has nothing to do with the inventory.
Anyhow, try testing it with an updateInventory().

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bobit shohouku
You could always just removed the dropped entity, then add the item back in their inventory. At least for me, cancelling the event works fine o_0

EDIT: Or, you can use ItemSpawnEvent

 

I'v tried updating the player inventory doesn't work, tried cancelling the drop event (I'm using craft bukkit 1.7.9 and BUkkit 1.7.9) and I've tried putting the item back in the players inventory and that doesn't work..

I have all my events registered and I have listeners.

 

Bobit PlayerDropItem is actually fine for cancellation from what I've seen of it. It's also not technically an inventory event, so maybe that's why

shohouku I noticed you've marked this as solved but haven't posted a solution; did you solve it or has it been mismarked? Either way, I would've recommended checking against item rather than getItemInHand

 

My new code, it works but very buggy.

Code:java

 
        @EventHandler
        public void onItemDrop(PlayerDropItemEvent e){
            Player p = e.getPlayer();     
            String name = e.getItemDrop().getItemStack().getItemMeta().getDisplayName();
            if(e.getItemDrop().getItemStack().hasItemMeta()) {
                if(e.getItemDrop().getItemStack().getItemMeta().hasDisplayName()) {
 
 
                if(name.equalsIgnoreCase(ChatColor.GRAY + "MainMenuWindow")) {
 
            e.setCancelled(true);
            p.sendMessage("test");
 
                }
                }
                }
 
 
 
 
 
 
 
    }
 
 
        @EventHandler
        public void onInventoryDrag(InventoryDragEvent event) {
 
        event.setCancelled(true);
        System.out.println(10);
        }
 
 
        @EventHandler
        public void onInventoryDrag(InventoryInteractEvent event) {
            for(Player p : Bukkit.getOnlinePlayers()){ 
                String name = p.getItemInHand().getItemMeta().getDisplayName();
                if(p.getItemInHand().getItemMeta().hasDisplayName()) {
                    if(p.getItemInHand().hasItemMeta()) {
                if(name.equalsIgnoreCase(ChatColor.GRAY + "MainMenuWindow")) {
            event.setCancelled(true);
            System.out.println(1);
 
            }
            }
            }
            }
 
 
}
 
    @EventHandler
    public void onClickInventory(InventoryClickEvent event){
 
        for(Player p : Bukkit.getOnlinePlayers()){ 
            String name = p.getItemInHand().getItemMeta().getDisplayName();
            System.out.println(name);
            if(p.getItemInHand().getItemMeta().hasDisplayName()) {
                if(p.getItemInHand().hasItemMeta()) {
            if(name.equalsIgnoreCase(ChatColor.GRAY + "MainMenuWindow")) {
        event.setCancelled(true);
        System.out.println(1);
        }
        }
        }
        }
    }
 

 

shohouku You get the display name before checking if it has item meta

 

Would it matter?

I'm pretty sure it wouldn't make a difference..but I'll just double check.

EDIT:

Btw I'm cancelling the PlayerDropItemEvent

And it's going to the first slot? I'm assuming that shouldn't be happening?

I'm guessing I'm going to have to set the slot when the player tries to drop it.

 

shohouku Yes. It'll throw an NPE if the dropped item doesn't have any item meta.