BukkitRunnable help

Show Spoiler Hide Spoiler

Code:java

if (commandLabel.equalsIgnoreCase("arrow") && args.length == 2)
{
try{
final Player p1 = p;
final Location loc = p1.getLocation();
loc.add(0, 1, 0);
final int time = Integer.parseInt(args[0]);
final int times = Integer.parseInt(args[1]);
Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new BukkitRunnable() {
public void run()
{
int t1 = times;
if (t1 > 0)
{
Arrow arrow = p1.getWorld().spawn(loc, Arrow.class);
arrow.setShooter(p1);
t1--;
}else
{
this.cancel();
}
}
},time * 20, 0);
}catch(NullPointerException e)
{
p.sendMessage(e.getMessage());
}
}else if (commandLabel.equalsIgnoreCase("arrow") && args.length != 2)
{
p.sendMessage(ChatColor.GOLD + "Usage: " + ChatColor.YELLOW + "/arrow + " + ChatColor.RED + "<time interval between shots> <amount of shots>");
}

So basically, when you do '/arrow 5 10', it shoots an arrow where the player is looking every 5 seconds 10 times. If the amount of times an arrow was shot is down to 0, it cancels.

Well, that code shoots an arrow about every tick when I do /arrow 1 10, and it won't cancel.

Could someone tell me what I'm doing wrong so I'll know how to do this in the future? I know some of the code in the actual run method is messed up; I didn't really get a chance to test it. But I just need to figure out why it won't cancel and why it shoots an arrow every tick.

Thank you in advance

 

You messed up the arguments of the scheduling part. The time*20 is at the spot of the delay (time before it starts) whereas the 0 is the interval between repetitions.

 

That worked, but now I need to figure out why it isn't cancelling.

 

it doesn't cancle, because each time the task is executed, it calls the run() method.

Each time, you call this method, t1 is initialised and set to times, which is always 10. So it is always > 0. That's why the task is not cancelled.

 

Yeah, I just figured that out. I can't think of any way to fix it though.

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ocomobock As minoneer explained, the scope of your t1 must exist outside of your method, or it will be reset every time the method is executed.

 

Why didn't I notice thaaaaaaaat

Somehow I had it in my head that the only thing that was allowed in BukkitRunnable was the run method and I didn't think about actually creating variables outside of the run method while still in the class.

why don't I notice these things ._.

thank you I guess