Best way to solve this?

You will hear some background noise and yes my name is Harris. Please don't focus on that though.

 

22vortex22 Can you post just the link? I can't see the video. It's just a white square.

 

Code please? Stacktrace?

 

Code:java

package com.gmail.codervortex;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityDamageEvent;
import org.bukkit.event.entity.EntityDamageEvent.DamageCause;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerMoveEvent;
 
public class Events implements Listener{
    public Main plugin;
    public Events(Main instance){   
        plugin = instance;
    }
 
 
    @EventHandler(priority = EventPriority.HIGH)
    public void onFallDamage(EntityDamageEvent event){
        if(event.getEntity() instanceof Player && event.getCause() == DamageCause.FALL)
            event.setCancelled(true);
    }   
 
 
 
 
    @EventHandler
    public void OnPlayerRocket(PlayerInteractEvent event){
        Player player = event.getPlayer();
        if(player.getExp() == 1f){
            if((event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() ==Action.RIGHT_CLICK_BLOCK) && player.getItemInHand().getType() == Material.FIREWORK){
                player.setVelocity(player.getLocation().getDirection()
                        .multiply(1.05).setY(1.15));
                player.setExp(0.50F);
                plugin.RocketCooldown2.add(player.getName());
            }
        }
        else if(plugin.RocketCooldown2.contains(player.getName()) && player.getExp() == 0.5f){
                if((event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() ==Action.RIGHT_CLICK_BLOCK) && player.getItemInHand().getType() == Material.FIREWORK){
                    player.setVelocity(player.getLocation().getDirection()
                            .multiply(1.05).setY(1.15));
                    player.setExp(0);
                }
        }
 
    }
    int time;
    @EventHandler
    public void OnGround(PlayerMoveEvent e){
        final Player p = e.getPlayer();
        Bukkit.getServer().getScheduler().runTaskLater(plugin, new Runnable()
        {
            @Override
            public void run(){
                if(p.getLocation().add(0,-1,0).getBlock().getType() != Material.AIR){           
                    p.setExp(1);
                }
            }
        }
                ,3L);
 
 
    }
 
    @EventHandler
    public void OnPlayerJoin(PlayerJoinEvent event){
        Player player = event.getPlayer();
        event.setJoinMessage(ChatColor.GOLD + "Hello " + player.getName() + ". Welcome to Minecraft Smash!");
    }
 
 
 
 
 
 
 
 
 
}
 

Cant believe I forgot about that.

Code:

http://www.youtube.com/watch?v=F9uNDQqjhnw&feature=youtu.be

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

22vortex22 You're probably being added to the arraylist more than one time, or not removed correctly.

 

That shouldn't happen... Im pretty sure it has something do with when they are on the ground but I really need help on this.

 

22vortex22 Code?


Also, [offtopic] are you trying to remake the thing from your smash video? :3 [/offtopic]

 

Yes.

 

22vortex22 Are you interested in getting help? looks like fun (pm me if yes)

And is there code so that I can help fix this?

 

Code:java

    @EventHandler
    public void OnPlayerRocket(PlayerInteractEvent event){
        Player player = event.getPlayer();
        if(player.getExp() == 1f){
            if((event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() ==Action.RIGHT_CLICK_BLOCK) && player.getItemInHand().getType() == Material.FIREWORK){
                player.setVelocity(player.getLocation().getDirection()
                        .multiply(1.05).setY(1.15));
                player.setExp(0.50F);
                plugin.RocketCooldown2.add(player.getName());
            }
        }
        else if(plugin.RocketCooldown2.contains(player.getName()) && player.getExp() == 0.5f){
                if((event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() ==Action.RIGHT_CLICK_BLOCK) && player.getItemInHand().getType() == Material.FIREWORK){
                    player.setVelocity(player.getLocation().getDirection()
                            .multiply(1.05).setY(1.15));
                    player.setExp(0);
                }
        }
 
    }
    int time;
    @EventHandler
    public void OnGround(PlayerMoveEvent e){
        final Player p = e.getPlayer();
        Bukkit.getServer().getScheduler().runTaskLater(plugin, new Runnable()
        {
            @Override
            public void run(){
                if(p.getLocation().add(0,-1,0).getBlock().getType() != Material.AIR){           
                    p.setExp(1);
                }
            }
        }
                ,3L);
 
 
    }

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I think the problem here is a favorite rant of mine.

Implementing cooldowns with timers is the wrong way to implement cooldowns. Rather than re-rant, I'll just link:

http://forums.bukkit.org/threads/simple-question-cooldown-for-commands.192037/#post-197551

The short answer is using timers for cooldowns is inefficient and broken, and could likely cause the weird behavior you're seeing. The end effect is that the actual cooldown time ends up being random, ranging from nearly 0 to whatever cooldown time you're actually trying to set.

A simple and effective way to properly implement cooldowns is to store the last time each player used the command. Then just check to see if that timestamp is older than X seconds ago, if so allow the command and update the timestamp. No need for schedulers, timers- and it actually works right

You may have other problems there, but I'm thinking the cooldowns are going to be an issue.

 

I agree I think the cooldown is the problem. You're explanation is great but how would I apply it to this? I'm trying to make it so when they land on the ground it gives them the xp bar back. There is no exact cooldown. Would your code you gave for that post work for this?

NathanWolf

 

Hm- ok, sorry, taking a closer look I think that rant was unnecessary

I'm still not really clear, but I think I may see a couple of problems:

1. You never remove a player from the cooldown map- I assumed this was happening in the scheduled task when I made my rant, but I should've looked closer. Did you mean to remove them in the "else if" section? Otherwise it seems like the first part will only ever happen once.

2. Scheduling a task every single time every player moves seems crazy Is there an issue with just giving them the XP directly in the move event? Or, perhaps a better approach, schedule a repeating task and loop through all players, giving them XP if they're on the ground? (Unless you mean it to only happen when they move- but keep in mind you get a LOT of move events!)

3. I can imagine that the 3-tick delay on the move timer will interfere with what the onInteract is doing- let's say:
- you're moving, it's going to set your XP to 1 in 3 ticks
- you rocket, which tries to set your XP to 0
- Depending on timing the two above things might be racing each other.

I think svgaster has a better idea of what you're trying to do than me

 

You seem to know alot about what you are talking about but I really have no idea do to any of the stuff you said. I just want it to be when they hit the ground they get their xp back so they can take off again. However I think when they launch it gives it back to them because it doesnt give them enough time to get off the ground. NathanWolf sgavster

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Looks like you have an arraylist, but you never actually remove the player from it when he hits the ground?
That probably gives you extra jumps :s