Solved ArrayIndexOutOfBoundsException: -1

Code:java

  public void BrisiQuartz(PlayerInteractEvent e){
 int amountToRemove = 1;
 Player p = e.getPlayer();
   if(e.getAction().equals(Action.RIGHT_CLICK_AIR) || e.getAction().equals(Action.RIGHT_CLICK_BLOCK)) 
   if(checkForAmount(new ArrayList<ItemStack>(p.getInventory().all(Material.QUARTZ).values()), 40)){
   }
           while(amountToRemove > 0) {
               int first = p.getInventory().first(Material.QUARTZ);
               ItemStack stack = p.getInventory().getItem(first);
               if(stack.getAmount() > amountToRemove){
                   stack.setAmount(stack.getAmount() - amountToRemove);
                   amountToRemove = 0;
               } else {
                   amountToRemove -= stack.getAmount();
                   p.getInventory().remove(stack);
               }
           }
}

Code:text

Could not pass event PlayerInteractEvent to Brogan v2.1
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredListener.java:30)
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:478)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:463)
at org.bukkit.craftbukkit.v1_6_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:208)
at net.minecraft.server.v1_6_R1.PlayerInteractManager.interact(PlayerInteractManager.java:374)
at net.minecraft.server.v1_6_R1.PlayerConnection.a(PlayerConnection.java:649)
at net.minecraft.server.v1_6_R1.Packet15Place.handle(SourceFile:58)
at net.minecraft.server.v1_6_R1.NetworkManager.b(NetworkManager.java:293)
at net.minecraft.server.v1_6_R1.PlayerConnection.d(PlayerConnection.java:118)
at net.minecraft.server.v1_6_R1.ServerConnection.b(SourceFile:37)
at net.minecraft.server.v1_6_R1.DedicatedServerConnection.b(SourceFile:30)
at net.minecraft.server.v1_6_R1.MinecraftServer.t(MinecraftServer.java:592)
at net.minecraft.server.v1_6_R1.DedicatedServer.t(DedicatedServer.java:239)
at net.minecraft.server.v1_6_R1.MinecraftServer.s(MinecraftServer.java:481)
at net.minecraft.server.v1_6_R1.MinecraftServer.run(MinecraftServer.java:413)
at net.minecraft.server.v1_6_R1.ThreadServerApplication.run(SourceFile:582)
 
Caused by: java.lang.ArrayIndexOutOfBoundsException

Code:java

private boolean checkForAmount(ArrayList<? extends ItemStack> items, int amount){
        for(ItemStack i : items)
                amount -= i.getAmount();
        if(amount <= 0)
              return true;
        return false;

Why do I get it and how to fix it?

Ugh, anyone?

Didn't manage to fix it...
The code executes fine and works tho.

I somehow need to get rid of

1. ItemStack stack = p.getInventory().getItem(first);

because it gives me this error.

Any ideas?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

euro1988
Does ItemStack stack = p.first(Item) return -1 if it's not found? If so just do a check to see if it's -1 and break.
http://jd.bukkit.org/rb/doxygen/d3/...entory.html#ab10f1fe25ab8fd977052fdc714d904da

 

Sessional

Yeah, it does return -1. How do I break it, with return?

 

euro1988
It's in a loop so break; or return; would work, or even continue - but if you need continue chances are you'll get stuck in an infinite loop if you aren't careful.

 

Sessional
Uh, is there any other safer way to remove the ItemStack one by one then?

 

euro1988
You can get by with a break or a return statement if you want, if you want some help formulating a safe loop, go ahead and explain exactly what your loop is attempting to do and I'll help ya out.

 

Sessional
It checks if player who right clicks with nether quartz has any of the item left, then if he has, it removes one nether quartz with each right click. When there's none , it should stop removing.

 

euro1988
So placing the block also removes an extra block from the inventory?

Code:

ItemStack[] items = player.getInventory().getContents();
 
for (ItemStack i : items)
{
  if (i.getType() == Material.NetherQuartz)
  {
    if (i.getAmount() > 1)
    {
        i.setamount(i.getAmount() - 1);
        break;
    }
  }
}

With this code you will loop through ALL the slots, and if there is a netherquartz item stack with an amount > 1 it'll remove it. This will have flaws, because if it's in the inventory and they aren't placing it it won't remove a stack higher then one, but that's easy enough to fix by checking the stack in the players hand first. As a note: these events are called BEFORE the block is actually placed - you may not want to remove the block that is getting placed, it might cause issues.

 

Sessional

Works flawlessly, thanks a lot.

Fixed

Code:java

 @EventHandler
public void deletequartz(PlayerInteractEvent e) {
Player player = e.getPlayer();
if (player.getItemInHand().getType().equals(Material.QUARTZ)) {
if(e.getAction().equals(Action.RIGHT_CLICK_AIR) || e.getAction().equals(Action.RIGHT_CLICK_BLOCK)) {
ItemStack[] items = player.getInventory().getContents();
 
for (ItemStack i : items)
{
if (i.getType() == Material.QUARTZ)
{
if (i.getAmount() > 1)
{
i.setAmount(i.getAmount() - 1);
} else {
e.getPlayer().getInventory().setItemInHand(new ItemStack(Material.AIR, 0));
}
break;
}
}
}
}
}
 

Figured it out, posted code if anyone needs it

EDIT by Moderator: merged posts, please use the edit button instead of double posting.