Solved EntityDeathEvent error

Hello !

I have an error with that code (Player killer = e.getEntity().getKiller(); ) : https://pastebin.com/raw/LYwqu5hG

I already tried to cast to Player, to change method to detect the killer (Player killer = (Player) e.getEntity().getLastDamageCause().getEntity(); ). Nothing to do, I have an error...

Thanks for ur help

 

@Aragone What is the error? I'm guessing 'getKiller()' returns null.

 

Oh yes sorry, I've forgotten to give it to you.



Yes it returns null

 

@Aragone You can't use variable that's null, make a null check before using it.

 

@KarimAKL Yes but when I test the code the variable musn't be null.

I don't understand. If I kill the armorstand, I'm a player so the variable musn't be null.

 

@Aragone How did you kill the entity? Are you sure that's the line causing the error? The error says it's line 141, but your code only shows 16 lines.

 

@KarimAKL I kill the entity with left-clicking, with my hand.

Complete code : https://pastebin.com/raw/fmcCm790

 

@Aragone In the pastebin it seems line 141 is this:

Code:Java

if(target.hasArms() == true) {

If that's truly line 141 then 'target' is null, but i don't think e.getEntity() returns null at any time, so maybe pastebin has formatted your code wrong or something?

 

Sorry that's because I do some test and so changes.

that's the good code : https://pastebin.com/raw/63TLKt88

Console :

So the error is the checking gamemode @KarimAKL

 

@Aragone Try adding something like this before you check the gamemode:

Code:Java

if (killer == null) {
    System.out.println("killer is null");
    return;
} else System.out.println("killer is not null");

 

@KarimAKL It returns player is null. I suspected it. That's very strange I tried a lot of ways to get the player but there is nothing to do.

 

@Aragone I'm not sure if this gives the same result but have you tried this?

Code:Java

EntityDamageEvent event = e.getEntity().getLastDamageCause();
if (!(event instanceof EntityDamageByEntityEvent)) return;
EntityDamageByEntityEvent ev = (EntityDamageByEntityEvent) event;
if (!(ev.getDamager() instanceof Player)) return;
Player killer = (Player) ev.getDamager();

 

@KarimAKL It runs, Thanks but that's crazy. I really don't understand why this method was not running well. Maybe it's deprecated.

 

@Aragone If you don't understand the code, then i'll try explaining it.

Explanation (open) Explanation (close)

Code:Java

EntityDamageEvent event = e.getEntity().getLastDamageCause();

Here we get the entity from the EntityDeathEvent and then get it's last damage cause. (the damage that caused it's death)

Code:Java

if (!(event instanceof EntityDamageByEntityEvent)) return;

We then check if the EntityDamageEvent gotten from the last damage cause is an instanceof EntityDamageByEntityEvent, we can do this because EntityDamageByEntityEvent extends EntityDamageEvent.
We don't care about the damage if it wasn't caused by an entity (player).

Code:Java

EntityDamageByEntityEvent ev = (EntityDamageByEntityEvent) event;

Now we know that the event is an instanceof EntityDamageByEntityEvent, so we cast it to that so we can use it's methods. (it's only method is 'getDamager()', the rest is inherited from EntityDamageEvent)

Code:Java

if (!(ev.getDamager() instanceof Player)) return;

Again, we don't care if the damage wasn't caused by a player.

Code:Java

Player killer = (Player) ev.getDamager();

Now we can be sure that the damage was caused by a player, so we cast the Entity gotten from 'getDamager()' to a Player. That's it, now you've gotten the player.

Anyway, i'm glad it worked for you.

 

Thank you very much you're a very good guy @KarimAKL