Problem with PlayerItemBreakEvent

Hey there,

Let me explain my problem. Basically i want to Auto-Equip tools after they break if there is another tool with the same material.

My Code only works when the tool breaks from destroying blocks not from hitting any entities.

If the tool breaks from hitting an Entity it disappears and the other tool that has the same material as well, instead of replacing it.

Btw there's no error Code, when the event triggers!

Heres my code:

Code:java

@EventHandler
    public void onItemBreak(PlayerItemBreakEvent e) {
        Player p = e.getPlayer();
        ItemStack item = e.getBrokenItem();
        ArrayList<ItemStack> store = new ArrayList<ItemStack>();
 
        store.add(item);
 
        if (store.get(0).equals(p.getInventory().getItemInOffHand())) {
            //
        } else if (store.get(0).equals(p.getInventory().getHelmet())) {
            for (int i = 0; i <= p.getInventory().getSize(); i++) {
                ItemStack invitem = p.getInventory().getItem(i);
 
                if (invitem != null) {
                    if (invitem.getType().equals(store.get(0).getType())) {
                        p.getInventory().remove(invitem);
                        p.getInventory().setHelmet(invitem);
                        store.remove(0);
 
                        break;
                    }
                }
            }
        } else if (store.get(0).equals(p.getInventory().getChestplate())) {
            for (int i = 0; i <= p.getInventory().getSize(); i++) {
                ItemStack invitem = p.getInventory().getItem(i);
 
                if (invitem != null) {
                    if (invitem.getType().equals(store.get(0).getType())) {
                        p.getInventory().remove(invitem);
                        p.getInventory().setChestplate(invitem);
                        store.remove(0);
 
                        break;
                    }
                }
            }
        } else if (store.get(0).equals(p.getInventory().getLeggings())) {
            for (int i = 0; i <= p.getInventory().getSize(); i++) {
                ItemStack invitem = p.getInventory().getItem(i);
 
                if (invitem != null) {
                    if (invitem.getType().equals(store.get(0).getType())) {
                        p.getInventory().remove(invitem);
                        p.getInventory().setLeggings(invitem);
                        store.remove(0);
 
                        break;
                    }
                }
            }
        } else if (store.get(0).equals(p.getInventory().getBoots())) {
            for (int i = 0; i <= p.getInventory().getSize(); i++) {
                ItemStack invitem = p.getInventory().getItem(i);
 
                if (invitem != null) {
                    if (invitem.getType().equals(store.get(0).getType())) {
                        p.getInventory().remove(invitem);
                        p.getInventory().setBoots(invitem);
                        store.remove(0);
 
                        break;
                    }
                }
            }
        } else {
 
            int slot = 0;
 
            for (int i = 0; i <= p.getInventory().getSize(); i++) {
                ItemStack newitem = p.getInventory().getItem(i);
 
                if (newitem != null) {
                    if (newitem.equals(store.get(0))) {
                        slot = i;
                        break;
                    }
                }
            }
 
            for (int i = 0; i <= p.getInventory().getSize(); i++) {
                ItemStack invitem = p.getInventory().getItem(i);
 
                if (invitem != null && i != slot) {
                    if (invitem.getType().equals(store.get(0).getType())) {
 
                        p.getInventory().remove(invitem);
                        p.getInventory().setItem(slot, invitem);
 
                        store.remove(0);
 
                        break;
                    }
                }
            }
 
        }
    }

 

@FlaveDrake Are you sure the event is called when an item is broken from hitting an entity? I would imagine it is but just in case, you could try printing a message to the console when the event is fired, then test it in-game.
Some things i wanna say:
1. Why do you create the 'store' list just to add 1 item to it when you can just do 'item.equals()' instead of 'store.get(0).equals()'?
2. It shouldn't make difference in the case of enums but it's preferred to use '==' to compare enums instead of '.equals' because of the null safety.
3. You could create a method instead of repeating the same code over and over.

 

@timtower Thanks that made it. Don't know why exactly but it works.

@KarimAKL
1. I don't know why, but when going into that for-loop the broken-item material changes to AIR. (Don't know if it's still so using the new code.)
2. '==' didn't worked out.
3. Yeah, that's true. I'm not into efficient coding yet, sorry.

 

I'm not quite sure what you mean; the material of 'e.getBrokenItem' shouldn't change.

It should, did you compare the materials or the itemstacks? You have to compare the material, so something like this:

Code:Java

item.getType() == otherItem.getType()

No need to apologise, i just told you that's a possibility.

 

@KarimAKL

1. The ArrayList is "useless" in this case. It was a fault when i began to write this code.

2. '==' only works on Material not comparing ItemStacks


3. That's my code now (It works perfectly fine):

Code:java

 
    @EventHandler
    public void onItemBreak(PlayerItemBreakEvent e) {
        Player p = e.getPlayer();
        ItemStack broken = e.getBrokenItem();
        PlayerInventory inv = p.getInventory();
 
        for (int i = 0; i <= p.getInventory().getSize(); i++) {
            ItemStack currentitem = p.getInventory().getItem(i);
 
            if (currentitem != null) {
                if (currentitem.equals(broken)) {
                    slot = i;
                    break;
                }
            }
        }
 
        ItemStack newitem = reequip(p, broken, inv);
 
        inv.remove(newitem);
 
        Bukkit.getServer().getScheduler().runTaskLater(Main.getPlugin(), new Runnable() {
            public void run() {
                if (broken.equals(inv.getItemInOffHand())) {
                    inv.setItemInOffHand(newitem);
                } else if (broken.equals(inv.getHelmet())) {
                    inv.setHelmet(newitem);
                } else if (broken.equals(inv.getChestplate())) {
                    inv.setChestplate(newitem);
                } else if (broken.equals(inv.getLeggings())) {
                    inv.setLeggings(newitem);
                } else if (broken.equals(inv.getBoots())) {
                    inv.setBoots(newitem);
                } else {
                    inv.setItem(slot, newitem);
                }
            }
        }, 2L);
    }
 
    public ItemStack reequip(Player p, ItemStack broken, PlayerInventory inv) {
        ItemStack newitem = null;
 
        for (int i = 0; i <= inv.getSize(); i++) {
            ItemStack currentitem = inv.getItem(i);
 
            if (currentitem != null && i != slot) {
                if (currentitem.getType() == broken.getType()) {
                    newitem = currentitem;
                }
            }
        }
        return newitem;
    }
 

EDIT: slot is a private int in my Listener class.

 

I know, that's what i've been saying. It seems you've changed the enum comparing to '==' instead of '.equals', good.

You aren't using the 'p' variable, you can remove it.