Itemstack is not invincible

Well this is extremely confusing because nothing in this code is working nor any error is showing up.

Code:

@EventHandler
    public void repairItems(EntityDamageByEntityEvent event) {
        if (event.getDamager() instanceof Player) {

            //Try and catch method because different spigot versions
            try {

                ((Player) event.getDamager()).getInventory().getItemInMainHand().setDurability((short)0); //The sword(weapon) which the player uses to pvp will not be broken

            } catch(NoSuchMethodError e){

                ((Player) event.getDamager()).getInventory().getItemInHand().setDurability((short)0); //The sword(weapon) which the player uses to pvp will not be broken
            }

        } else if (event.getEntity() instanceof Player) {

            ItemStack[] armour = ((Player) event.getEntity()).getInventory().getArmorContents(); //Armour which the player is wearing
            for (ItemStack i : armour) {
                i.setDurability((short) 0);
            }
        }
    }

 

@JaySN

1. Have you registered the class as a listener?
2. Does any other events in the class work?
3. Are you sure the damager is a player? Are you sure the entity is a player?

 

1)

yes
2) yes
3)It is supposed to.. isnt it? and how can it not be?

 

Uuuuh some versions ago (not 1.12) i had the problem that items did not update. That took me quiet a while to figure out. Idk in my case i used Inventory#update() but isnt there already something like ItemStack#update() ?

 

@MightyOne
The reason update works is because that updates refreshes all itemstacks in the inventory. It should be deprecated, because you should use setItem if you only need to update one slot.

@JaySN
Just noticed you are only setting the durability of the item. You need to reset the slot in order for the changes to take into effect. Use PlayerInventory#setItem(slot, i); to update the durability.

 

@Zombie_Striker well it was already the right intention

 

@JaySN
an entity can be a player, or a mob.
What will happen if the player hit someone with an empty hand or with a block ?

 

hmm, okay let me see if I have any changes