Solved Sending list to player

Eh, I've tried a bit, and this is the only thing that pops up;
Well, it's being spammed all the time until the server crashes...
What did I do wrong though?

Code;

Code:

if (args.length >= 1 && args[0].equalsIgnoreCase("check")) {
                            if (!sender.hasPermission("glamreports.checknotes")){
                                sender.sendMessage(notePrefix+notesNoPermission);
                        }
                            if (sender.hasPermission("glamreports.checknotes")) {
                                if (args.length == 0 || args.length == 1) {
                                    sender.sendMessage(notePrefix+removeNoteUsage);
                                }
                                if(args.length >= 2){
                                    Player target = Bukkit.getPlayer(args[1]);
                                if (target == null && args.length == 2){
                                    sender.sendMessage(notePrefix+notesPlayerNotFound);
                                }
                                List<String> notes = this.getConfig().getStringList("Note-List."+target+".notes");
                                this.getConfig().set("Note-List", notes);
                                if (target != null && args.length == 2){
                                    sender.sendMessage(notePrefix+noteListHeader.replaceAll("%player%", target.getName()));
                                    if(notes == null){
                                        sender.sendMessage(notePrefix+"§cThis player does not have any notes!");
                                    }
                                    for(int i = notes.size(); i >= 0; ++i){
                                        String IDPrefix = idPrefix.replaceAll("%ID%", String.valueOf(i+1));
                                            for(String gray : notes){
                                        gray.replaceAll("-", ChatColor.DARK_GRAY+"-");
                                        gray.replaceAll(""+Bukkit.getPlayer(gray)+" ", ChatColor.RED+""+Bukkit.getPlayer(gray)+" ");
                                            }
                                        player.sendMessage(idPrefix+((Object[])notes.toArray()));
                                }}}}}}

I know there's a lot of if statements, I'll change that later.

 

@yPedx

• You are still referencing idprefix instead of IDprefix.
• You are just printing out the Instance of the object. What you need to do is print out the values of each string in the list.
• Replaceall does not actually replace the instance. It creates a New instance of the string that has those bits replaced. You need to continually update the gray in the notes list in order for the changes to be applied.

 

@Zombie_Striker
idPrefix has a value at the top of the code, not shown though.
Ehm, I'm kind of new to 'lists'. Any pages you'd recommend looking at?

 

@yPedx
But idPrefix is not the one where you replace the ID. IDPrefix changes %ID% to the actual Id. This is most likely what you meant.

Instead of doing just a replace all, send gray after you are done looping through it. Also, Remove the for int-loop at above the enhanced foreach loop. What that does is loop through the whole list for every object in the list. That is squaring the amount of looped needed.

 

@Zombie_Striker
Ah, I see now. Little typo.

So, remove this,

Code:

for(int i = notes.size(); i >= 0; ++i){

But how would I replace the id?
Example how I tried it to be;

Code:

// In-game chat
// the numbers just means the first note, second etc.. in the list.
// "sender" is the one who added the note.
// "note" is of course the note.

[1] sender - note
[2] sender - note
[3] sender - note
etc..

 

@yPedx
My mistake. If you still need the ID of each string, then remove the string for-each loop. When you need to instantiate "gray", set it equal to notes.get(i);

 

Don't really understand what you're trying to tell me >.<'

@Zombie_Striker
Alright, so I got the numbers to work.. Now I still have the weird messages;


I can't seem to get rid of them.
Here's the code;

Code:

List<String> notes = this.getConfig().getStringList("Note-List."+target.getName()+".notes");
                                this.getConfig().set("Note-List."+target.getName()+".notes", notes);
                                if (target != null && args.length == 2){
                                    if(notes == null || notes.size() == 0){
                                        sender.sendMessage(notePrefix+"§cThis player does not have any notes!");
                                    }
                                    sender.sendMessage(notePrefix+noteListHeader.replaceAll("%player%", target.getName()));
                                    for(int i = 0; i<notes.size(); ++i){
                                        String IDPrefix = idPrefix.replaceAll("%ID%", String.valueOf(i+1));
                                        player.sendMessage(IDPrefix+(notes.toArray()));
                                }}}}}}

 

bump ? xD

 

@timtower
How to loop through the values is what I don't understand properly how to do. I've searched for hours to find an answer but everything comes up as list.toArray();

 

@yPedx
https://docs.oracle.com/javase/tutorial/java/nutsandbolts/for.html
The for loop you want is at the bottom of the page, though you should read the whole thing if you do not know what a for loop is.

 

Here's some code:

Code:java

int i = 1;
for (String note : notes){
sender.sendMessage("["+ i + "] " + note)
i++;
}

 

@Horsey
Thanks

@Zombie_Striker
I'll definitely learn a bit more of that.