Solved Event isn't working

Hi I'm coding a plugin and I want it to cancel an event while happening in this case a pocion and a firework but it seems that it isnt working and theres no error in console that gives me a clue.

Code:

    @EventHandler(priority=EventPriority.HIGH)
    public void onPlayerInteractEvent(PlayerInteractEvent e)
    {
        if(e.getItem() == null)
        {
            return;
        }
        else if((e.getItem().getType().equals(Material.POTION)) && (!(e.getPlayer().hasPermission("sc.pocion"))))
        {
            e.setCancelled(true);
           
        }
        else if((e.getItem().getType().equals(Material.FIREWORK)) && (!(e.getPlayer().hasPermission("sc.firework"))))
        {
            e.setCancelled(true);
           
        }

 

Yes I did:

Code:

getServer().getPluginManager().registerEvents(new BanHandStuff(), this);

 

@danichef

If you compare using enums (==) instead of .equals, it should work.

 

@mehboss
You do need a null check, what if they right click with no item?

 

Nothing would happen?

 

@mehboss
PlayerInteractEvent fires even if the player is holding no item, so the null check is required.

 

Still doesen't work. Anything else I could try?

 

@danichef
"Doesnt work" is interpreted as? Error? Code not executed?

The only difference between the two is that .equals will throw a NullPointerException if the left-most reference is null, so for example:

Code:

SomeEnum e = null;
e.equals(SomeEnum.SOME_VALUE);

This errors cause e = null and .equals is a method invoked on this null reference.
In that situation == would work just fine returning false.
However .equals works fine with null arguments:

Code:

SomeEnum e = null;
SomeEnum.SOME_VALUE.equals(null);

This would simply return false which makes sense if you read the code behind .equals for Enums:

Code:

public final boolean equals(Object other) {
      return this==other;
}

Now having said all that i dont think that .getType() would return null rather than a Material in any case so .equals should be just fine

I think the OP has to do some debuging himself to track down the issue and work a bit on the logic of the conditional statement

 

I got other way to do it anyways thx!