Solved [Factions API] for statement?

I have the following statement; however, it only sends a message to the faction of the sender, not to the opposing faction.

Code:java

for(final Player pa : fac.getOnlinePlayers()){
                        for (final Player pas : FactionColl.get().getByName(args[1]).getOnlinePlayers()){
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pWar.put(pa, 0);
                            pWar.put(pas, 0);
                            Opponent.put(args[1], null);
                        pa.sendMessage(prefix + ChatColor.AQUA + "The war will last 10 minutes");
                        pa.sendMessage(prefix + ChatColor.AQUA + "You have 5 minutes of preperation time");
                        pa.sendMessage(prefix + ChatColor.GREEN + "If you win, you will receive more faction power!");
                        pa.sendMessage(prefix + ChatColor.RED + "The war will be based on your faction home");
                        pas.sendMessage(prefix + ChatColor.AQUA + "The war will last 10 minutes");
                        pas.sendMessage(prefix + ChatColor.AQUA + "You have 5 minutes of preperation time");
                        pas.sendMessage(prefix + ChatColor.GREEN + "If you win, you will receive more faction power!");
                        pas.sendMessage(prefix + ChatColor.RED + "The war will be based on your opponent's faction home");

 

Well what you are doing here, the 2nd for loop is pointless, since it just sends the message 2 times to the player. Remove the 2 arrow spots because if its sent to the factions players, and if the sender is in the faction, it will send it to him. So your sending it to him 2 times basically.

 

@OfficerDeveloper
The reason I need the 2 if statements is because: The plugin aims to create a war against 2 factions (where 'fac' represents the faction of the sender); hence the "pa" represents the online players of the players faction.
The other statement ("pas") represents the opposing faction's members.
Hence I implemented 2 for statements.

 

@ProMCKingz Did you get the message and the other person didnt? Please tell me more so I can help
Try this...

Code:

    for(final Player pa : fac.getOnlinePlayers()){
    for (final Player pas : FactionColl.get().getByName(args[0]).getOnlinePlayers()){
    pa.sendMessage("");
    pa.sendMessage("");
    pa.sendMessage("");
    pa.sendMessage("");
    pa.sendMessage("");
    pa.sendMessage("");
    pWar.put(pa, 0);
    pWar.put(pas, 0);
    Opponent.put(args[0], null);
    pa.sendMessage(prefix + ChatColor.AQUA + "The war will last 10 minutes");
    pa.sendMessage(prefix + ChatColor.AQUA + "You have 5 minutes of preperation time");
    pa.sendMessage(prefix + ChatColor.GREEN + "If you win, you will receive more faction power!");
    pa.sendMessage(prefix + ChatColor.RED + "The war will be based on your faction home");
    pas.sendMessage(prefix + ChatColor.AQUA + "The war will last 10 minutes");
    pas.sendMessage(prefix + ChatColor.AQUA + "You have 5 minutes of preperation time");
    pas.sendMessage(prefix + ChatColor.GREEN + "If you win, you will receive more faction power!");
    pas.sendMessage(prefix + ChatColor.RED + "The war will be based on your opponent's faction home");

Can you also give me the command because I changed (args[1]) to (args[0]).
/factions myFaction war
myFaction is equal to args 0 and war is equal to args 1 which might be your problem...

 

@Fluf3

• The command is: /war start [facname]
• One person receives the message (the sender). At this point i am not sure if all the members in the faction receive the message. But i am sure that the opposing faction members are not receiving the message

Here is the whole class, just incase it's a constructor issue:

Main Class (open) Main Class (close)

Code:java

package me.promckingz.battleday;
 
import java.util.ArrayList;
import java.util.HashMap;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
import com.massivecraft.factions.entity.Faction;
import com.massivecraft.factions.entity.FactionColl;
import com.massivecraft.factions.entity.MPlayer;
 
public class Main extends JavaPlugin{
 
    private static Faction fac;
 
    public static HashMap<Faction, Integer> inList = new HashMap<Faction, Integer>();
    ArrayList<Faction> inWar = new ArrayList<Faction>();
    public static HashMap<String, Integer> Opponent = new HashMap<String, Integer>();
    public static HashMap<String, Integer> Creator = new HashMap<String, Integer>();
    public static HashMap<Player, Integer> pWar = new HashMap<Player, Integer>();
    public static int AScore;
    public static int BScore;
 
    public void onEnable(){
        PluginManager register = Bukkit.getServer().getPluginManager();
        register.registerEvents(new KillListener(), this);
        Bukkit.getServer().broadcastMessage(ChatColor.GREEN + "BattleDay running...");
        saveDefaultConfig();
        getConfig().options().copyDefaults(true);
    }
 
    public void onDisable(){
 
    }
 
    Faction faction = null;
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, final String[] args){
        if(sender instanceof Player){
            final String prefix = (ChatColor.GRAY + "[" + ChatColor.GREEN + "BattleDay" + ChatColor.GRAY + "] ");
            Player p = (Player) sender;
            MPlayer uplayer = MPlayer.get(p);
             fac = uplayer.getFaction();
        if(cmd.getName().equalsIgnoreCase("war")){
            if (args.length == 0){
                p.sendMessage("");
                p.sendMessage(ChatColor.GOLD + "             ---->" + ChatColor.GREEN + " Made by: ProMCKingz " + ChatColor.GOLD + "<----");
                p.sendMessage(prefix + ChatColor.AQUA + "Use /War Help for plugin information");
                p.sendMessage(ChatColor.LIGHT_PURPLE + "             Version 1.0              ");
                p.sendMessage("");
            }
        else if (args[0].equalsIgnoreCase("help")){
            if(!p.hasPermission("war.help")){
                return true;
            }
            p.sendMessage("");
            p.sendMessage(prefix + ChatColor.GOLD + "-=- BattleDay Help -=-");
            p.sendMessage(prefix + ChatColor.AQUA + "/war search |" + ChatColor.GREEN + " Search for other factions ready to battle");
            p.sendMessage(prefix + ChatColor.AQUA + "/war start [faction] |" + ChatColor.GREEN + " Start a war with another faction");
            p.sendMessage(prefix + ChatColor.AQUA + "/war cancel |" + ChatColor.GREEN + " Cancel war preperation [SOON!]");
        }
        else if (args[0].equalsIgnoreCase("search")){
            if(!p.hasPermission("war.search")){
                return true;
            }
            if(fac.isNone()){
                p.sendMessage(prefix + ChatColor.RED + "You do not have a faction!");
                return true;
            }
                if(!inList.containsKey(fac)){
                    inList.put(fac, null);
            p.sendMessage(prefix + ChatColor.DARK_RED + "[Warning]" + ChatColor.RED + " Your faction has now been placed in the search list!");
            }
            p.sendMessage(prefix + ChatColor.GOLD + "Searching for factions...");
            p.sendMessage(prefix + ChatColor.GOLD + "Here are all the factions ready for battle:");
            for (Faction fact : inList.keySet()) { // If inList is a map, add keySet() or values()
                   p.sendMessage("    -    " + fact.getName() + ChatColor.GRAY + ChatColor.ITALIC + " (" + fact.getDescription().trim() + ")");
            }
            }
        else if (args[0].equalsIgnoreCase("start")){
            if(!p.hasPermission("war.help")){
                return true;
            }
            if(args.length != 2){
                p.sendMessage(prefix + ChatColor.RED + "Please use /war start [faction]");
                return true;
            }
            if(!FactionColl.get().isNameTaken(args[1])){
                p.sendMessage(prefix + ChatColor.RED + "That faction does not exist!");
                p.sendMessage(prefix + ChatColor.RED + "Factions are searched in case sensitive");
                return true;
            }
            if(fac.isNone()){
                p.sendMessage(prefix + ChatColor.RED + "You do not have a faction!");
                return true;
            }
            if(inWar.contains(fac)){
                p.sendMessage(prefix + ChatColor.RED + "Your faction is already in war!");
                return true;
            }
            if(fac.getLeader().getName() != p.getName()){
                p.sendMessage(prefix + ChatColor.RED + "You must be the leader of the faction to start war!");
                p.sendMessage(prefix + ChatColor.RED + "Current leader is: " + fac.getLeader().getName());
                return true;
            }
            if(fac.hasHome() == false){
                p.sendMessage(prefix + ChatColor.RED + "You do not have a set faction home!");
                p.sendMessage(prefix + ChatColor.RED + "Use /f claim");
                p.sendMessage(prefix + ChatColor.RED + "   then");
                p.sendMessage(prefix + ChatColor.RED + "Use /f sethome");
                return true;
            }
            if(FactionColl.get().getByName(args[1]).hasHome() == false){
                p.sendMessage(prefix + ChatColor.RED + "Your opponent does not have a set faction home!");
                p.sendMessage(prefix + ChatColor.RED + "They should use /f claim");
                p.sendMessage(prefix + ChatColor.RED + "      then..");
                p.sendMessage(prefix + ChatColor.RED + "They should use use /f sethome");
                return true;
            }
            for(Faction f : inList.keySet()){
                if(f.isNone()){
                    p.sendMessage(prefix + ChatColor.RED + "That faction is not in the search list!");
                    p.sendMessage(prefix + ChatColor.RED + "Factions are searched in case sensitive");
                    return true;
                }
                }
                if(args.length == 2){
                    for(Faction f : inList.keySet()){
                        if(f.getName().contains(args[1])){
                    if(FactionColl.get().isNameTaken(args[1])){
                        Bukkit.getServer().broadcastMessage("     " + ChatColor.AQUA + fac.getName() + ChatColor.RED + " has started war against " + ChatColor.GREEN + args[1]);
                        inWar.add(fac);
                        inWar.add(FactionColl.get().getByName(args[1]));
                        Opponent.put(FactionColl.get().getByName(args[1]).getMPlayers().toString(), null);
 
                    for(final Player pa : fac.getOnlinePlayers()){
                        for (final Player pas : FactionColl.get().getByName(args[1]).getOnlinePlayers()){
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            Creator.put(pa.getName(), 0);
                            pWar.put(pa, 0);
                            pWar.put(pas, 0);
                        pa.sendMessage(prefix + ChatColor.AQUA + "The war will last 10 minutes");
                        pa.sendMessage(prefix + ChatColor.AQUA + "You have 5 minutes of preperation time");
                        pa.sendMessage(prefix + ChatColor.GREEN + "If you win, you will receive more faction power!");
                        pa.sendMessage(prefix + ChatColor.RED + "The war will be based on your faction home");
                        pas.sendMessage(prefix + ChatColor.AQUA + "The war will last 10 minutes");
                        pas.sendMessage(prefix + ChatColor.AQUA + "You have 5 minutes of preperation time");
                        pas.sendMessage(prefix + ChatColor.GREEN + "If you win, you will receive more faction power!");
                        pas.sendMessage(prefix + ChatColor.RED + "The war will be based on your opponent's faction home");
                          Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(Main.this, new Runnable() {
                                 public void run() {
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                         pa.sendMessage(prefix + ChatColor.RED + "Your preperation time has ended!");
                                         pa.sendMessage(prefix + ChatColor.RED + "You will be teleported to the battle ground in 3 seconds!");
                                         pas.sendMessage("");
                                         pas.sendMessage("");
                                         pas.sendMessage("");
                                         pas.sendMessage("");
                                         pas.sendMessage("");
                                         pas.sendMessage("");
                                         pas.sendMessage("");
                                         pas.sendMessage("");
                                             pas.sendMessage(prefix + ChatColor.RED + "Your preperation time has ended!");
                                             pas.sendMessage(prefix + ChatColor.RED + "You will be teleported to the battle ground in 3 seconds!");
                                 }
                         }, 100L);
                          Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(Main.this, new Runnable() {
                                 public void run() {
                                     World w = Bukkit.getServer().getWorld(fac.getHome().getWorld());
                                     Double x = fac.getHome().getLocationX();
                                     Double y = fac.getHome().getLocationY();
                                     Double z = fac.getHome().getLocationZ();
                                             pa.teleport(new Location(w,x,y,z));
                                             pas.teleport(new Location(w,x,y,z));
                                             pa.sendMessage("");
                                             pa.sendMessage("");
                                             pa.sendMessage("");
                                             pa.sendMessage("");
                                             pa.sendMessage("");
                                             pa.sendMessage("");
                                             pa.sendMessage("");
                                             pa.sendMessage("");
                                         pa.sendMessage(prefix + ChatColor.RED + "You are now in war!");
                                         pa.sendMessage(prefix + ChatColor.BLUE + "Kill as many players as you can to win the war!");
                                             pas.sendMessage("");
                                             pas.sendMessage("");
                                             pas.sendMessage("");
                                             pas.sendMessage("");
                                             pas.sendMessage("");
                                             pas.sendMessage("");
                                             pas.sendMessage("");
                                             pas.sendMessage("");
                                         pas.sendMessage(prefix + ChatColor.RED + "You are now in war!");
                                         pas.sendMessage(prefix + ChatColor.BLUE + "Kill as many players as you can to win the war!");
                                 }
                         }, 160L);
                          Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(Main.this, new Runnable() {
                                 public void run() {
                                     pWar.remove(pa);
                                     pWar.remove(pas);
                                     inWar.remove(fac);
                                     Opponent.remove(FactionColl.get().getByName(args[1]).getMPlayers().toString());
                                     Creator.remove(pa);
                                     AScore = 0;
                                     BScore = 0;
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage("");
                                     pa.sendMessage(ChatColor.GOLD + "****************************");
                                     pa.sendMessage(ChatColor.WHITE + "" + ChatColor.BOLD + "      *   WAR RESULTS   *   ");
                                         pa.sendMessage(prefix + ChatColor.RED + "You have lost the war!");
                                         pa.sendMessage(prefix + ChatColor.AQUA + "You have won the war!");
                                         pa.sendMessage(ChatColor.GOLD + "****************************");
                                 }
                         }, 260L);
                    }
                    }
                    }
                        }
                    }
                    }
        }
        else p.sendMessage(prefix + ChatColor.RED + "Unknown command: " + ChatColor.GOLD + args[0] + ChatColor.GREEN + " /war help");
        }
    }
        return true;
    }
}
 

 

Code:

    @Override
    public boolean onCommand(CommandSender Sender, Command cmd, String commandLabel, String[] args){
        if(Sender instanceof Player){
            if(cmd.getName().equalsIgnoreCase("sup")){
            MPlayer p = MPlayer.get(p);
            for(Faction f : FactionColl.get().getAll()){
                if(f.getRelationTo(p.getFaction()).equals(Rel.ENEMY)){
                    for(MPlayer P : f.getMPlayers()){
                        P.sendMessage("g\'day!");
                    }
                }
            }
            }
        }
    }

 

@MajorSkillage
what's this?

 

If a user types /sup (assuming they have a faction) it will send all their faction enemies players a message , oh damn didn't check if the players were even online, oh well ._.

 

@MajorSkillage

How would you implement that into arguments. So when a player types /war start [facname] it will send his faction and all of the other faction a message. Please check the code posted above (in a spoiler), and find the mistake I am making there. Thanks

 

Code:

            for(Faction f : FactionColl.get().getAll()){
                if(f.getRelationTo(p.getFaction()).equals(Rel.ENEMY)){
                    for(MPlayer pa : f.getMPlayers()){
                    if(pa.isOnline()){
                                                 pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pa.sendMessage("");
                            pWar.put(pa, 0);
                            pWar.put(pas, 0);
                            Opponent.put(args[1], null);
                        pa.sendMessage(prefix + ChatColor.AQUA + "The war will last 10 minutes");
                        pa.sendMessage(prefix + ChatColor.AQUA + "You have 5 minutes of preperation time");
                        pa.sendMessage(prefix + ChatColor.GREEN + "If you win, you will receive more faction power!");
                        pa.sendMessage(prefix + ChatColor.RED + "The war will be based on your faction home");
                        pas.sendMessage(prefix + ChatColor.AQUA + "The war will last 10 minutes");
                        pas.sendMessage(prefix + ChatColor.AQUA + "You have 5 minutes of preperation time");
                        pas.sendMessage(prefix + ChatColor.GREEN + "If you win, you will receive more faction power!");
                        pas.sendMessage(prefix + ChatColor.RED + "The war will be based on your opponent's faction home");
                     }
                    }
                }
            }
            }
        }
    }

Sry for the messy reply, Bukkit playing up on meh

 

@MajorSkillage
I don't want to check if they are enemies or not; basically it checks if they are in the search list or not

 

@ProMCKingz
What exactly do you want in this "search List"?

 

@ProMCKingz
I cant see any constructor errors but I think that the problem is from...

Code:

 for(final Player pa : fac.getOnlinePlayers()){
for (final Player pas : FactionColl.get().getByName(args[1]).getOnlinePlayers()){

Hope this helps!

 

@MajorSkillage
Thanks, I just realised that I was exporting it in the wrong place. Thanks for your help, it all seemed to work fine.

___________________________________
@Fluf3 Alright, thanks for your help.