Plugin won't work?

Hello, I've tried to make a pvp enable plugin, but for some reason the main command won't work. I don't get any errors in the consol and the plugin looks like it should work when I type /plugins

This is my code:

Code:java

package com.DrBeast.PrisonPurge;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class PrisonPurge extends JavaPlugin{
 
    ArrayList<Player> cooldown = new ArrayList<Player>();
 
    public void onEnalbe(){
        System.out.println("Plugin Enabled!");
    }
 
    public void onDisable(){
        System.out.println("Plugin Disabled!");
    }
    public int i = 60;
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        if(!(sender instanceof Player)) {
            sender.sendMessage("§conly players can use this command");
            return true;
        }
 
        Player p = (Player) sender;
        final Player p2 = (Player) sender;
        if(p.getName().equalsIgnoreCase("purge")){
            if(p.hasPermission("Purge.start")) {
                if(args.length == 0) {
                    p.sendMessage("§4§m§l|------( §r§6Purge Help §4§m§l)------| ");
                    p.sendMessage("§8/purge start");
                    p.sendMessage("§7this command will enable pvp everywhere for 15 minutes.");
                    p.sendMessage("§4§m§l|------( §r§6Purge Help §4§m§l)------| ");
                }else if(args.length < 1) {
                    if(args[0].equalsIgnoreCase("start")){
                        if(cooldown.contains(p2)){
                            p2.sendMessage("§cThis purge is already running!");
                        } else {
 
                            cooldown.add(p2);
                            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
                                public void run() {
                                    if(i == 60){
                                        Bukkit.broadcastMessage(ChatColor.RED + "The Purge will begin in " + i + " seconds");
                                        i--;
                                    }
                                    cooldown.remove(p2);
                                }
                            }, 18000);
 
                        }
                    }
                }
            }
        }
        return false;
    }
 
 
 
}
 

 

BeastCraft3
Actually, your task will start - after 18000 milliseconds. Because thats the starting delay of the task.
Have you tried to wait that period of time?

 

Code:java

 public void onEnalbe(){
System.out.println("Plugin Enabled!");
}

onEnable*
You made a typo

 

Unica Th3Br1x
lol I fixed it Unica it still doesn't work though and Th3Br1x its suppost to start after the void run, at least all the tutorials I could find on google did that. and again the /purge doesn't work either. if they write /purge it's suppot to display the Help menu

 

BeastCraft3
Lol, check your code carefully
You're checking, if the players name is "purge".

Fixed?

 

You should always @Override onEnable. It'll also tell you if you had a typo then.

 

aaomidi
Actually not. Why should it display a typo? (Except for eclipse's spelling module).
But that's not the problem anymore

 

Th3Br1x because you override those methods to begin with if you use them. You can't override a method that doesn't exist in the super class.

 

Well, i didn't even knew that, thank you
You always learn new stuff as a programmer...

 

Th3Br1x teej107 Th3Br1x aaomidi
Would this work? as you can see am having problems mixing up arrays and hashmap. Please tell me what to do ;(

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        if(!(sender instanceof Player)) {
            sender.sendMessage("§conly players can use this command");
            return true;
        }
 
        Player p = (Player) sender;
        final Player p2 = (Player) sender;
        if(p.getName().equalsIgnoreCase("purge")){
            if(p.hasPermission("Purge.start")) {
                if(args.length == 0) {
                    p.sendMessage("§4§m§l|------( §r§6Purge Help §4§m§l)------| ");
                    p.sendMessage("§8/purge start");
                    p.sendMessage("§7this command will enable pvp everywhere for 15 minutes.");
                    p.sendMessage("§4§m§l|------( §r§6Purge Help §4§m§l)------| ");
                }else if(args.length < 1) {
                    if(args[0].equalsIgnoreCase("start")){
                            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
                                public void run() {
                                    for(Player pl : Bukkit.getOnlinePlayers()){
                                        if(pl != null) {
                                        }
                                        int time = purge.get(pl.getName());
                                        time--;
                                        if (time == 1200) {
                                            Bukkit.broadcastMessage("§cThe Purge will begin in 1 minute!");
                                        } else if(time == 600){
                                            Bukkit.broadcastMessage("§cThe Purge will begin in 30 seconds!");
                                        } else if(time == 200){
                                            Bukkit.broadcastMessage("§cThe Purge will begin in 10 seconds!");
                                        } else if(time == 60){
                                            Bukkit.broadcastMessage("§cThe Purge will begin in 3 seconds!");
                                        } else if(time == 40){
                                            Bukkit.broadcastMessage("§cThe Purge will begin in 2 seconds!");
                                        } else if(time == 20){
                                            Bukkit.broadcastMessage("§cThe Purge will begin in 1 second!");
                                        } else if(time < 1){
                                            Bukkit.broadcastMessage("§cThe Purge has now begin, pvp is allowed EVERYWHERE for 15 minutes. Goodluck");
                                            purge.remove(pl.getName());
                                        }
 
                                    }
                                }
                            }, 18000);
 
                        }
                    }
                }
            }
 
        }
        return false;

 

BeastCraft3
If player isn't null, do nothing. line 22

 

Code:java

32. if(p.getName().equalsIgnoreCase("purge")){

Should it not be:

Code:java

if(cmd.getname().equalsIgnoreCase("purge")){

?

 

timbragg12

I don't know what you're talking about, my IGN is always "purge."

Kidding aside, this is a prime example of one character variable names are usually a bad thing, it's much harder to see mistakes like this at a glance, rather than player.getName().... which would be a very obvious mistake.

 

BeastCraft3
Why are you doing a for loop then broadcasting the message? That will spam everybody's chat. Also, store the player's UUID instead of the actual Player Object.

 

mythbusterma I agree, although I will continue to use "p" anyway.

 

FabeGabeMC

I think you can save the object, as long as you remove it on disconnecting / reloading.

 

Unica
I know but it might cause memory leaks.

 

might. only if you forget to remove the player.

 

teej107 FabeGabeMC Unica timbragg12 mythbusterma Creeoer
ok all this was a little advanced talky.
and yeah, I saw that mistake timbragg12
Should I remove the arraylist and only use hashmap or should I remove the hashmap and use the arraylist

 

BeastCraft3 need some help with coding?

 

JordyPwner
yes

 

U got saros or skype?

 

JordyPwner
skype: torbjorn.firered

 

BeastCraft3
I don't see any HashMap in your code

 

Th3Br1x

Code:java

int time = purge.get(pl.getName());

purge is my hashmap:

Code:java

private HashMap<UUID, Integer> purge = new HashMap<>();

and cooldown is my arraylist:

Code:java

ArrayList<Player> cooldown = new ArrayList<Player>();

Which one of them should I use?

 

BeastCraft3
It depends on your usage. If you just want to have a list, to check which players have still a running cooldown, use the ArrayList. If you also want to store the remaining cooldown, use the hashmap.

 

Th3Br1x
I don't want to store them. ahh this plugin is getting soo advanced... I just wanted to create a simple plugin when you use /purge start it will be a cooldown on 1 minute then pvp over the entire world will be enabled with Bukkit.getConsoleSender().dispatchCommand("Region flag __global__ -w plotworld pvp allow"); for 15 minutes then disable it with the same command