When I create a target, whenever I run a command that doesn't even involve a target, i get an error.

It was fine until I created commands that involve a target. target = Bukkit.getServer().getPlayer(args[1]);, getPlayer is crossed out and I dont know what to use instead of it.

Code:java

public class ModList extends JavaPlugin implements Listener{
 
    public ArrayList<String> admins = new ArrayList<String>();
    public ArrayList<String> mods = new ArrayList<String>();
    public ArrayList<String> adminsperm = new ArrayList<String>();
    public ArrayList<String> modsperm = new ArrayList<String>();
    @Override
    public void onEnable(){
        getLogger().info("ModList has been enabled!");
        getServer().getPluginManager().registerEvents(this, this);
 
    }
 
    @Override
    public void onDisable(){
        getLogger().info("ModList has been disabled!");
    }
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e){
        if(e.getPlayer().hasPermission("admins.add")){
            admins.add(e.getPlayer().getName());
            Bukkit.broadcastMessage(ChatColor.GREEN + "A Staff member has joined the game!");
        }
        if(e.getPlayer().hasPermission("mods.add")){
            mods.add(e.getPlayer().getName());
            Bukkit.broadcastMessage(ChatColor.GREEN + "A Staff member has joined the game!");
        }
        /*if(e.getPlayer().hasPermission("permlist.admins.add")){
            adminsperm.add(e.getPlayer().getName());
        }
        if(e.getPlayer().hasPermission("permlist.mods.add")){
            modsperm.add(e.getPlayer().getName());
        }
        */
    }
 
    @EventHandler
    public void onLeave(PlayerQuitEvent e){
        if(admins.contains(e.getPlayer().getName())){
            admins.remove(e.getPlayer().getName());
            Bukkit.broadcastMessage(ChatColor.RED + "A Staff member has left the game!");
        }
        if(mods.contains(e.getPlayer().getName())){
            mods.remove(e.getPlayer().getName());
            Bukkit.broadcastMessage(ChatColor.RED + "A Staff member has left the game!");
        }
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        Player target = null;
        if (cmd.getName().equalsIgnoreCase("staff")) {
            target = Bukkit.getServer().getPlayer(args[1]);
            //List<String> admins = new ArrayList<>();
          // List<String> mods = new ArrayList<>();
            /*for (Player player : getServer().getOnlinePlayers()) {
                String name = player.getName();
                if (admins.contains(name)) {
                    admins.add(name);
                }else if(mods.contains(name)){
                    mods.add(name);
                }
            }
        */
            if (admins.size() < 0 && mods.size() < 0) {
                sender.sendMessage(ChatColor.YELLOW + "No staff is currently online!");
            } else {
                sender.sendMessage(ChatColor.AQUA + "Admins Online:");
                for (String adminsName : admins) {
                    if(admins.size() < 0){
                        sender.sendMessage(ChatColor.YELLOW + "No admins are currently online.");
                    }else if (admins.size() > 0){
                    sender.sendMessage(ChatColor.AQUA + "• " + ChatColor.YELLOW + adminsName );
                }
                }
                sender.sendMessage(ChatColor.AQUA + "Mods Online:");
                for(String modsName : mods){
                    if(mods.size() < 0){
                        sender.sendMessage(ChatColor.YELLOW + "No mods are currently online.");
                    }else if (mods.size() > 0){
                    sender.sendMessage(ChatColor.AQUA + "• " + ChatColor.YELLOW + modsName );
                }
                }
            }
 
        }
        if(cmd.getName().equalsIgnoreCase("listadmin")){
            if(sender.hasPermission("set.admin")){
                target = Bukkit.getServer().getPlayer(args[1]);
            if(args.length == 1){
                if(sender instanceof Player){
                    if(target != null){
                        if(!target.isOnline()){
                        sender.sendMessage(ChatColor.RED + "Player must be online to add them to the staff list!");
                    }else if(target.isOnline()){
                        adminsperm.add(target.getName());
                        sender.sendMessage(ChatColor.GREEN + target.getName() + " has been added to the Admin list!");
                        target.sendMessage(ChatColor.YELLOW + "You have been added to the Admin list!");
                    }
                }
            }
            }
        }
        if(cmd.getName().equalsIgnoreCase("listmod")){
            if(sender.hasPermission("set.mod")){
                target = Bukkit.getServer().getPlayer(args[1]);
            if(args.length == 1){
                if(sender instanceof Player){
                    if(target != null){
                        if(!target.isOnline()){
                        sender.sendMessage(ChatColor.RED + "Player must be online to add them to the staff list!");
                    }else if(target.isOnline()){
                        modsperm.add(target.getName());
                        sender.sendMessage(ChatColor.GREEN + target.getName() + " has been added to the Mod list!");
                        target.sendMessage(ChatColor.YELLOW + "You have been added to the Mod list!");
                    }
                }
            }
            }
        }
        if(cmd.getName().equalsIgnoreCase("stafflist")){
            if (adminsperm.size() < 0 && modsperm.size() < 0) {
                sender.sendMessage(ChatColor.YELLOW + "There is no staff for this server!");
        } else {
            sender.sendMessage(ChatColor.AQUA + "Admins:");
            for (String adminsName : adminsperm) {
                if(adminsperm.size() < 0){
                    sender.sendMessage(ChatColor.YELLOW + "There are no admins for this server!");
                }else if (adminsperm.size() > 0){
                sender.sendMessage(ChatColor.AQUA + "• " + ChatColor.YELLOW + adminsName );
            }
            }
            sender.sendMessage(ChatColor.AQUA + "Mods:");
            for(String modsName : modsperm){
                if(modsperm.size() < 0){
                    sender.sendMessage(ChatColor.YELLOW + "There are no mods for this server!");
                }else if (modsperm.size() > 0){
                sender.sendMessage(ChatColor.AQUA + "• " + ChatColor.YELLOW + modsName );
            }
            }
        }
        }
    }
        }
        return false;
    }
}

 

Crossed out means deprecated. Bukkit.getPlayer(String name) is just deprecated to raise awareness about 1.8 and the UUID updates, and it wants you to use Bukkit.getPlayer(UUID uuid). You can still use Bukkit.getPlayer(String name) fine though.

 

WeeziMonkey
That has nothing to do with this.

football70500
You are getting the error because you are trying to access an element in the array that doesn't exist. You need to first check if the args.length is equal to something. If args.length is 1. then only 1 argument was used in the command. This should give you the basic idea.

Edit: Your error is pointing to this line

Code:java

for (String adminsName : admins) {

Are you sure you gave us the correct code?

 

Code:

try{
     target = Bukkit.getServer().getPlayer(args[1]);
}catch(Exception ex){
     sender.sendMessage("Invalid target");
}

 

You should check the admins.size before iterating through the array

 

Watto Iterations do not require you to check the size
davidp027 What... no. Don't catch Exception, like, ever. (ok there are plugins that like to throw Exception for some reason, then it's required for your code to even compile, but they shouldn't be throwing Exceptions in the first place)

 

fireblast709

I know but there is literally no point of checking the size inside the iterator, its best to check outside before even running the iterator.

 

Check the arguments length before getting the player.....

 

No. Just no. All of the comments above me are WRONG.
Your exception is an ArrayIndexOutOfBoundsException caused by the index 1.
What does that mean? It means that there is no such index as index 1 in args - meaning there are no 2 arguments, there are one ([0] = first, [1] = second).

If you're trying to capture the first index, you are'nt doing it correctly - what you want is [0] and not [1]. If you're trying to capture the second one - then you wrote the command with no second argument.

Just check the size of the arguments before you use it, and check if the target is null (if the target doesn't exist.)

 

NonameSL have you even read the posts? Assist and rbrick posted the same answer .

 

fireblast709 Of course he has! Who would make a broad (and obviously incorrect) statement such as 'all the answers are above me are incorrect' if they hadn't read the posts! How else would they know? Also, not like NonameSL sounds arrogant or anything there...