[INACTIVE][MECH] SimpleBarter 1.2 - inventory trading [612-677]

SimpleBarter - trade in inventory dialog
Version: v1.2

Want to be able to trade items other players with other players without dropping them on the ground (where accidents can and do happen...)? Don't want to use the nasty, easy to forget, easy to mess up command system that other plugins use? Barter on your own terms.

Features:

SimpleBarter allows players to trade items in their inventory with other players easily. Simple tap another player while your hand is empty. They will be notified that you want to trade, and will tap back if they want to trade. A dialog with both of your inventories in it will appear, allowing both players to drag and drop items seamlessly into each others inventories. Once either of the players closes the inventory dialog, both inventory dialogs will close (that way, a sneaky player who leaves it up while you walk away, can not steal stuff. It will close once you leave).

Other Notes:
Tapping multiple times rapidly on one player will only give them 1 notification (won't spam chat log). It will tell the tapper to quite pestering other players as well. Additionally, this plugin blocks damage from tapping with nothing in your hand, to other players. Using any item will damage players normally.

No Commands.
No messy Configuration.
No Dependancies.
No Hassle.

Enjoy!

Download Here
Source Code

ChangeLog:

• version 1.0
  • initial release
• version 1.1
  • added configuration
  • added right click to trade
  • added item configuration
• version 1.2
  • Optional backpack support

 

I feel bad about this - I never knew that this guy was on my server, haha.

*pats Afforess*

 

This seems an excellent solution. Any comments, suggestions?

 

Ya I like that but would there be a way to have both offerings up at the same time. And for canceling the trade are esc and clicking cancel both considered the same action, like could one close out the trade entirely and the other accept a trade? O and what about my post the page before.

 

in a fancy Birtish accent "If the other player has a dog will it attack you if you hit them to trade??????!!!!111!!!11(semi colon)"

 

Yes I believe I saw this on another server where they had that problem

 

The new system will work with right clicks, not left.

 

If you can make it work like that, this would be the most elegant solution to trades yet!

 

Please update to/test against latest RB for releases.

 

How is right click support using that method coming along?

 

This is pretty good, but I don't think the trade should be considered cancelled if either chest has items in it, or at least it should be configurable. If one of the players decides that they didn't want those items after all, why should they be forced to take them?

I do have one other idea; I wonder if it would be possible to unify steps 4 and 5? Something like this:

1. Players optionally decide what to trade in chat.
2. Player A initiates trade, player B accepts.
3. Player A and B see an empty chest, and drag items into the left half; at the same time, they see in the right half the items being offered. The right half is untouchable at this stage.
4. Something is done to confirm the trade (attempting to close the window could work, if you could cancel the close).
5. Player A and B now drag stuff out from the right half of the chest; now the left half is untouchable.
6. Closing the window concludes the trade; any offered items not taken are returned to their owner. The two players can close their windows at different times without any trouble (unless the first one to close logs off).

Though, to be honest, I can't imagine making that work without the INVENTORY_CLICK hook.

 

And suddenly, my PM's make infinitely more sense.

 

It would be cool if you added a way to just give a different player money from iconomy for the items

 

Broken on MC 1.5_02 , bukkit build 699

 

Not surprising, considering the title.

 

Cant you make it so you can move stuff from YOUR inventory to THIER inventory but YOU cant take something from THIER inventory?

 

A lot of people dont need this, because they can trust every person playing on his/her server.
If a teammate burglars, i can walk 2 meters and slap him^^

So i suggest to leave this optional. An configuration entry could solve this.

 

I really love the idea of this, its just really way to easy for thiefs to get ahold of items. If you have ever played Diablo 2, both players need to click the check button which accepts the trade.

This would be great, so maybe an update will come! Love the idea.

Also I do believe you shouldn't be able to see their inventory, Mr. Joe can drop the items into a seperate box showing the items he wants to trade while Mr. Douche can't see Mr. Joe's inventory items. It would be a lot of work, but fantastic to have!

Good Job on the progress though.

 

is this going to be updated for the newest recommended build of bukkit?

 

Yes and No.

Yes, the mod in it's existing form will be updated to build 733.

No, the versions several of us have discussed with improved trading will not be. It's proved a significantly more challenging than it first appeared, and I still need to create a solid API for several of the methods.

 

@Afforess

Awesome, I really like this mod by the way, it is much better than dropping items to people. Keep up the great work!

 

Code:

23:19:11 [SEVERE] Could not pass event ENTITY_DAMAGE to Simple Barter
java.lang.NoSuchFieldError: a
        at com.afforess.simplebarter.SimpleBarter.barter(SimpleBarter.java:149)
        at com.afforess.simplebarter.SimpleBarterEntityListener.onEntityDamage(SimpleBarterEntityListener.java:27)
        at org.bukkit.plugin.java.JavaPluginLoader$44.execute(JavaPluginLoader.java:474)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:59)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:257)
        at net.minecraft.server.EntityHuman.d(EntityHuman.java:522)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:801)
        at net.minecraft.server.Packet7UseEntity.a(SourceFile:33)
        at net.minecraft.server.NetworkManager.a(NetworkManager.java:195)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:74)
        at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
        at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:370)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:285)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:394)

cb 733 dindt appear any empty cheest box for trading only we continues to left click for accepted request but it create another request!

need an update!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

@Afforess - In lieu of INVENTORY_CLICK methods, you can just check if there is an itemstack currently being held in the player's cursor... it's a workaround, but works enough I guess (requires a little more overhead perhaps).

 

Does this work with 740??

 

I think it don't work with 740, because i send request to other poeple and when they click back me, the plugin think it's another invitation and not a reponse o.o

sorry for my bad english... i'm french...

 

we need an update :8

 

An update would be lovely for this wonderful mod

 

THIS !

 

There will be an update, but not until the next RB.

 

Roger, do you have a gut feeling for when the next RB will be out?

 

This plugin is amazing, i wish it would be updated