Solved Is anything wrong with my code?

Hello everyone, I'm new to Java and Bukkit and I'm created my first plugin for a server. Despite all the changes the owner has told me to make the plugin still won't load in the console.

The owner thinks there is a problem in the code, but he can't see it and nor can I.

If my code has many mistakes please forgive me, I am a beginner at coding.
My plugin is supposed to control the weather.

Thank you for reading and your help is greatly appreciated!

Since I can't get the code to load I will paste it into here.

**EDIT: I've arranged the code into a nicer format, sorry about that.
**EDIT: My current plugin.yml is at the bottom.
**EDIT: plugin.yml edited.
**EDIT: Fixed the code a bit.

==========================

Code:java

package weather.Keithman3;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Main extends JavaPlugin {
 
public final Logger logger = Logger.getLogger("Minecraft");
 
public void onEnable() {
logger.info("Welcome to GalaxyWeather BETA by Keithman3!");
}
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player player = (Player) sender;
if (commandLabel.equalsIgnoreCase("weather")) {
if (args[0].equalsIgnoreCase("sun")) {
World world = player.getWorld();
world.setStorm(false);
player.sendMessage(ChatColor.AQUA + "You turned the weather to: " + ChatColor.GOLD + "sun");
}
}
else if (args[0].equalsIgnoreCase("rain")) {
World world = player.getWorld();
world.setThundering(true);
player.sendMessage(ChatColor.AQUA + "You turned the weather to: " + ChatColor.GOLD + "rain");
}
else if (args[0].equalsIgnoreCase("storm")) {
World world = player.getWorld();
world.setThundering(true);
player.sendMessage(ChatColor.AQUA + "You turned the weather to: " + ChatColor.GOLD + "storm");
}
return true;
}
 
}

===========
URGH! Apparently it won't allow the .yml extention somehow, so I've decided to paste the plugin.yml text in the post.

Code:

    name: Weatherify
    version: 1.0
    description: Weatherify allows the user to control the weather.
    author: Keithman3
    authors: DamnHippo
    main: weather.Keithman3.Main
 
    commands:
      weather:
        description: Sets weather to sun in server.
        permission: galaxy.weather
        permission-message: Sorry, you cannot set the weather!
        usage: Syntax error! Please type /weather (sun, storm, rain)

 

1. Get a test server, test it, and give us the stack trace.
2. Next time put the code in this format so we can read it:

Code:java

package weather.Keithman3;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Main extends JavaPlugin {
public static void main(String[] arguments) {
 
}
public final Logger logger = Logger.getLogger("Minecraft");
 
public void onEnable() {
logger.info("Welcome to GalaxyWeather 3.0 by Keithman3!");
}
public void onDisable() {
logger.info("GalaxyWeather was disabled.");
 
}
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player player = (Player) sender;
if (commandLabel.equalsIgnoreCase("weather")) {
if (args[0].equalsIgnoreCase("sun")) {
World world = player.getWorld();
world.setStorm(false);
}
player.sendMessage(ChatColor.AQUA + "You turned the weather to: " + ChatColor.GOLD + "sun");
}
if (commandLabel.equalsIgnoreCase("weather")) {
if (args[0].equalsIgnoreCase("rain"));
World world = player.getWorld();
world.setThundering(true);
}
player.sendMessage(ChatColor.AQUA + "You turned the weather to: " + ChatColor.GOLD + "rain");
if (commandLabel.equalsIgnoreCase("weather")) {
if (args[0].equalsIgnoreCase("storm")) {
World world = player.getWorld();
world.setThundering(true);
}
player.sendMessage(ChatColor.AQUA + "You turned the weather to: " + ChatColor.GOLD + "storm");
}
return true;
}
 
}

EDIT: 3. Show us your plugin.yml

 

Keithman3
Notes:
- 'public static void main(String[] args)' is not needed in a minecraft plugin. onEnable does the trick.
- You don't need to check two times if the commandLabel is wheater, since it doesn't changes, you can have just one
- Be aware you get erros once this command is activated through the console, since you cast the sender immediately to a player without checking if it is actually a player
- Show the plugin.yml + the stacktrace like Forseth11 said.
- Make sure every bracket '{' is positioned good

Just some things

 

lol Dubehh that is one bugged up code... I did not even bother to read it since it was not posted nicely.

 

Forseth11
Excuse me? I just 'tahged' you because you gave some (good) advice he should follow too?

 

Code:

public class Main extends JavaPlugin {
 
public final Logger logger = Logger.getLogger("Minecraft");
 
public void onEnable() {
logger.info("Welcome to GalaxyWeather 3.0 by Keithman3!");
}
public void onDisable() {
logger.info("GalaxyWeather was disabled.");
 
}
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player player = (Player) sender;
if (commandLabel.equalsIgnoreCase("weather")) {
if (args[0].equalsIgnoreCase("sun")) {
World world = player.getWorld();
world.setStorm(false);
player.sendMessage(ChatColor.AQUA + "You turned the weather to: " + ChatColor.GOLD + "sun");
}
}
if (args[0].equalsIgnoreCase("rain"));
World world = player.getWorld();
world.setThundering(true);
player.sendMessage(ChatColor.AQUA + "You turned the weather to: " + ChatColor.GOLD + "rain");
}
if (args[0].equalsIgnoreCase("storm")) {
World world = player.getWorld();
world.setThundering(true);
player.sendMessage(ChatColor.AQUA + "You turned the weather to: " + ChatColor.GOLD + "storm");
}
return true;
}
 
}

That should work (Untested)

 

1. You shouldn't cast before checking.
2. You should use else ifs or a switch instead of a bunch of ifs, although the program will work the same either way.
3. You should return true inside those ifs.

 

Do note that both Minecraft and Bukkit are compiled in Java 6, and Strings in switches is a Java 7 feature (so you are secretly supposed to compile in Java 6 for maximum compatibility)
Geekhellmc & Keithman3 to continue the above list

1. Use cmd.getName() instead of commandLabel for alias support
2. No need to log the disable message as it adds nothing in respect to Bukkit's disable message
3. Do not use Logger.getLogger("Minecraft") nor Bukkit.getLogger(). Use the Logger that JavaPlugin provides through it's getLogger() method.

 

fireblast709 I know this, but it really doesn't matter at all. You're not actually editing minecraft or Bukkit and then compiling. If your program is built with Java 7+ and the server uses Java 7+ (which they all should, even though not all do ), then everything will be fine.

 

Code:java

public boolean onCommand( CommandSender sender, Command cmd, String commaneLabel, String[] args )
{
  if( cmd.getName().equalsIgnoreCase( "weather" ) )
  {
    if( args.length > 0 )
    {
      if( args.length > 1 )
      {
        World w = getServer().getWorld( args[1] );
      }
      else if( sender instanceof Player )
      {
        World w = ( (Player) sender ).getLocation().getWorld()(
      }
      else
      {
        sender.sendMessage( "As console you should provide the world to change the weather." );
        return true;
      }
      switch( args[0].toLowerCase() )
      {
        case "rain":
          w.setThundering( false );
          w.setStorming( true );
          break;
        case "sun":
          w.setThundering( false );
          w.setStorming( false );
          break;
        case "storm":
          w.setThundering( true );
          w.setStorming( true );
          break;
    }
    else
    {
    sender.sendMessage( "Missing weather argument." );
    }
  }
}

Not tested, wrote on ma phone.

 

I fixed it to make it look nicer. Thanks for the advice.

I think you made a mistake with "if(args[0].equalsIgnoreCase("rain"));", I think there's supposed to be "{" after "("rain"))", everything else was good, thanks for the advice, I still have yet to test it.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Ok, no problem.

 

Keithman3 Just take a good look at the plugin.yml. then take a good look at the main class' package and name. It should come to you...

 

Rocoty LOL. You were the only one to spot the error.

 

Oh my gosh, you were right! That was such a stupid error... I'll fix it.

 

Keithman3

maybe also try removing these public static void main(String[] arguments) { I think its not your intention to run it appart from bukkit like a executable?

ofc thats may not the issue though, can you post any error/exceptions if they still persists?

 

Fixed.

 

It worked! Thank you to everyone for your help.

Code:java

System.out.println("Thank you very much!");

(I think that was right... )