Fastest way to update scoreboards

Hi there!

Thanks for clicking in on my thread - i got some problems with updating my scoreboards.

I'm running a scheduler

Code:java

 BukkitScheduler scheduler = Bukkit.getServer().getScheduler();
scheduler.scheduleSyncRepeatingTask(this, new Runnable() {
@Override
public void run() {
for(Player player : Bukkit.getServer().getOnlinePlayers()){
Scoreboards.initializeScore(player);
}
}
}, 0L, 20L);

which updates the score here

Code:java

 public static void initializeScore(Player player){
ScoreLib scoreboard = new ScoreLib(player.getName());
scoreboard.add("Penger:", ValueGetters.getCoins(player));
scoreboard.add("EXP:", ValueGetters.getEXP(player));
scoreboard.add("Nivåer:", ValueGetters.getLevels(player));
 
scoreboard.build();
scoreboard.send(player);
}

using @RainoBoy97's lib, but i'm 100% sure it's not because of his library. I'm getting the information from a MySQL-server when the player's log in and putting it in a hashmap(not seen here):

Code:java

 public static void getCoinsFromDB(UUID uuid) {
try {
Connection conn = DriverManager.getConnection(url, user, pass);
Statement statement = conn.createStatement();
ResultSet res = statement
.executeQuery("SELECT * FROM verdier WHERE uuid='" + uuid
+ "';");
while (res.next()) {
if (res.getString(6) == null) {
ValueGetters.coins.put(uuid, 0);
} else {
ValueGetters.coins.put(uuid, res.getInt(6));
}
}
statement.close();
conn.close();
} catch (SQLException e) {
e.printStackTrace();
}
}

I also have getEXPFromDB and getLevelsFromDB with almost the same code.

Now, every time i get information from the hashmaps

Code:java

 public static HashMap<UUID, Integer> coins = new HashMap<UUID, Integer>();
public static HashMap<UUID, Integer> EXP = new HashMap<UUID, Integer>();
public static HashMap<UUID, Integer> levels = new HashMap<UUID, Integer>();

it starts to lag a looot. The server is unusable for a few seconds. This is every time the scheduler runs.

I tried to run it ASynchroblabla, but then it just spews out alot of errors.

Any ideas?

Thanks

 

Isn't it just easier to use the Bukkit's scoreboard API

 

jimbo8 you need to run your SQL async. If you get errors, post those instead.

As a sidenote, stop abusing static.

 

fireblast709

Hmm, okay. I'll try to run SQL ASync and get back to you guys with it.

Also, i use static because i'm lazy I never really understood why i shouldn't use it.

fireblast709
Okay, so i didn't really think that much when i answered you.

The SQL-queries are only ran on player login and logoff. When they log in, their information gets saved into a HashMap, when they log off it's the opposite.

So the information i'm getting when initializing the score is from a hashmap.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Java is OOP, essentially static defeats this purpose.

 

A shameful little bump.

 

Try using Bukkit Scoreboard API instead of using a lib.
If it's still lagging, tell us.

 

I tried using the Bukkit scoreboard API exactly the same way as this lib works, but it still lags. Thanks for leaving an answer, though Dealyise

 

jimbo8
I think I know why it lags. You are putting players in a HashMap with a Scheduler. synchronized() could fix your lags.
I am not 100% sure, but this might help

 

Where would i put the synchronized?

I haven't used that function before.

Dealyise
Nevermind. I'm stupid.

It works a bit, it lags less, but still a bit too much :/

 

jimbo8
You got Skype? If so, write me your name.

 

Of course,
thomasd98

Dealyise

 

jimbo8
Added.