Death messages not working?

Hey, so i have:
@EventHandler
public void death(PlayerDeathEvent e) {
Player p = e.getEntity().getPlayer();
Player k = e.getEntity().getKiller();
e.setDeathMessage(null);
k.sendMessage(ChatColor.AQUA + "You killed " + ChatColor.YELLOW + p.getName());
p.sendMessage(ChatColor.AQUA + "You were killed by " + ChatColor.YELLOW + k.getName());

in my plugin but the messages aren't working, any help?

 

Registered your events?

 

SkyLarkPvP casting player to player.. Not checking if killer is null before casting.. Make sure you also fix that.

 

Necrodoom and tommyhoogstra sorry, but how would i do that? I'm kind of new in coding.

would this help?
@EventHandler
public void death(PlayerDeathEvent e) {
Player p = e.getEntity().getPlayer();
Player k = e.getEntity().getKiller();
if(k != null) e.setDeathMessage(null);
e.setDeathMessage(null);
k.sendMessage(ChatColor.AQUA + "You killed " + ChatColor.YELLOW + p.getName());
p.sendMessage(ChatColor.AQUA + "You were killed by " + ChatColor.YELLOW + k.getName());

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

No, you dont need e.getEntity().getPlayer();
You can do Player p = e.getPlayer();
and Player k = p.getKiller();

To register your events, you need this in your onEnable

Code:

 Bukkit.getPluginManager().registerEvents(this, this);

 

I'm sorry... I just couldn't let this go on...

Code:java

public void death(PlayerDeathEvent e) {
  if(e.getKiller() instance of Player {
    Player p = e.getPlayer();
    Player k = e.getKiller();
    k.sendMessage(ChatColor.AQUA + "You killed " + ChatColor.YELLOW + p.getName());
    p.sendMessage(ChatColor.AQUA + "You were killed by " + ChatColor.YELLOW + k.getName());
  }
}
 

Oh, and you can remove the death message in there if you'd like, forgot to add that.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

xYourFreindx You do realize that the killer can only be a Player, making the instanceof (not instance of) check useless. A null check would be more appropriate.

 

xTigerRebornx Soz. And yes I know it's instanceof, my mac autocorrected that. Soz OP.
But no I didn't know that the killer could only be a player. I assumed it could be any LivingEntity considering it is called onPlayerDeath event, and a player can die in more ways that just by a player. Obviously, if what you say is true, then the getKiller() method checks to see if there even was a killer, all by itself. I did not want to assume it did that, so as to avoid a possible NPE, I checked first. Just habit.

Could you post the error that ^ gives you?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

xYourFreindx
I deleted the player check, now i'm getting an error "add cast to e":
Player p = e.getPlayer();
and i don't know what you mean by that

 

The stack trace.

Post the error message you get in console when you use the code I gave you.

 

xYourFreindx
Im not sure what you mean by that, but:
insert ") Statement" To complete Block statements
The method GetPlayer() is undefined for the type PlayerDeathEvent
The method GetKiller() is undefined for the type PlayerDeathEvent

 

SkyLarkPvP make the G's lowercase in "Get"

 

still getting the same error message

 

SkyLarkPvP can you post the whole startup log into pastebin.com ?

 

A quick look at the java docs reveals that getPlayer() and getKiller() are not even valid methods for the PlayerDeath event......

To make things easier, would you know what to do if I asked you to use the EntityDamageByEntity event? Or would I have to write it out for you in order to get you to do that?

 

xYourFreindx, to be honest, i would not know what to do
sorry i'm new to coding.

 

SkyLarkPvP ignore the code xYourFreindx gave you, its completely flawed, head back to http://forums.bukkit.org/threads/death-messages-not-working.301224/#post-2730524
And do what tommyhoogstra told you to fix.

 

Necrodoom Could you explain to me how e.getKiller and e.getPlayer work? I looked at the javadocs, and they aren't there.

 

xYourFreindx that's because they don't.
The method is getEntity to get the player, and the getKiller is a livingentity method.

 

SkyLarkPvP

I'm just as confuse about the getKiller thing (if not more) than you are....
So I threw this together....

Code:java

 
    ArrayList<UUID> death = new ArrayList<UUID>();
    @EventHandler
    public void death(PlayerDeathEvent e) {
          if(death.contains(e.getEntity().getUniqueId())){
              e.setDeathMessage(null);
              death.remove(e.getEntity().getUniqueId());
              }
            }
    @EventHandler
    public void death(EntityDamageByEntityEvent e){
        if(e.getEntity() instanceof Player && e.getDamage() >= ((Damageable) e.getEntity()).getHealth() && e.getDamager() instanceof Player){
            Player player = (Player) e.getEntity();
            Player killer = (Player) e.getDamager();
            death.add(player.getUniqueId());
            killer.sendMessage(ChatColor.AQUA + "You killed " + ChatColor.YELLOW + player.getName());
            player.sendMessage(ChatColor.AQUA + "You were killed by " + ChatColor.YELLOW + killer.getName());
        }
    }

Sorry for any confusion I caused, I haven't tested this ^ so if it works, be sure to yell back to me. The only part I can see not working is the e.getDamage() >= ((Damageable) e.getEntity()).getHealth() part... But let's hope for the best.

Necrodoom So.... You'd need to cast living entity to the player that was killed in order to use that meathod?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

xYourFreindx please stop spoonfeeding useless code.
Post #5 was good enough with tommyhoogstra suggestions.
Also, player is already a livingentity...

 

Necrodoom Useless code? I worked a good 3 minutes on that. Have you even tested it? What about it is useless? I must admit I'm insulted. Have you even looked at it?

e.getEntity().getKiller() does not work. Not in my eclipse. And getEntity is supposed to return a player. If I'm not mistaken. So where have I gone wrong?

 

What I use to get the killer rom the death event :

Code:java

@EventHandler
public void onPlayerDeath(PlayerDeathEvent e) {
Player p = (Player) e.getEntity();
EntityDamageEvent deathCause = p.getLastDamageCause();
if (deathCause.getCause() == EntityDamageEvent.DamageCause.ENTITY_ATTACK) {
Entity entity = ((EntityDamageByEntityEvent) deathCause)
.getDamager();
if (entity.getType() == EntityType.PLAYER) {
// Do what you gotta do
}
}
}

Hope that helps!

 

xYourFreindx http://jd.bukkit.org/rb/apidocs/org/bukkit/entity/LivingEntity.html#getKiller()

 

Necrodoom Yes yes, I've seen that already. It is not helpful to me. My problem resides in the fact that I have taken no java courses and use bukkit as a crutch to get around java related problems. Since I'm self taught, I'm always looking for ways to better understand a situation so that the crutch isn't needed, and I can take that knowledge with me into my coding and to other people.
If you don't want to give me a detailed answer, then I don't blame you... But I will never understand with what limited information you're giving me.

 

xYourFreindx The point being made was that Entity does not have #getKiller() but LivingEntity does - in response to "e.getEntity().getKiller() does not work. Not in my eclipse."

 

_LB
I this event... e.getEntity() is supposed to return a player, which, is already a living entity. My confusion is why .getKiller does not work for THAT living entity.

Would I have to first cast e.getEntity() to living entity and then get the killer is the question I asked a few posts ago.

EDIT: Oh, and Why? Why is the most important question.

 

_LB http://jd.bukkit.org/rb/apidocs/org/bukkit/event/entity/PlayerDeathEvent.html#getEntity()

 

There appears to be a big fight while i was gone...
I managed to get it working with
my onEnable: Bukkit.getPluginManager().registerEvents(this, this);

and this
@EventHandler
public void kill(PlayerDeathEvent event) {
Player p = event.getEntity();
Player k = p.getKiller();
event.setDeathMessage(null);
k.sendMessage(ChatColor.AQUA + "You killed " + ChatColor.YELLOW + p.getName() + "!");
p.sendMessage(ChatColor.AQUA + "You were killed by " + ChatColor.YELLOW + k.getName() + "!");

The problem is, when ever someone dies from something else, e.g: a spider, the server console has a big error report, any suggestions on how to fix that?