Basic plugin to block a command. Just a bit of help needed.

Here's the main class:

Code:java

 
package me.jay232323;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.plugin.java.JavaPlugin;
 
public class PreventLookAtPlugins extends JavaPlugin{
 
@Override
public void onEnable() {
new PlayerListener(this);
}
 
@Override
public void onDisable() {
 
}
}
 
 

In onEnable, it references this class, where the majority of code is:

Code:java

 
 package me.jay232323;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
 
public class PlayerListener implements Listener {
 
        @EventHandler
        public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
 
            if (cmd.getName().equalsIgnoreCase("plugins") && sender instanceof Player) {
 
                Player player = (Player) sender;
 
                event.setCancelled(true);
 
                player.sendMessage("Only the console may use this command.");
            }
                return false;
    }
}
 

In the second block of code, the line of code:

Code:java

event.setCancelled(true);

is getting the error that event cannot be resolved. I'm extremely new to this, so I apologize in advance for being incompetent. I've Googled it up and down and can't find it for the life of me. I've also consulted three friends, and none of them can figure it out either, so I'm coming to you guys.

 

onCommand is not an event.... I recommend you learn more about the BukkitAPI before doing this. If you'll use an event to block a certain command use the CommandPreProccess event.

 

Commands aren't events.

 

Monkey_Swag
Well, I don't know if I'm getting closer or farther, but this is what I've got.

Code:java

 
public class PlayerListener implements Listener {
 
@SuppressWarnings("null")
@EventHandler
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
 
if (cmd.getName().equalsIgnoreCase("plugins") && sender instanceof Player) {
 
Player player = (Player) sender;
 
PlayerCommandPreprocessEvent event = null;
 
event.setCancelled(true);
 
player.sendMessage("Only the console may use this command.");
}
return false;
}
 
}
 

 

Jay23 don't do plugins like these if you're not skilled enough to do them. You should know how to make events from commands. You can't do event.setCancelled(); if it's not an event. Commands ARE NOT EVENTS.

 

Jay23 Can't tell if serious or just Cory.

Jay23 bare with me, I'm going to write this on my phone.

Code:java

 
public class PlayerListener implements Listener {
    @EventHandler
    public void onCommandProcess(PlayerCommandPreprocessEvent event) {
        if (event.getMessage().startsWith("/") {
            String command = event.getMessage().split(" ")[0].replace("/", "");
 
            if (command.equalsIgnoreCase("plugins") {
                event.setCancelled(true);
                event.getPlayer().sendMessage("You cannot do that");
            }
        }
    }
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Goblom please remove that. Spoonfeeding him won't work, at all, especially in his state.

 

Monkey_Swag I spoon feed, get over it.

 

Goblom It's just not right :/ He will always come and look for people to do plugins for him and not give them any credit once it's finished...

 

Goblom

Code:java

    @EventHandler
    public void onCommandProcess(PlayerCommandPreprocessEvent event) {
        if (event.getMessage().startsWith("/") {
            String command = event.getMessage().split(" ")[0].replace("/", "");

What is this accomplishing?

Monkey_Swag
Where would you suggest I start? What type of plugins should I work on to develop my skills? I'm kinda using the sink-or-swim tactic on myself here.

 

Jay23 Read javadocs, look through the plugin development help forum and look at others' posts. That's what I would do. On my way to school and back I would just go on my phone and look at others' threads and learn new things from them. Another thing you could do is watch basic plugin tutorials on youtube. However, that is not completely recommended since it is spoonfeeding, but whatever suits you.

 

Jay23 the if statement is checking if is a command because commands always start with a "/" otherwise it's a message.

The next part is splitting the message by spaces because commands can have arguments, it's then getting the absolute first word in an array, then it is removing the "/" from the command.

 

Wouldn't event#getMessage()#startsWith("/plugins") be easier?

 

Goblom
So it just makes them say "plugins" in chat by removing the slash?

Monkey_Swag
Wow, never thought of that before. That's a really good idea, thanks!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

But what about this?

Code:java

String command = event.getMessage().split(" ")[0].replace("/", "");

Does it remove the slash, then run event.setCancelled(true); to prevent them from sending the message in chat?

 

Monkey_Swag I was thinking this was is simpler because you could then check equals ignore case multiple times instead of starts with... Just seemer simpler to me

 

Ok, instead of spoon-feeding you, I'll run you through this.
First we want to use an @interface in order to say "Hey, this block of code needs to occur when this event occurs" so we add an

Code:java

@EventHandler

above the method. Then we want to declare that this method is public and it doesn't return anything so we start with

Code:java

@EventHandler
public void

Now we want to name the method so when we look back at it we know what it does. Here we want the event to be called when a command is sent so we'll name it onCommandSend

Code:java

@EventHandler
public void onCommandSend()

Now we need to give the event we want the block of code called with. So we're going to use the PlayerCommandPreprocessEvent and call the instance event.

Code:java

@EventHandler
public void onCommandSend(PlayerCommandPreprocessEvent event)

Now we're going to give the actual code that is executed so we need to add some brackets.

Code:java

@EventHandler
public void onCommandSend(PlayerCommandPreprocessEvent event){
 
}

First, we want to check that the message in the chat(that will execute the command) starts with "/plugins" because that indicates it is the command we want to block so we do.

Code:java

@EventHandler
public void onCommandSend(PlayerCommandPreprocessEvent event){
    if(event.getMessage().startsWith("/plugins"){
 
    }
}

Then we want to cancel the event so it doesn't do anything. So we'll do:

Code:java

@EventHandler
public void onCommandSend(PlayerCommandPreprocessEvent event){
    if(event.getMessage().startsWith("/plugins"){
        event.setCancelled(true);
    }
}

Next we'll send the player a message that says they can't use that command so we'll do:

Code:java

@EventHandler
public void onCommandSend(PlayerCommandPreprocessEvent event){
    if(event.getMessage().startsWith("/plugins"){
        event.setCancelled(true);
        event.getPlayer().sendMessage("You can't use that!");
    }
}

Now we're done. Not hard, really.

 

Jay23 it does not edit the message in any way, the command is still being sent, that is just getting what command is being ran.

The event.setCancelled(true); is what is actually stopping the command from being ran in the first place

 

JBoss925
Wow, that's perfect, thank you so much!

JBoss925
Well, I entered the code and tested it, and it's still not working. It's not displaying the message or stopping the command from going through. Could it be that it's not as high of a priority as the other process? It's just ignoring it because the /plugins command it the higher priority of some sort? Just speculating here.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You didn't register the event with bukkit...

 

The_Coder
Ah, got it! Thank all of you so much for putting up with my newbie crap! I really do appreciate it!

Goblom
Could I replace

Code:java

if(event.getMessage().startsWith("/plugins")

with

Code:java

if(event.getMessage().equalsIgnoreCase("/plugins"))

so they can't type /PLUGINS to bypass the plugin?

Edit: Yes. Yes I can.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I don't understand the point of this thread. You can disable access to that command with a permission node:
http://wiki.bukkit.org/CraftBukkit_commands
bukkit.command.plugins

 

_LB
You don't even have to do that. Just check if the sender is an instance of a Player. If it isn't, then its either Console, or a CommandBlock.

 

Jay23 techically you can, but they can easily get around that by doing "/plugins " (notice the space at the end)

 

Goblom

Then how could I implement both of them?

 

You may want to reread my post - my solution involves writing 0 lines of code.

 

_LB
True. Good point.

 

Goblom

Code:java

if(event.getMessage().equalsIgnoreCase("/plugins") || event.getMessage().startsWith("/plugins"))

 

Convert the string to lower case first, then use #startsWith. Or, you know, read my earlier post to find out how to do this in 0 lines of code.