Solved error with OnPlayerDeath Event

Code:java

 
@EventHandler
public void onPlayerDeath(final PlayerDeathEvent e){
Player player = e.getEntity().getPlayer();
cooldown.remove(player.getName());
}

with that code I get an error on e and the parentheses after with a "; expected" and "Unexpected token" I also get these errors with final "; expected" and "Expression Expected"
Please help!

 

drpk
Are you closing that method with a }?

 

DannyDog Oh yeah, I have, but I hastily copied and pasted it

 

Make sure 'cooldown' is a list of strings.

 

drpk
Not sure what kind of error you're getting, I copy and pasted that in my ide and there's no errors?

 

messageofdeath I made it an arraylist

 

drpk
But it needs to store a string.
An arrayList can store objects too.
So List<String>

 

this is my code

Code:java

package me.drpk.GKits;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
import java.util.ArrayList;
 
/**
* Created by USER on 7/24/2014.
*/
public class Poseidon implements Listener {
 
static ArrayList<Player> cooldown = new ArrayList<Player>();
 
@EventHandler
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
if (!(sender instanceof Player)) {
sender.sendMessage(ChatColor.RED + "Only players can get kits!");
return true;
}
 
final Player p = (Player) sender;
PlayerInventory pi = p.getInventory();
 
if (cmd.getName().equalsIgnoreCase("Poseidon")) {
if (cooldown.contains(p)) {
p.sendMessage(ChatColor.RED + "You cannot get another kit yet!");
return true;
}
if (cooldown.contains(p)) {
pi.addItem(new ItemStack(Material.IRON_SWORD, 1));
pi.addItem(new ItemStack(Material.IRON_PICKAXE, 1));
public void onPlayerMove (final PlayerMoveEvent evt){
Material m = evt.getPlayer().getLocation().getBlock().getType();
if (m == Material.STATIONARY_WATER || m == Material.WATER) {
 
p.addPotionEffect(new PotionEffect(PotionEffectType.WATER_BREATHING, 10, 1));
p.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 10, 1));
p.addPotionEffect(new PotionEffect(PotionEffectType.INCREASE_DAMAGE, 10, 1));
p.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 10, 1));
 
 
}
p.sendMessage(ChatColor.GREEN + "You got your kit!");
cooldown.add(p);
 
 
return true;
}
if (cooldown.contains(p)) {
p.sendMessage(ChatColor.RED + "You cannot get a kit at this time.");
return true;
}
 
}
}
}
 
 
 

this is my Death Event class

Code:java

package me.yarocks.kits;
 
import me.yarocks.kits.Poseidon;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.entity.PlayerDeathEvent;
 
 
/**
 * Created by USER on 7/24/2014.
 */
public class DeathEvent{
public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
    public void onPlayerDeathEvent(PlayerDeathEvent evt){
        final Player p = (Player) sender;
        Poseidon.cooldown.remove(p);
 
    }
    }
}

 

drpk
Line 45.
You have a event method inside the onCommand method.
Close the onCommand using }'s and add @EventHandler above your onPlayerMove method.
Also you'd need to assign the player to a variable in your onPlayerMove method
So Player p = evt.getPlayer();

 

Code:java

 
 
death event inside of onCommand..?

 

Code:java

 
 
Make the ArrayList a public static ArrayList<Player> instead of static ArrayList<Player>, because if you don't say it's public, only that class will be able to access it

 

drpk
Cannot make a method inside a method silly.

Actually classes in the same package as that class will be able to access it unless declared private.

 

What?...?

 

LCastr0
You shouldn't encourage the usage of statics where statics aren't necessary. The list could be stored in the plugin's main class and passed by reference to the CommandExecutor and the Listener without accessing it in a static context.

 

my original problem is back

Code:java

package me.drpk.GKits;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
import java.util.ArrayList;
 
/**
* Created by USER on 7/24/2014.
*/
public class Poseidon implements Listener {
 
static ArrayList<Player> cooldown = new ArrayList<Player>();
 
@EventHandler
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
if (!(sender instanceof Player)) {
sender.sendMessage(ChatColor.RED + "Only players can get kits!");
return true;
}
 
final Player p = (Player) sender;
PlayerInventory pi = p.getInventory();
 
if (cmd.getName().equalsIgnoreCase("Poseidon")) {
if (cooldown.contains(p)) {
p.sendMessage(ChatColor.RED + "You cannot get another kit yet!");
return true;
}
if (cooldown.contains(p)) {
pi.addItem(new ItemStack(Material.IRON_SWORD, 1));
pi.addItem(new ItemStack(Material.IRON_PICKAXE, 1));
 
 
public void onPlayerMove(final PlayerMoveEvent evt){
Material m = evt.getPlayer().getLocation().getBlock().getType();
if (m == Material.STATIONARY_WATER || m == Material.WATER) {
 
p.addPotionEffect(new PotionEffect(PotionEffectType.WATER_BREATHING, 10, 1));
p.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 10, 1));
p.addPotionEffect(new PotionEffect(PotionEffectType.INCREASE_DAMAGE, 10, 1));
p.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 10, 1));
 
 
}
p.sendMessage(ChatColor.GREEN + "You got your kit!");
cooldown.add(p);
 
 
return true;
}
if (cooldown.contains(p)) {
p.sendMessage(ChatColor.RED + "You cannot get a kit at this time.");
return true;
}
 
}
}
}
 

line 47 semicolon expected after the onPlayerMove and unexpected token on the parentheses after evt :/

 

drpk Thats because you are still trying to fit a method inside a method, which doesnt make sense and is impossible in java.
Your mistakes show that you dont have much experience with java, you may want to read up on a basic java tutorial before proceeding, such as the oracle java tutorial.

 

> Methods inside methods.
> Questionable cooldown practices.
> Player lists.
> Unnecessary use of static.
> Syntax errors.

It's like the whole section wrapped up in one thread...

 

Garris0n All that is left is someone spoonfeeding incorrect code without explanation.

 

Garris0n

Show Spoiler Hide Spoiler

Show Spoiler Hide Spoiler

Show Spoiler Hide Spoiler

Show Spoiler Hide Spoiler

Show Spoiler Hide Spoiler

Methodception

 

DannyDog

 

ChipDev
Oh yea, didn't see that, but i think OP knows now.