Inventory Help

Hi

Im trying to make a plugin that converts gold that you pick up into money. I need the gold to be taken from you as soon as you pick it up, this code wont work, any suggestions?

Code:java

 @EventHandler
public void onPickUp(PlayerPickupItemEvent e){
Player p = e.getPlayer();
if(e.getItem().getItemStack().getType().equals(Material.GOLD_INGOT)){
p.sendMessage("you picked one up");
ItemStack g = e.getItem().getItemStack();
int amt = g.getAmount();
p.getInventory().remove(Material.GOLD_INGOT);

 

bobthefish
"This code won't work" is a very broad statement. Was there any errors in the console? Did you register the event?

 

Yeah, What is not working? remove the gold? The event? add the money?
Show us some errors

 

Drew1080 1) the bug in your signature totally got me, I thought it was real and spent a little while trying to squish it xD
2) I am sorry for being so broad Im tired and wasnt thinking straight. Everything in that block of code works, except that it wont remove the gold. there are not errors in the console. I have just found out that I seems to work for every piece of gold you pick up, after the first one, so the fist stack is always there but it clears all consecutive stacks, if that makes any sense. thanks for your help

anybody help me?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

bobthefish Try using

Code:java

p.updateInventory();

after removing the gold

 

Im not sure but maby you can try
After you got the amount then just?
e.getItem().remove();
Maby that will work?

 

Necrodoom

 

I think you can't remove the itemstack from the inventory in the PlayerPickupItemEvent, because the itemstack is not in the inventory at this moment. Try to remove the item on the floor and cancel the event

 

stonar96
He can do e.getItem().remove(); ? Then it will take the item that is picked up.
bobthefish stonar96 is right!
You cant remove that gold becaus when you trigger the event it isnt in the inventory it is on his wat to the inventory.

 

TheLegendOffPabu Yes I think so. (not tested)

 

bobthefish I already had this kind of problem, so this is the code I used for my emerald money system (sorry it's in french)

Code:java

@EventHandler
    public void onPickup(final PlayerPickupItemEvent event) {
        if (event.getItem().getItemStack().getType() == Material.EMERALD) {
            final Player p = event.getPlayer();
            final ItemStack[] items = p.getInventory().getContents();
            final List<ItemStack> items_ = new ArrayList<ItemStack>();
            int iMoney = 0;
            for (final ItemStack item : items) {
                if (item != null) {
                    if (item.getType().equals(Material.EMERALD)) {
                        items_.add(new ItemStack(Material.AIR, 1));
                        iMoney += item.getAmount();
                    } else {
                        items_.add(item);
                    }
                } else {
                    items_.add(null);
                }
            }
            p.getInventory().setContents(
                    items_.toArray(new ItemStack[items_.size()]));
            Functions.setMoney(p, Functions.getMoney(p) + (iMoney * 10));
            Functions.updateMoney(event.getPlayer());
            p.sendMessage(ChatColor.GOLD
                    + "<MONEY> Vous avez trouvé de l'argent !");
            p.updateInventory();
            new BukkitRunnable() {
                @Override
                public void run() {
                    final Player p = event.getPlayer();
                    final ItemStack[] items = p.getInventory().getContents();
                    final List<ItemStack> items_ = new ArrayList<ItemStack>();
                    int iMoney = 0;
                    for (final ItemStack item : items) {
                        if (item != null) {
                            if (item.getType().equals(Material.EMERALD)) {
                                items_.add(new ItemStack(Material.AIR, 1));
                                iMoney += item.getAmount();
                            } else {
                                items_.add(item);
                            }
                        } else {
                            items_.add(null);
                        }
                    }
                    p.getInventory().setContents(
                            items_.toArray(new ItemStack[items_.size()]));
                    Functions
                            .setMoney(p, Functions.getMoney(p) + (iMoney * 10));
                    Functions.updateMoney(event.getPlayer());
                    p.updateInventory();
                }
            }.runTaskLater(Plugin, 1);
        }
    }
 

It's kind of barbarian but tag me if you want more informations ;-)

DevilMental

 

stonar96 TheLegendOffPabu dsouzamatt I tried the p.updateInventory(); no effect. The not being able to remove it part makes sense if I think about it I guess

DevilMental I understand pert of your code, however could you maybe highlight/comment around the part where you remove the item from the inventory? and all the parts that go into it, im not worried about the money stuff, my money part works for me right now

 

bobthefish Actually, you need to make a BukkitRunable that runs 1 tick after the event, to loop into every item and remove one of them, because when the event is run, the gold ingot is not in your inventory yet.

Tag me if it seems a bit complicated, I will spoonfeed you code ;-)
~ DevilMental

 

DevilMental while being spoon fed code would be easy, I would like to try and stay away from that, but basically what happens is that you schedule it for 1 tick later, which is when it is part of your inventory? is that what happens?

 

bobthefish 1 tick later the item is actually in the inventory, unlike on the event where the item is not.

 

bobthefish i didn't write that you should do p.updateInventory(); It's completely clear that this has no effect. I said you should just cancel the event and remove the item, not the itemstack from the inventory, because the itemstack is not in the inventory durring the PlayerPickupItemEvent

 

Code:java

p.getInventory().remove(Material.GOLD_INGOT);

Shouldn't that be p.getInventory().removeItem(ItemStack); ?
I don't even think that works...

 

stormneo7 I know it doesnt work, but Im not sure what Im supposed to use, everyone is saying that you cant remove the itemstack because it isnt in the inventory yet

 

Might I ask you, what's your economy plugin? How do you give a player money? /eco give [PlayerName] [Amount] correct?

Here try this.

Code:java

@EventHandler
public void onPick(PlayerPickupItemEvent evt){
    if(evt.getItem().getItemStack().getType() == Material.GOLD_INGOT){
        final Player p = evt.getPlayer(); // Define the Player Triggering the Event
        ItemStack item = evt.getItem().getItemStack().clone(); // Gets the ItemStack of the Event and Clones It
        evt.setCancelled(true); // Cancels the Event
        evt.getItem().remove(); // Removes the Item
        int AmountOfIngots = item.getAmount(); // Amount of Ingots
        p.sendMessage(ChatColor.GREEN + "You have picked up " + AmountOfIngots + " gold pieces!"); // Sends the player a message
        p.getServer().dispatchCommand(p.getServer().getConsoleSender(), "eco give " + p.getName() + " " + AmountOfIngots);
        // Dispatches a command from console. In this case, the command was ["eco give " + p.getName() + " " + AmountOfIngots].
        // What we've done here, the console would do [eco give stormneo7 30] if my name was stormneo7 and there were 30 ingots that I picked up.
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

stormneo7 Ok, I will try that, but for the sake of knowledge, why do you clone the item stack?

stormneo7 It works! THANK YOU! but I would still like to know why...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

idk It's more of a muscle memory than a theory. I just prefer to clone things when I get the chance so the default variables don't change.

 

I am using a custom economy, I store the money in a players.yml and give it straight to them