Solved Shoot fishingline out of leash (Grappler)

Hi everyone,
I know there are already over 20 posts about grappler but i still cant figure out why mine doesnt work. This is my code (yes most of it is based on code from others):

Code:java

import org.bukkit.Location;
  import org.bukkit.craftbukkit.v1_7_R1.CraftWorld;
  import org.bukkit.entity.Player;
 
  import net.minecraft.server.v1_7_R1.EntityFishingHook;
  import net.minecraft.server.v1_7_R1.Item;
  import net.minecraft.server.v1_7_R1.ItemStack;
 
  import org.bukkit.craftbukkit.v1_7_R1.entity.CraftPlayer;
 
  public class LeashRod extends EntityFishingHook {
      private Item item;
 
      public LeashRod(Player player, Item item2){
          super(((CraftWorld) player.getWorld()).getHandle(), ((CraftPlayer) player).getHandle());
          item2 = this.item = item2;
      }
      @Override
      public void h(){
          if(item != null){
              ItemStack hand = this.owner.bD();
              boolean shouldRemove = false;
 
              if(this.owner.dead || !(this.owner.isAlive())){
                  shouldRemove = true;
              }
 
              if(hand == null){
                  shouldRemove = true;
              } else {
                  if(hand.getItem() != item){
                      shouldRemove = true;
                  }
              }
 
              if(this.e(this.owner) > 1024.0D){
                  shouldRemove = true;
              }
 
              if(shouldRemove){
                  super.die();
                  super.owner.hookedFish = null;
              }
          }
      }
 
      public void spawn(Location loc){
          net.minecraft.server.v1_7_R1.World nmsWorld = ((CraftWorld) loc.getWorld()).getHandle();
 
          nmsWorld.addEntity(this);
          this.setPosition(loc.getX(), loc.getY(), loc.getZ());
      }
  }

Code:java

public void onPlayerFish(PlayerFishEvent e){
      Player p = e.getPlayer();
      if(kitGrappler.contains(p.getName())){
          if(e.getState() == State.CAUGHT_ENTITY){
              grappleTo(p, e.getCaught().getLocation());
          }else if(e.getState() == State.IN_GROUND){
              grappleTo(p, e.getHook().getLocation());
          }else{
              p.sendMessage(ChatColor.RED + "The hook is not attached yet!");
              e.setCancelled(true);
          }
      }
  }
 
@EventHandler
  public void onInteract(PlayerInteractEvent event){
    Player p = event.getPlayer();
    Item item = (Item) net.minecraft.server.v1_7_R1.Item.REGISTRY.a("lead");
    if ((kitGrappler.contains(p.getName())) && (
    ((event.getAction() == Action.LEFT_CLICK_AIR) && (event.getMaterial() == Material.LEASH)) || ((event.getAction() == Action.LEFT_CLICK_BLOCK) && (event.getMaterial() == Material.LEASH)))) {
        event.setCancelled(true);
        LeashRod fish = new LeashRod(p, (net.minecraft.server.v1_7_R1.Item) item);
        Location location = p.getLocation();
        fish.spawn(location);
        Vector v = p.getLocation().getDirection().multiply(3);
        List<Entity> hooks = p.getNearbyEntities(2, 2, 2);
        for(Entity e : hooks){
            if(e.getType() == EntityType.FISHING_HOOK){
                e.setVelocity(v);
            }
        }
    }
  }
 
public static void grappleTo(Entity paramEntity, Location paramLocation){
        Location localLocation = paramEntity.getLocation();
        localLocation.setY(localLocation.getY() + 0.5D);
        paramEntity.teleport(localLocation);
        double d1 = -0.08D;
        double d2 = paramLocation.distance(localLocation);
        double d3 = d2;
        double d4 = (1.0D + 0.07000000000000001D * d3) * (paramLocation.getX() - localLocation.getX()) / d3;
        double d5 = (1.0D + 0.03D * d3) * (paramLocation.getY() - localLocation.getY()) / d3 - 0.5D * d1 * d3;
        double d6 = (1.0D + 0.07000000000000001D * d3) * (paramLocation.getZ() - localLocation.getZ()) / d3;
        Vector localVector = paramEntity.getVelocity();
        localVector.setX(d4);
        localVector.setY(d5);
        localVector.setZ(d6);
        paramEntity.setVelocity(localVector);
      }

There is no fishing line coming out of the leash. No errors. I hope someone can help me
~ jens

 

Two problems I see just in those classes.
1. Have you registered events? I dont know if anyone of those is your main class but you need to register events in your main class.

You can easily do this with implementing listener and:

Code:java

this.getServer.getPluginManager.registerEvents(this, this);
//However that is only registering for the main class. You have to register for your other classes aswell

2. On line 1 of the second java code you gave us, you did not put an

Code:java

@EventHandler

Above your onPlayerFishEvent.

 

MooshViolet
I will check this when i am back on my computer. I'm pretty sure i put the @EventHandler, just didn't paste it.
For registering it would be this.getServer().getPluginManager().registerEvents(LeashRod, this) ?

 

It would be getServer().getPluginManager().registerEvents(this, new Eventclassname());

 

Ok, sorry that i didnt reply earlier to this thread but i cant manage to register the events of the other class.
i tried, like d3v1n302418 said, to do

Code:java

getServer().getPluginManager().registerEvents(this, new LeashRod();

but that gave me red lines under "registerEvents" and "new LeashRod".
So when i hovered over it, Eclipse told me to fix it kinda like this:

Code:java

getServer().getPluginManager().registerEvents(this, (Plugin) new LeashRod(null, null));

It fixes the red lines but it doesnt work in-game. If anyone can tell me how i can register the events from my other class, plz do so! MooshViolet ?

 

Your code is really complicated :/. You could do it way easier.

 

Code0 k feel free to tell me. I searched pretty hard and most people say this: "Bukkit doesn't like spawning in fishing hooks without a fishing rod. You will need to override the h() method." But, if you really found an easy way to do this i would love to hear it!

 

jensdeboom
You are trying to code something with NMS but don't even know how to register events...

 

Dahwn can you tell me how to do it or are you just here to post stupid comments that don't help at all? I made pretty big things with bukkit and im not a beginner anymore. So i am trying to learn something new, but how am i supposed to learn something when someone like you comment these things. I think they made the forums for people that have questions about coding when they can't find an answer for their problem themselves, even if they its a really stupid problem. I've seen much more stupid questions and I don't think there is any need for posting comments like this. Thank you very much for your comment, it helped me a lot.

~ jens

 

jensdeboom

In your onEnable method:

Code:java

getServer().getPluginManager().registerEvents(new LeashRod(), this;

not

Code:java

getServer().getPluginManager().registerEvents(this, new LeashRod();

-Dahwn

 

Dahwn Thanks for helping me. You are probably not someone like i explained in my last pots , sorry for that. So if i do what you told me to do, it still gives me a red line under "new LeashRod()" and i told me to make it:

Code:java

getServer().getPluginManager().registerEvents(new LeashRod(null, null), this);

This probably sounds super noobish but when i registered my other classes before, it never told me to add these parameters. Does the null, null need to be there or did i do something wrong?

EDIT: My fish, interact and grappleto aren't in my LeashRod() class so why do i have to register events there? Does the h() method count as an event?
~ jens

 

jensdeboom
So this is probably the problem, I didn't read the first post good enough, I'm sorry, Hopefully you added to the class where you have Interact and PlayerFishEvent in "implements Listener" you have to register this class how I told you in the last post!:

Code:java

getServer().getPluginManager().registerEvents(new "yourlistenerclass"(), this;

-Dahwn

 

Dahwn ok but my events are in my main class. I already had it doing

Code:java

getServer().getPluginManager().registerEvents(this, this);

and my other events in the main class work. So there is probably something wrong with the LeashRod() class.
In my onEnable i just registered the events in the main class. Should i link the LeashRod() class to the main class in any other way you can think off?
~ jens

 

jensdeboom
What isn't working now? If it doesn't even spawn the custom hook then your LeashRod class isn't working. Then you will probably have to search another one.. I have a working one but I don't want to give it away because everyone wants grappler with lead!
-Dahwn

 

Dahwn yeah i understand that. I will try it again now and i will tell you if it works or not in 5 min.
~ jens

Dahwn It didn't work . I will try something else now. I will post my new code when im done

Dahwn i searched for some other methods but none of them worked. I felt like a read 738282 Posts and i was tired af. So i saw 1 other post and i was like, ok this is the last one. If this doesn't work grappler can ** **** *******. First i checked if the post was outdated but it was from a few days ago. I looked for the name and guess what his name was? Dahwn! Yep, i found your post. I fixed the problem you had with it (looked if damager was a projectile and if the shooter was = the entity) and i managed to get it working. Like 5 minutes after i fixed it. Someone just send me the exact code...Anyway, thanks everyone for your help!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

jensdeboom
See you only copy pasted it from me..
I should've deleted it!
You only stole my code -.-

 

Bump, I really want to see this complete

 

Dahwn your code was not working and someone send me the code anyway...you cant finish your code so why could i not use it? I fixed it and used it, yes.

 

jensdeboom
I fixed my code hahaha? btw. maybe I coded this on my own and don't want anyone else to use it?

mrgreen33gamer It's complete, thanks to copy paste my ideas! Can't even register events! gg

 

Dahwn lol? Are u kidding me? First, it turned out i didnt even have to register events from that class so ur stupid. And u cant (in your post) even check if the shooter of the damager = entity... But alright...ill use the other code now go cry a bit. Ty

 

jensdeboom You didn't post your whole code so I couldn't even see the whole system of your plugin, get ignored!

 

Can you guys send me a download link or something for this plugin? Or atleast show me the code and tell me how to compile it?