Solved Instasoup don't works....

my code:

http://pastebin.com/NaSPPMEs


one way or another it always fully heals me...
can someone tell me what is going on?

 

It should only fully heal you when your health is 10 or above, since your second if-statement isn't an else if-statement. You should also compare objects (which aren't constants) with the equals method, unless you, of course, want to compare their references

 

so i did changed it to else if, but it didn't work.
ik that ive not set @Eventhandler etc. but in eclipse i have.

Code:java

if (e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK) {
                    if(p.getItemInHand().getType() == Material.MUSHROOM_SOUP) {
                        if(p.getHealthScale() < 15) {
                            p.setHealth(p.getHealthScale() + 5);
                            p.getItemInHand().setType(Material.BOWL);
                    }
                        else if(p.getHealthScale() >= 15) {
                            p.setHealth(20);
                            p.getItemInHand().setType(Material.BOWL);
                    }
                }
                return;
            }
}

 

Check if the health is less then 20, and if so add 5 hearts to their health and remove the soup. If not, don't do anything. You're checking the scale of the health, which is checking if the player has less than 7.5 hearts (If I'm not mistaken). When you are adding health, do the player's health + 5

 

my new code:

Code:java

                if (e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK) {
                    if(p.getItemInHand().getType() == Material.MUSHROOM_SOUP) {
                        if(p.getHealthScale() < 20) {
                            p.setHealth(p.getHealth() + 5);
                            p.getItemInHand().setType(Material.BOWL);
                    }
                }
                return;
            }

doesn't work either, it dont heals me or give me a bowl...

 

Code:java

if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK) {
            double health = player.getHealth();
            if (mat == Material.MUSHROOM_SOUP) {
                ItemStack bowl = new ItemStack(Material.BOWL);
                if (health == 20) {
                    int food = player.getFoodLevel();
                    if (food == 20){
                        return;
                    }
                    int nfood = food + 7;
                    if (nfood > 20) {
                        player.setFoodLevel(20);
                    }
                    else {
                        player.setFoodLevel(nfood);
                    }
                    player.getInventory().setItem(player.getInventory().getHeldItemSlot(), bowl);
                    event.setCancelled(true);
                    return;
            } else {
                double nhealth = health + 7;
                if (nhealth > 20) {
                    player.setHealth(20);
                } else {
                    player.setHealth(nhealth);
                }
                event.setCancelled(true);
                player.getInventory().setItem(player.getInventory().getHeldItemSlot(), bowl);
                return;
            }
 
        }
    }

my code for instasoup - it works perfectly, but it's for 3.5 hearts of healing not 2.5.

 

thanks, ill try to use it tomorrow (im from the netherlands, thats why)

 

This code is overcomplicated and unneeded. I show mine when I get home.

 

Always use .equals() rather than == when comparing objects. Don't forget strings are objects.

 

no need to be rude. i'm a beginner. if it works perfectly, it doesn't really matter if it's unneeded.

 

omg thank you guys so much!
i've finally got it!

 

I'm not trying to be rude. I was trying to help out. (It might have sounded rude and I'm sorry) You need to learn how to make code simplier.

Code:java

 @EventHandler
public void OnPlayerSoup(PlayerInteractEvent event){
Player player = event.getPlayer();
if(player.getHealth() == 20){}
else
{
int soup = +7;
if((event.getAction().equals(Action.RIGHT_CLICK_AIR)  || event.getAction().equals(Action.RIGHT_CLICK_BLOCK)) && player.getItemInHand().getType().equals(Material.MUSHROOM_SOUP))
{
player.setHealth(player.getHealth() + soup > player.getMaxHealth() ? player.getMaxHealth() : player.getHealth() + soup);
event.getPlayer().getItemInHand().setType(Material.BOWL);
}
}
}