Solved My replace chat isn't working

it use to work fine but I cant figure out what happened.

Code:java

    @EventHandler(priority = EventPriority.HIGHEST)
    public void onChat(AsyncPlayerChatEvent e){
 
        Player p = e.getPlayer();
 
        if(plugin.getConfig().getString("Drunk") != null){
 
            if(plugin.getConfig().contains("Drunk." + p.getUniqueId().toString())){
                String d = e.getMessage();
                int dp = plugin.getConfig().getInt("Drunk." + p.getUniqueId().toString());
                HashMap<UUID, String> m = new HashMap<UUID, String>();
                m.put(p.getUniqueId(), d);
 
                String msg = m.get(p.getUniqueId());
 
 
                if(dp < 30 && dp > 19){
        //SLOW           
                    String t = msg.replaceAll("the","thee").replaceAll("this", "thiss").replaceAll("you", "yallls").replaceAll("lol", "lul").replaceAll("drink", "drunk");
                    m.put(p.getUniqueId(), t);
                }else if(dp > 49 && dp < 99){
        //SLOW AND CONFUSED
                    String t = msg.replaceAll("so", " *hick* ").replaceAll("lol", "I love my anus").replaceAll("this", p.getName()).replaceAll("why ", "I").replaceAll("its", "I'm"
                            ).replaceAll("the", "thuur").replaceAll("club", "the dancy place").replaceAll("milk", "more drinks").replaceAll("no", "yes");
                    m.put(p.getUniqueId(), t);
        //SLOW CONFUSION BLIDNESS       
 
                }else if(dp > 100 && dp < 149){
                    String t = msg.replaceAll("so", "...").replaceAll("lol", "crap I peed myself").replaceAll("this", p.getName()).replaceAll("why", "I").replaceAll("no", "yes").replaceAll("yes", "no").replaceAll("help", "I will kill you").replaceAll(
                            "ugh", "man I'm sexy").replaceAll("sucks", "rocks").replaceAll("fun", "furrn").replaceAll("guys", "I'm so alone").replaceAll("the", "thuur").replaceAll("why", "I think").replaceAll("drink", "strip").replaceAll("come here", "get lost").replaceAll("like", "hate")
                            .replaceAll("this", "diss").replaceAll("jk", "I'm serious");
                    m.put(p.getUniqueId(), t);
 
                }else if(dp > 150){
        //SLOW CONFUSION BLINDNESS NIGHTVISION
                    String t = msg.replaceAll("so", "...").replaceAll("lol", "crap I peed myself").replaceAll("this", p.getName()).replaceAll("why", "I").replaceAll("no", "yes").replaceAll("yes", "no").replaceAll("help", "I will kill you").replaceAll(
                            "ugh", "man I'm sexy").replaceAll("sucks", "rocks").replaceAll("fun", "furrn").replaceAll("bad", "hot").replaceAll("the", "thuur").replaceAll("why", "I think").replaceAll("drink", "strip").replaceAll("hi", "get lost").replaceAll("like", "hate")
                            .replaceAll("this", "diss").replaceAll("jk", "I'm serious").replaceAll("-", "").replaceAll("brb", "I'm so alone").replaceAll("afk", "I want you bad").replaceAll("great", "greatsss").replaceAll("lag", "white power").replaceAll("nuns", "buns").replaceAll(
                            "boone", "booze").replaceAll("funny", "getting really hot").replaceAll("stupid", "..Who touched me").replaceAll("omg", "I think your sexy").replaceAll("wow", "amuzing").replaceAll("see", "rape");
                    m.put(p.getUniqueId(), t);
                }else if(dp <20){
                    String t =msg.replaceAll(" ", "  ");
                    m.put(p.getUniqueId(), t);
        //NEAR SOBER       
                        }
 
 
                e.setMessage(m.get(p.getUniqueId()));
 
                }
            }
        }
 
 

I confirmed that the drunk points dp are entering correctly but it doesn't change any of the chat text anymore and I cant figure out why

 

Since you're doing all these things on an event instead of creating an HashMap on your class, you could just:

Code:java

if(<true if player is drunk>) {
String message = event.getMessage();
/*
* replace all thingies here, also, this is really creative IMO,
* didnt saw this anywhere and it must be fun to watch
* this on a big server
*/
event.setMessage(message);
}

 

rfsantos1996

Still not working even tho I made it simpler
and I have checked that the message does in fact change *broadcast shows changed message* e.setmessage(t) however does not and Ive changed the priority around and still no change

Code:java

    @EventHandler(priority = EventPriority.NORMAL)
    public void onChat(AsyncPlayerChatEvent e){
        Player p = e.getPlayer();
        if(plugin.getConfig().getString("Drunk") != null){
            if(plugin.getConfig().contains("Drunk." + p.getUniqueId().toString())){
                int dp = plugin.getConfig().getInt("Drunk." + p.getUniqueId().toString());
 
                String msg = e.getMessage();
 
                if(dp < 30 && dp > 19){
                Bukkit.broadcastMessage("slow");
                    String t = msg.replaceAll("the","thee").replaceAll("this", "thiss").replaceAll("you", "yallls").replaceAll("lol", "lul").replaceAll("drink", "drunk");
            //        Bukkit.broadcastMessage(t);
                    e.setMessage(t);
                    Bukkit.broadcastMessage(ChatColor.RED + t);
                }else if(dp > 49 && dp < 99){
        //SLOW AND CONFUSED
                    Bukkit.broadcastMessage("slow and confused");
                    String t = msg.replaceAll("so", " *hick* ").replaceAll("lol", "I love my anus").replaceAll("this", p.getName()).replaceAll("why ", "I").replaceAll("its", "I'm"
                            ).replaceAll("the", "thuur").replaceAll("club", "the dancy place").replaceAll("milk", "more drinks").replaceAll("no", "yes");
            //        Bukkit.broadcastMessage(t);
                    e.setMessage(t);
                    Bukkit.broadcastMessage(ChatColor.RED + t);
        //SLOW CONFUSION BLIDNESS       
                }else if(dp > 100 && dp < 149){
                    Bukkit.broadcastMessage("slow confused blindess");
                    String t = msg.replaceAll("so", "...").replaceAll("lol", "crap I peed myself").replaceAll("this", p.getName()).replaceAll("why", "I").replaceAll("no", "yes").replaceAll("yes", "no").replaceAll("help", "I will kill you").replaceAll(
                            "ugh", "man I'm sexy").replaceAll("sucks", "rocks").replaceAll("fun", "furrn").replaceAll("guys", "I'm so alone").replaceAll("the", "thuur").replaceAll("why", "I think").replaceAll("drink", "strip").replaceAll("come here", "get lost").replaceAll("like", "hate")
                            .replaceAll("this", "diss").replaceAll("jk", "I'm serious");
                    e.setMessage(t);
                    Bukkit.broadcastMessage(ChatColor.RED + t);
                }else if(dp > 150){
        //SLOW CONFUSION BLINDNESS NIGHTVISION
                    Bukkit.broadcastMessage("nightvisoion");
                    String t = msg.replaceAll("so", "...").replaceAll("lol", "crap I peed myself").replaceAll("this", p.getName()).replaceAll("why", "I").replaceAll("no", "yes").replaceAll("yes", "no").replaceAll("help", "I will kill you").replaceAll(
                            "ugh", "man I'm sexy").replaceAll("sucks", "rocks").replaceAll("fun", "furrn").replaceAll("bad", "hot").replaceAll("the", "thuur").replaceAll("why", "I think").replaceAll("drink", "strip").replaceAll("hi", "get lost").replaceAll("like", "hate")
                            .replaceAll("this", "diss").replaceAll("jk", "I'm serious").replaceAll("-", "").replaceAll("brb", "I'm so alone").replaceAll("afk", "I want you bad").replaceAll("great", "greatsss").replaceAll("lag", "white power").replaceAll("nuns", "buns").replaceAll(
                            "boone", "booze").replaceAll("funny", "getting really hot").replaceAll("stupid", "..Who touched me").replaceAll("omg", "I think your sexy").replaceAll("wow", "amuzing").replaceAll("see", "rape");
                    Bukkit.broadcastMessage(ChatColor.RED + t);
                    e.setMessage(t);
 
                }else if(dp <20){
                    Bukkit.broadcastMessage("almost sober");
                    String t =msg.replaceAll(" ", "  ");
                    e.setMessage(t);
        //NEAR SOBER       
                        }else{
                            Bukkit.broadcastMessage("nothing");
                        }
                }
            }
        }
 

 

Fiddy_percent I doubt this is what's causing the problem, but it could.

You are accessing Bukkit methods that are expressly not thread-safe from a thread other the main thread, which could create inconsistancies, especially with things like File I/O (reading and writing from config).

 

The replaceAll method expects a regular expression. You should try the replace method.

 

mythbusterma it was working fine before (I changed something a while back and never new how to fix it again)
lualzockt No dice

 

Fiddy_percent

Regardless of whether or not it was working before, you should really still fix that. Plus, thread-safety issues are so finicky that a version update could have broken previously "working" (read: not thread-safe) code.

 

what do I need to know how to do in order to fix that? I know there is a check if async command but if thats not it im totally in the dark

 

Fiddy_percent

9/10 it will be asynchronous, as the only way it is synchronous is if a player is compeled to chat via Player#chat(...).

In this case the simplest solution would be to use the deprecated PlayerChatEvent which is Synchronous, and is only deprecated because it can cause server lag if you're doing a lot of work inside of it (which, in this case, you're not, so it should be okay).

If you're interested in learning about how to make this thread-safe, just ask.

 

Yeah I would love to know that (no point in staying ignorant)

 

Fiddy_percent

Well, any task that requires Bukkit methods (or native Craftbukkit/Minecraft methods, for that matter) is not guaranteed to be thread-safe, so any time you make a call to these methods, it must be done on the main thread.

The BukkitScheduler provides some helpful tools for doing this, namely:

<T> Future<T> callSyncMethod(Plugin plugin, Callable<T> task)

And the series of functions related to this one:

BukkitTask runTask(Plugin plugin, Runnable task)

If you're looking for a value from the main thread, for example if a player is in a HashMap (although you could use ConcurrentHashMap for this) or asking if a player has a permission, you can use the first one which will return a future that the other thread can either block on, or do some other work until it's complete (using the Future#isDone() and Future#get() or Future#get(), respectively).

If you're passing data back to the main thread for execution, for example calling BukkitServer#broadcast(...) you can can run an anonymous runnable on the main thread via the second option, like:

Code:java

Bukkit.getScheduler().runTask(Plugin, new Runnable () {
    @Override
    public void run () {
      // do something
    }
});

Or you can run it with a delay using one of the delay methods.

Any other questions?

 

Thats really useful thanks ill try using that


And by the way I fixed it
hacked an old backed up jar file all i needed to do to my original code was add (String)

Code:java

 e.setMessage((String)m.get(p.getUniqueId()));