Right Click Event

teej107
ive done that but it doesnt do anything now im not sure if i misunderstood you but heres the updated code.

Code:java

        @EventHandler
        public void OnReg2(PlayerInteractEvent event){
            Player player = event.getPlayer();
            ItemStack Hand = event.getPlayer().getItemInHand();
            if(player.hasPermission("potionstaffs.regen")){
                System.out.println("Potions Staff " + player.getName() + " has permission");
                if((event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK)){
                    System.out.println("Potions Staff " + player.getName() + " Right Clicked");
                    if(player.getItemInHand().getItemMeta().getDisplayName().contains(ChatColor.RED + "2")){
                        System.out.println("Potions Staff " + player.getName() + " Success");
                    player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 440, 1));
                    ItemMeta HandM = player.getItemInHand().getItemMeta();
                    HandM.setDisplayName(ChatColor.RED + "Regen Staff - 1 Uses Left");
                    Hand.setItemMeta(HandM);
                    player.sendMessage(ChatColor.GREEN + "Whoosh");
                    }
                    if(player.getItemInHand().getItemMeta().getDisplayName().contains(ChatColor.RED + "1")){
                    player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 440, 1));
                    player.sendMessage(ChatColor.RED + "Your Staff Has Broken");
                    player.getInventory().removeItem(player.getInventory().getItemInHand());
                    }
                }
            }
            else{
            player.sendMessage(ChatColor.RED + "You do not have the required permission.");
            }
        }

 

Benpat9 What do you mean it doesn't do anything?

 

teej107 when i right click the staff it doesnt give me potion effect or say Whoosh

 

The display name from the item is null, is that maybe the problem?
When it checks

Code:

if(player.getItemInHand().getItemMeta().getDisplayName().contains(ChatColor.RED + "2")){

it gives null.
Thats i think is the Problem.

Code:java

    @EventHandler
    public void OnReg2(PlayerInteractEvent event){
        Player player = event.getPlayer();
        ItemStack Hand = event.getPlayer().getItemInHand();
        if(player.hasPermission("potionstaffs.regen")){
 
            System.out.println("Potions Staff " + player.getName() + " has permission");
 
            if((event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK)){
 
                System.out.println("Potions Staff " + player.getName() + " Right Clicked");
 
                if ( player.getItemInHand().getItemMeta().getDisplayName() == null) {
                    ItemMeta HandM = player.getItemInHand().getItemMeta();
                    HandM.setDisplayName(ChatColor.RED + "2");
                    Hand.setItemMeta(HandM);
                }
 
                if(player.getItemInHand().getItemMeta().getDisplayName().contains(ChatColor.RED + "2")){
 
                    System.out.println("Potions Staff " + player.getName() + " Success");
                    player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 440, 1));
                    ItemMeta HandM = player.getItemInHand().getItemMeta();
                    HandM.setDisplayName(ChatColor.RED + "Regen Staff - 1 Uses Left");
                    Hand.setItemMeta(HandM);
                    player.sendMessage(ChatColor.GREEN + "Whoosh");
                } else if(player.getItemInHand().getItemMeta().getDisplayName().contains(ChatColor.RED + "Regen Staff - 1 Uses Left")){
                    player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 440, 1));
                    player.sendMessage(ChatColor.RED + "Your Staff Has Broken");
                    player.getInventory().removeItem(player.getInventory().getItemInHand());
                }
            }
        }
        else{
        player.sendMessage(ChatColor.RED + "You do not have the required permission.");
        }
    }

That works, i think.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Benpat9 What does the console print out? You do print out stuff to the console for your debug code.

 

teej107

console:

Code:

12.07 23:04:29 [Server] INFO Potions Staff benpat9 Right Clicked
12.07 23:04:29 [Server] INFO Potions Staff benpat9 has permission

Code:

Code:java

        @EventHandler
        public void OnReg2(PlayerInteractEvent event){
            Player player = event.getPlayer();
            ItemStack Hand = event.getPlayer().getItemInHand();
            if(player.hasPermission("potionstaffs.regen")){
                System.out.println("Potions Staff " + player.getName() + " has permission");
                if((event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK)){
                    System.out.println("Potions Staff " + player.getName() + " Right Clicked");
                    if(player.getItemInHand().getItemMeta().getDisplayName().contains(ChatColor.RED + "2")){
                        System.out.println("Potions Staff " + player.getName() + " Success");
                    player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 440, 1));
                    ItemMeta HandM = player.getItemInHand().getItemMeta();
                    HandM.setDisplayName(ChatColor.RED + "Regen Staff - 1 Uses Left");
                    Hand.setItemMeta(HandM);
                    player.sendMessage(ChatColor.GREEN + "Whoosh");
                    }
                    if(player.getItemInHand().getItemMeta().getDisplayName().contains(ChatColor.RED + "1")){
                    player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 440, 1));
                    player.sendMessage(ChatColor.RED + "Your Staff Has Broken");
                    player.getInventory().removeItem(player.getInventory().getItemInHand());
                    }
                }
            }
            else{
            player.sendMessage(ChatColor.RED + "You do not have the required permission.");
            }
        }

 

That means that this if test is false:

Code:java

 if(player.getItemInHand().getItemMeta().getDisplayName().contains(ChatColor.RED + "2"))

Try removing the ChatColor.RED from the contains() method and see if it just has the '2' character in it.

 

teej107 that worked but ive got the problem that now it will say it broke even when it should still have 1 use left (it will break after one use)

updated code:

Code:java

        @EventHandler
        public void OnReg2(PlayerInteractEvent event){
            Player player = event.getPlayer();
            ItemStack Hand = event.getPlayer().getItemInHand();
            if(player.hasPermission("potionstaffs.regen")){
                System.out.println("Potions Staff " + player.getName() + " has permission");
                if((event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK)){
                    System.out.println("Potions Staff " + player.getName() + " Right Clicked");
                    if(player.getItemInHand().getItemMeta().getDisplayName().contains("2")){
                        System.out.println("Potions Staff " + player.getName() + " Success");
                    player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 440, 1));
                    ItemMeta HandM = player.getItemInHand().getItemMeta();
                    HandM.setDisplayName(ChatColor.RED + "Regen Staff - 1 Uses Left");
                    Hand.setItemMeta(HandM);
                    player.sendMessage(ChatColor.GREEN + "Whoosh");
                    }
                    if(player.getItemInHand().getItemMeta().getDisplayName().contains("1")){
                    player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 440, 1));
                    player.sendMessage(ChatColor.RED + "Your Staff Has Broken");
                    player.getInventory().removeItem(player.getInventory().getItemInHand());
                    }
                }
            }
            else{
            player.sendMessage(ChatColor.RED + "You do not have the required permission.");
            }
        }

 

Benpat9 That is because you have the code out of order. You check to see if it has 2 uses.

Code:java

 if(player.getItemInHand().getItemMeta().getDisplayName().contains("2"))

That if test returns true so all of the code in there is executed including setting the display name to have 1 use left. By the time your second check (the check for 1 use) comes around,

Code:java

if(player.getItemInHand().getItemMeta().getDisplayName().contains("1"))

your display name already has been set to have 1 use left, therefore making that if statement true.

You can fix this by making the second if statment and else if statement OR by switching the if statements around. I would prefer the first suggestion.

 

teej107 ty i used the first suggestion and it worked, i was wondering if you could help me with my other problem of taking money when this made or would i have to take money using a command (e.g. the staff only works if you use /mage on it) or when first used

 

Benpat9 I do not know what currency plugin you are using. Look up their API for hooking into that for your plugin or yes, use a command.

 

Have anyone seen my post in the top? ^^