Solved Problem adding a static ItemStack to Inventory

So first off, I'm pretty new to Java and I'd highly appreciate it if you could tell me why it didn't work .
So what i wanted to do is create an ItemStack in an a Function and simply add it to the Players Inventory but it does for some reason not work. Instead it throws giant error messages at me. Here is the code:

Code:java

public static ItemStack getClassSelector() {
        ItemStack cs = new ItemStack(Material.NETHER_STAR, 1);
        ItemMeta csmeta = cs.getItemMeta();
        List<String> cslore = csmeta.getLore();
        csmeta.setDisplayName(ChatColor.GREEN + "Class Selector " + ChatColor.GRAY + "(Right Click to open)");
        cslore.add("§eUse this to choose your class to play!");
        csmeta.setLore(cslore);
        cs.setItemMeta(csmeta);
        return cs;
    }

 

Could you please post error log and show the rest of code where you give the player this item?

 

Im not sure how I would copy stuff out of cmd.exe but i can give you the Listener I am currently using this function in
Code:

Code:java

@EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        if (p.getGameMode() == GameMode.SURVIVAL) {
            e.setJoinMessage("§9"+p.getDisplayName()+" §ejoined the game§a (INGAME)");
            API.ingameplayers.add(p);
            p.sendMessage("§eWelcome back§5 "+p.getDisplayName()+" §e. Have fun playing!");
            p.setScoreboard(API.board);
            API.ingameteam.addPlayer(p);
        }
        if (p.getGameMode() == GameMode.ADVENTURE) {
            p.teleport(API.getCastleLocation);
            e.setJoinMessage("§9"+p.getDisplayName()+" §ejoined the game§c (LOBBY)");
            p.sendMessage("§eWelcome back§5 "+p.getDisplayName()+" §e. Choose a class and walk through the Portal!");
            p.setScoreboard(API.board);
            API.jointeam.addPlayer(p);
            p.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 0));
            p.getInventory().addItem(Items.getClassSelector());
        }
        if (p.getGameMode() == GameMode.CREATIVE) {
            p.setScoreboard(API.board);
            e.setJoinMessage("§9"+p.getDisplayName()+" §ejoined the game§6 (ADMIN)");
        }
    }

 

Right-click cmd select mark, highlight what you want and press enter to copy. Not sure about enter but I think so

 

Code:java

public static ItemStack getClassSelector() {
ItemStack cs = new ItemStack(Material.NETHER_STAR);
ItemMeta csmeta = cs.getItemMeta();
List<String> cslore = new ArrayList<String>();
csmeta.setDisplayName(ChatColor.GREEN + "Class Selector " + ChatColor.GRAY + "(Right Click to open)");
cslore.add("§eUse this to choose your class to play!");
csmeta.setLore(cslore);
cs.setItemMeta(csmeta);
return cs;
}

I changed

Code:java

List<String> cslore = csmeta.getLore();

Into

Code:java

List<String> cslore = new ArrayList<String>();

(I'm pretty sure this removes current lore, which is something you probably don't need)

 

Thanks so far . Here is the Error Log in the Console:

Code:java

[22:56:42 ERROR]: Could not pass event PlayerJoinEvent to WoK v0.0.1
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:427) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:62) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.j
ava:481) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:466) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PlayerList.c(PlayerList.java:225) [craft
bukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PlayerList.a(PlayerList.java:116) [craft
bukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.LoginListener.c(LoginListener.java:78) [
craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.LoginListener.a(LoginListener.java:42) [
craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:149
) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [craf
tbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:6
55) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:2
50) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:5
45) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java
:457) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:6
17) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
Caused by: java.lang.NullPointerException
at me.tada89.mc.WoKItemList.getClassSelector(WoKItemList.java:21) ~[?:?]
 
at me.tada89.mc.JoinListener.onJoin(JoinListener.java:37) ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0
_45]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0
_45]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1
.7.0_45]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_45]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:425) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
... 14 more

 

That seems to be something else, could you show me the full class? I don't know where either line 21 in WoKItemList or line 37 in your JoinListener is.

 

Ok then.
WoKItemList:

Code:java

package me.tada89.mc;
 
import java.util.List;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.event.Listener;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class WoKItemList implements Listener {
 
    //ItemStacks
        //Lobby
            //Class Selector (CS)
    public static ItemStack getClassSelector() {
        ItemStack cs = new ItemStack(Material.NETHER_STAR, 1);
        ItemMeta csmeta = cs.getItemMeta();
        List<String> cslore = csmeta.getLore();
        csmeta.setDisplayName(ChatColor.GREEN + "Class Selector " + ChatColor.GRAY + "(Right Click to open)");
        cslore.add("§eUse this to choose your class to play!");
        csmeta.setLore(cslore);
        cs.setItemMeta(csmeta);
        return cs;
    }
 
}

JoinListener:

Code:java

package me.tada89.mc;
 
import org.bukkit.Bukkit;
import org.bukkit.GameMode;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
import org.bukkit.scoreboard.Team;
 
public class JoinListener implements Listener{
 
 
    //Listener
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        if (p.getGameMode() == GameMode.SURVIVAL) {
            e.setJoinMessage("§9"+p.getDisplayName()+" §ejoined the game§a (INGAME)");
            API.ingameplayers.add(p);
            p.sendMessage("§eWelcome back§5 "+p.getDisplayName()+" §e. Have fun playing!");
            p.setScoreboard(API.board);
            API.ingameteam.addPlayer(p);
        }
        if (p.getGameMode() == GameMode.ADVENTURE) {
            p.teleport(API.getCastleLocation);
            e.setJoinMessage("§9"+p.getDisplayName()+" §ejoined the game§c (LOBBY)");
            p.sendMessage("§eWelcome back§5 "+p.getDisplayName()+" §e. Choose a class and walk through the Portal!");
            p.setScoreboard(API.board);
            API.jointeam.addPlayer(p);
            p.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 0));
            p.getInventory().addItem(WoKItemList.getClassSelector());
        }
        if (p.getGameMode() == GameMode.CREATIVE) {
            p.setScoreboard(API.board);
            e.setJoinMessage("§9"+p.getDisplayName()+" §ejoined the game§6 (ADMIN)");
        }
    }
 
}

There is really not that much more to it :/.

Nevermind Zaaryus fixed it already I just oversaw the reply with the Lore thingy. I guess you can't use existing Lore because using a new ArrayList instead of getting the existing lore fixed it for me. Thanks for helping .

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Okay! Good that you fixed it, good luck with your plugin!
BTW: Remember to mark as solved when it's solved!