PlayerCommandPreprocessEvent does not work.

This is really messing me up. I have a section of my plugin where it changes the /pl or /plugins command using a PlayerCommandPreprocessEvent, but it always says its an incorrect command.

I have no aliases defined. Here is my code:

Code:java

@EventHandler
    public void cmdMsg(PlayerCommandPreprocessEvent event) {
 
        Player player = (Player) event;
 
        if (event.getMessage().equalsIgnoreCase("pl")) {
            event.setCancelled(true);
            player.sendMessage(ChatColor.RED + "Hub developed by "
                    + ChatColor.GOLD + "PistonGaming." + ChatColor.RED + " "
                    + ChatColor.ITALIC + "Other plugins are " + ChatColor.GOLD
                    + "" + ChatColor.BOLD + ChatColor.ITALIC + "private.");
        } else if (event.getMessage().equalsIgnoreCase("plugins")) {
            event.setCancelled(true);
            player.sendMessage(ChatColor.RED + "Hub developed by "
                    + ChatColor.GOLD + "PistonGaming." + ChatColor.RED + " "
                    + ChatColor.ITALIC + "Other plugins are " + ChatColor.GOLD
                    + "" + ChatColor.BOLD + ChatColor.ITALIC + "private.");
        } else if(event.getMessage().equalsIgnoreCase("pl") && player.isOp()) {
            event.setCancelled(false);
        } else if(event.getMessage().equalsIgnoreCase("plugins") && player.isOp()) {
            event.setCancelled(false);
        }
 
    }

Also, how would I go about making it so ops can see the plugin list, but non-ops see what I have above?

 

Did you register the commands in the plugin.yml?!

 

Avery246813579 No... xD I thought since those commands already existed that I wouldn't need to :/ I'll try right now.

 

Camaflicks If you have a command in your plugin. You have to register it in the plugin.yml. Since the plugin.yml basicly says: Hey we have /pl here. Look here to see if you can find it!

 

Avery246813579 OK Well I registered it... and it didn't work. I did /pl and its unknown. I did /plugins and it brings a plugin list. Could you show me an example, or do you not know how? (Of the actually eventhandler)

 

Camaflicks

I'm not sure exactly what's going on... but to me, the first step is to almost always add debugging lines... Debugging lines just display a message to the console or a player... So that you know if the event is being called or not.

Code:java

@EventHandler
public void cmdMsg(PlayerCommandPreprocessEvent event) {
 
    Player player = (Player) event.getPlayer();
    player.sendMessage("PlayerCommandPreprocessEvent() called.");
    System.out.println("PlayerCommandPreprocessEvent() called.");
 

 

I don't quite understand how you're trying to do this... Do you have an executor set for the /pl and /plugins command? Or are you only listening to the PlayerCommandPreprocessEvent? If it's the second case, you don't need to add the commands to your plugin's plugin.yml.

 

He is not looking for his own command, but for Bukkit's /plugins
Camaflicks you are casting an PlayerCommandPreprocessEvent to a Player, which with always break.
That aside, remember that commands can consist of more than just the command, for example a / at the beginning or possible extra arguments (even if the command doesn't use arguments, it's an easy way to bypass your block)
Thirdly,

Code:java

if(something true)
{
    event.setCancelled(true);
}
else if(permission check)
{
    event.setCancelled(false);
}

won't really work due to the fact that the permission check won't be ran. You will need to check whether

Code:java

if(something true AND no permission)
{
    event.setCancelled(true);
}

 

fireblast709

Can't Camaflicks just create a new command using the onCommand method and override the /pl and /plugins one in the plugin.yml?

 

ZodiacTheories
I do that all the time.

 

ZodiacTheories I think that won't work as the registration of commands can't be overridden. For example, say you want to override the /message command of Essentials, you would have to make sure your plugin loads before Essentials, so you can claim the registration of the /message command.

 

Camaflicks Since you are using this event, you do not need to add anything to the plugin.yml, since it is an event, not a command that needs to be registered. I can give you some code that I wrote for this soon, it does exactly what you want.

 

Traks

I just remember reading something that said you could.

 

Camaflicks

Code:java

    @EventHandler
    public void onPreCommand(PlayerCommandPreprocessEvent e) {
        Player player = e.getPlayer();
        String message = e.getMessage();
 
        List<String> commands = new ArrayList<String>();
 
        commands.add("/plugins");
        commands.add("/pl");
        if(commands.contains(message)) {
            if(!player.hasPermission("example.permission") || !player.isOp()) { //IF they dont have permission it will cancel the ecevt hand send them the message
                e.setCancelled(true);
                player.sendMessage(ChatColor.RED + "Hub developed by "
                    + ChatColor.GOLD + "PistonGaming." + ChatColor.RED + " "
                    + ChatColor.ITALIC + "Other plugins are " + ChatColor.GOLD
                    + "" + ChatColor.BOLD + ChatColor.ITALIC + "private.");
            }
        } else { //If they do have permission it won't cancel the event
            e.setCancelled(false);
        }
 
    }

 

No spoonfeeding please, he pretty much has all the answers in the thread already.

Go Hard ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

 

fireblast709 "some". I'm not going to make him an entire plugin, he already has the plugin done,.I can show him my code so he can see if there is anything wrong. The fault in his code doesn't seem to major either.

 

Jaaakee224 Rather give him pointers so he can fix it himself. That way he will learn from his mistakes.

 

Jaaakee224 Well that would be ultimately helpful!