ArrayList doesn't seem to be working

Okay so I'm making a kit called vampire. What this kit does is when you kill someone it will give them a potion of instant damage or health I don't remember, but anyways When I do /vampire and kill someone I don't get regeneration or a potion at all.

Main Class

Code:java

package Bods.Main;
 
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.event.Listener;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
import Bods.Commands.CommandVampire;
 
public class Main extends JavaPlugin implements Listener {
 
    public final Logger logger = Logger.getLogger("Minecraft");
 
 
    @Override
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Has been disabled! ");
    }
 
    @Override
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " has been enabled! " + pdfFile.getDescription() + pdfFile.getAuthors());
 
        PluginManager pm = Bukkit.getServer().getPluginManager();   
        pm.registerEvents(new CommandVampire(), this);
            getCommand("vampire").setExecutor(new CommandVampire());    }
 
}

Here's the Vampire Class

Code:java

package Bods.Commands;
 
import java.util.ArrayList;
 
import org.bukkit.ChatColor;
import org.bukkit.Color;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.LeatherArmorMeta;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
 
public class CommandVampire implements Listener, CommandExecutor {
 
        public double Boost = (18.0D);
 
        ArrayList<String> Vampire = new ArrayList<String>();
 
        @EventHandler
        public void Remove(PlayerDeathEvent e) {
            Vampire.remove(e.getEntity().getPlayer().getName());
        }
 
        @EventHandler
        public void onDeath(PlayerDeathEvent e) {
            if (Vampire.contains(e.getEntity().getPlayer().getName())) {
            Player k = e.getEntity().getPlayer().getKiller();
            k.setHealth(Boost);
            k.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 10 , 10));
            k.getInventory().addItem(new ItemStack(Material.POTION, 1, (short)16428));
            }
        }
 
            public boolean onCommand(CommandSender sender, Command cmd, String label,
                String[] args) {
 
            Player player = (Player)sender;
 
            if(cmd.getName().equalsIgnoreCase("vampire")) {
 
            player.getInventory().clear();
 
            ItemStack Helm = new ItemStack(Material.LEATHER_HELMET);
            LeatherArmorMeta Helmet = (LeatherArmorMeta)Helm.getItemMeta();
            Helmet.setColor(Color.RED);
            player.getInventory().setHelmet(Helm);
 
            ItemStack Chest = new ItemStack(Material.LEATHER_CHESTPLATE);
            LeatherArmorMeta Chestplate = (LeatherArmorMeta)Chest.getItemMeta();
            Chestplate.setColor(Color.BLACK);
            player.getInventory().setChestplate(Chest);
 
            player.getInventory().setLeggings(new ItemStack(Material.GOLD_LEGGINGS));
 
            player.getInventory().setBoots(new ItemStack(Material.IRON_BOOTS));
 
            ItemStack Sword = new ItemStack(Material.IRON_SWORD);
            Sword.addUnsafeEnchantment(Enchantment.DAMAGE_ALL, 2);
            Sword.addUnsafeEnchantment(Enchantment.DURABILITY, 15);
 
            player.getInventory().addItem(new ItemStack[] { Sword });
 
            for (int Soup = 0; Soup < 35; Soup++) {
                player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            }
 
            player.sendMessage(ChatColor.YELLOW + "You have received the Vampire Kit!");
 
            Vampire.add(player.getName());
 
            }
 
        return false;
    }
 
}
 
 

And the plugin.yml

name: BodsPvP

version: 1.0

main: Bods.Main.Main

commands:

vampire:

description: When you kill another player you get healed and get a splash potion of healing!

 

You are creating 2 CommandVampire instances between your event registering and setting your command executor. Try assigning CommandVampire to one variable so you won't create 2 instances of it and see if that works.

Edit: Oh I see something else. This might be called before your onDeath event.

Code:java

 @EventHandler
        public void Remove(PlayerDeathEvent e) {
            Vampire.remove(e.getEntity().getPlayer().getName());
        }

 

teej107 what do you mean by I am assigning 2 CommandVampire instances does that mean Im register my event ad command in the same class?

 

JellyYods No, what I mean is that you are creating 2 CommandVampire instances. But I don't think that is the problem. What I think is the problem is this method/event you have here:

Code:java

 @EventHandler
public void Remove(PlayerDeathEvent e) {
Vampire.remove(e.getEntity().getPlayer().getName());
}

It might be being called before your other event.

 

You should do this:

Code:java

CommandVampire cv = new CommandVampire();
pm.registerEvents(cv, this);
getCommand("vampire").setExecutor(cv);
 

That way you don't get two instances of the same class. They would each have a different copy of the list of players.

EDIT: What the other guy said is a problem too. Just make it so the remove method is not an event handler and call it from your other on death event method after you do everything else that you need to.

 

spy_1134 JellyYods Yes that is a good idea but I don't think that is causing the problem. It is probably his Remove method conflicting with the onDeath method.

 

It's just as big of a problem actually. If the player only gets added to the list in the command handler copy of that class then the one handling events will never see them and won't do anything after they kill a player because it will look as if they had never entered the command in the first place. They need to be the same instance and that needs to be fixed too to prevent the player being removed from the list before the event is triggered.

 

Alright so the first one on the Remove I set it to the very bottom of the class so that shouldn't be an issue and in Main class I did what you wrote accept with cv I did Cvampire

 

JellyYods Instead of having 2 of the same event, why don't you put the code bit in Remove at the bottom of onDeath? Just my suggestion.

spy_1134 Good point. I didn't think about that. That is what is causing the problem but also your Remove method could be called first which would also thwart your onDeath method

 

Alright so spy_1134 I need to put it the way I had it and remove the DeathEvent where it remove them from the array list

 

The name can be whatever you want so long as you keep it consistent. Naming conventions dictate that you should typically only use capital letters in the beginning of class names and not variables however, so cVampire would be a good name, but Cvampire wouldn't.

Edit: Do what the other guy said too and make it so your remove method is not an event handler. Just run it from the end of your other on death event method.

 

Thank you spy_1134 and teej107 it works Thanks again I have been working for a day now

 

Set status to solved please when solved, I was reading this until I found out it had already been solved!

 

I have another problem I have the pvp kit When I kill someone it gives them the regen and the potion, but not the vampire when I get a kill it only worls once then the second time as a vampire it does nothing happenes
I think it might have to do with them removing the player from the list during the

I fixed the pvp kit and any kit getting a potion and regen but vampire works once when you kill someone

I think I need to do something like this spy_1134 teej107

Code:java

rrayList<String> Vampire = new ArrayList<String>();
 
        @EventHandler
        public void onDeath(PlayerDeathEvent e) {
            if (Vampire.contains(e.getEntity().getPlayer().getName())) {
            Player killed = e.getEntity().getPlayer();
            Player killer = e.getEntity().getPlayer().getKiller();
            if(killer instanceof Player && killed killed)
            killer.setHealth(Boost);
            killer.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 20 , 20));
            killer.getInventory().addItem(new ItemStack(Material.POTION, 1, (short)16428));
            }
            Vampire.remove(e.getEntity().getKiller());
        }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

JellyYods If you want to give the regen and a potion everytime, don't remove them from the arraylist. Also please check Java Naming Conventions. Variables don't start with capital letters. It won't hurt your code but it's a rule that Java developers should follow.

 

Well I don't want them to get potions anymore after they die unless they do the command again I'm making a kit server

So I don't pvp kit getting pots

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

JellyYods You're removing the player's killer and not the player

Code:java

Vampire.remove(e.getEntity().getKiller());

 

Alright so Im pvp kit I get regen and pots all the time when Im vampire it gives it to me once because at the bottom of the code it removes me how do I keep it in till I die

Where would I put the code

 

JellyYods

It looks fine where it is at.